Andrii Verbytskyi authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Prefer prefix ++/-- operators for non-primitive types as suggested by cppcheck

Andrii Verbytskyi authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Use prefix increment operator as suggested by cppcheck

Andrii Verbytskyi authored 2 years ago and Frank Winklmeier committed 2 years ago

Use prefix instead of postfix operators in loops as suggested by cppcheck, part 2

Liaoshan Shi authored 2 years ago and Julien Maurer committed 2 years ago

Check in Heavy Ion settings for the online event displays

Christos Anastopoulos authored 2 years ago and Tadej Novak committed 2 years ago

Create specific AEOTrackStateOnSurface for the case of TSOS with Alignement effects on track

Christos Anastopoulos authored 2 years ago and Tadej Novak committed 2 years ago

TSOS: keep FitQualityOnsurface as value. Re-organise constructors

Christos Anastopoulos authored 2 years ago and Walter Lampl committed 2 years ago

FitQualityOnSurface make it trivial

Johannes Junggeburth authored 2 years ago and Marija Vranjes Milosavljevic committed 2 years ago

Manually cherry pick 56646

Remove dependency on old EventInfo class.

Remove dependency on old EventInfo class.

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

JiveXML: Remove dependency on old EventInfo.

Use pileup info from xAOD EventInfo rather than PileUpEventInfo.

Johannes Junggeburth authored 2 years ago and Tadej Novak committed 2 years ago

MuonReadoutGeometry rotate stereo surfaces by their stereo angle. Insert segment seeding based on 4 out of 8 MM layers

Scott Snyder authored 2 years ago and Edward Moyse committed 2 years ago

GeometryJiveXML: Fix cppcheck warnings.

Fix cppcheck warnings.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

JiveXML: Fix cppcheck warnings.

Fix cppcheck warnings.

Enable thread-safety checking.

Fix gcc12 false positive warning by moving a function out-of-line.

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

TrackingVolume/TrackingGeometry more const fixes

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

In various places we were declaring TrackingVolumes as const, and then we were manipulating them later on in the call chain.

We do no need to create new Tracking Volumes as const as a starting point. Especially if the next step is manipulate/fill them by passing them to relevant tools ....

So the proper idea seems to be (done in other MT related migrations) :

* Let's create them as non-const
* manipulate/ add to them/ glue them together,
* when we are done access them later on `as const` via proper `const correct` interfaces.

This MR is step 0, the basic prequisite for cleaning up of all the helpers/processors etc etc. It avoids a few `const_cast` and marks back some methods as `THREAD_SAFE` already.

Liaoshan Shi authored 2 years ago and Julien Maurer committed 2 years ago

Update online event displays configurations

Christos Anastopoulos authored 2 years ago and Johannes Elmsheuser committed 2 years ago

use CxxUtils::span for const-correct interfaces. Allow to have const non const methods for a std::vector<T*> field.

Frank Winklmeier authored 2 years ago and Johannes Elmsheuser committed 2 years ago

EventDisplayFilters: enable thread-checker and fixes

Remove use of DataHandle.

Johannes Elmsheuser authored 2 years ago and Walter Lampl committed 2 years ago

Fix for ATEAM-841. Handle Sun RPC remote address information transparently for IPv4 and IPv6 by using the generic getnameinfo() function. This includes Attila's suggested patch for CMake and the FindRPC.cmake and compiles on both CentOS 7 and 9. Adding the recommended constants to use for the size of result buffers of getnameinfo().  Patch orginally provided by Reiner Hauser.

Make the package compile if QT_NO_SSL is defined and treat like QSslSocket::supportsSsl() returns false. See ATLASVPONE-553. Patch orginally provided by Reiner Hauser

This package defined pre-xAOD retrievers for Jet and MET used in
Atlantis. Delete package and references to it.

Shaun Roe authored 2 years ago and Tadej Novak committed 2 years ago

23.0-cppcheck-VP1Systems

Fix thread-checker warnings in client packages by using `std::atomic`
or `const` for boolean flags.

The "environment" argument to `TriggerConfigGetter` has no real purpose
anymore. Remove it and also the automatic fallback to disable the
trigger (`rec.doTrigger`) if the input does not have the relevant
information. In that case this "Getter" should just not be called.

Liaoshan Shi authored 2 years ago and Frank Winklmeier committed 2 years ago

EventDisplaysOnline: fix a typo and bump public stream project tag to data22