FastWalkthrough (CPU version)

The fast version of the Walkthrough algorithm, currently only running on CPU. Functionality is already here in this draft, I just need to remove some of the timing code used for the PUB note.

added 2 commits

• 6f16ab8d - Remove datareader files
• 0b60cedb - Remove notebook and testing configs

Compare with previous version

added 1 commit

• 2e6a7568 - Revert to dev version of reader files and cc_and_walk files

Compare with previous version

added 1 commit

• 79725841 - Revert to dev version of loading utils

Compare with previous version

added 1 commit

• 7e8701df - Remove logging and timing code

Compare with previous version

added 1 commit

• 6c493d88 - Remove final timing references

Compare with previous version

marked this merge request as ready

resolved all threads

Hmmm.. rebasing it not working. I am also struggling to do it locally. Let me figure this out.

Hummm maybe it's because you have attempt the rebase via gitlab first. I have tried once with conflict, it took me a while to repair it. Let me know how it goes and if you need any help.

added 21 commits

• 6c493d88...63336250 - 20 commits from branch dev
• 1da74ee2 - Merge in feature name fix from dev

Compare with previous version

@scaillou Okay, this is fixed. Should be good to go.

• Tested with Rel24 scored graphs, runs in less than 1 second per graph (most of this is data loading and saving)

This is great! Would you please to add an exemplar configuration in at least one Example in the example folder so that users know how to use it properly.

added 5 commits

• 54b9d769 - Rename filtered graph keys with new maming scheme
• f964bf1f - protect the graph of renaming if old naming scheme used
• 0d07955f - add basic timing (needed in eval)
• f528215c - applying new naming scheme
• 221fbffe - import remove_variable_name_prefix_in_pyg

Compare with previous version

Hi @dmurnane I have added a few fixes to ensure compatibility with the new naming scheme and the eval. Can you have a quick look at it ?

• Tested with CTD23 scored graphs (infer + eval) with the old naming scheme
• Tested with CTD23 scored graphs (infer + eval) with the new naming scheme

approved this merge request

added 2 commits

• 322a8301 - Remove handle_feature_names function, due to new feature names handled elsewhere
• 9dd88a81 - Add fast walkthrough config to Example 2, and describe in README

Compare with previous version

resolved all threads

added 3 commits

• 9dd88a81...bfea733c - 2 commits from branch dev
• fc754bb2 - Merge branch 'dev' of ssh://gitlab.cern.ch:7999/gnn4itkteam/acorn into dmurnane_faster_walkthrough

Compare with previous version