Skip to content
Snippets Groups Projects
Jay Chan's avatar
approved merge request !178 "Add option for trackML label" at GNN4ITkTeam / acorn
Yuan-Tang Chou's avatar
pushed to branch yuchou-dbscan-dev at GNN4ITkTeam / acorn
Yuan-Tang Chou's avatar
opened merge request !178 "Add option for trackML label" at GNN4ITkTeam / acorn
Yuan-Tang Chou's avatar
pushed new branch yuuchou-dev-trackml at GNN4ITkTeam / acorn
Yuan-Tang Chou's avatar
commented on merge request !177 "Add DBScan to track building" at GNN4ITkTeam / acorn

That will require changes of these and all relevant lines https://gitlab.cern.ch/gnn4itkteam/acorn/-/blob/dev/acorn/stages/track_building/utils.py#L40...

Alexis Vallier's avatar
commented on merge request !175 "Draft: Module Map Graph integration" at GNN4ITkTeam / acorn

Stupid comment: shouldn't it be 2023-2025 ?

Alexis Vallier's avatar
commented on merge request !175 "Draft: Module Map Graph integration" at GNN4ITkTeam / acorn

I agree that the README shoudl be updated to explain how to use MMG. I'm not sure though it shoudl be added to the requirement list, maybe only as ...

Jay Chan's avatar
commented on merge request !177 "Add DBScan to track building" at GNN4ITkTeam / acorn

This should be hit_track_labels, as it's a hit-like feature, but I think the same problem exists in other track building methods too

Yuan-Tang Chou's avatar
commented on merge request !177 "Add DBScan to track building" at GNN4ITkTeam / acorn

@xju @cchan Could you have a look when you find time? I hope I didn't do something stupid in the code

Yuan-Tang Chou's avatar
pushed to branch yuchou-dbscan-dev at GNN4ITkTeam / acorn
Yuan-Tang Chou's avatar
pushed to branch yuchou-dbscan-dev at GNN4ITkTeam / acorn
Yuan-Tang Chou's avatar
opened merge request !177 "Add DBScan to track building" at GNN4ITkTeam / acorn
Yuan-Tang Chou's avatar
pushed new branch yuchou-dbscan-dev at GNN4ITkTeam / acorn
Xiangyang Ju's avatar
commented on merge request !175 "Draft: Module Map Graph integration" at GNN4ITkTeam / acorn

A quick comment. should the mmg be added to the requirement list with some instructions of how to install it?

Sylvain Caillou's avatar
approved merge request !176 "Use prefix in filename for graph construcion" at GNN4ITkTeam / acorn
Alexis Vallier's avatar
commented on merge request !176 "Use prefix in filename for graph construcion" at GNN4ITkTeam / acorn

Ah yes, you are right, I was just making it quick for graph construction stage. But it would be good to update the rest accordingly

Sylvain Caillou's avatar
commented on merge request !176 "Use prefix in filename for graph construcion" at GNN4ITkTeam / acorn

Does it make sense to extend this MR to use prefix in the later stages of acorn ?

Alexis Vallier's avatar
pushed to branch avallier_data_reading_v9 at GNN4ITkTeam / acorn
  • 907d45b4 · add proper option to have prefix in graph construction
Alexis Vallier's avatar
opened merge request !176 "Use prefix in filename for graph construcion" at GNN4ITkTeam / acorn