Remove automatic reset functionality from context managers
After my recent testbeam experience, I'm starting to become convinced that the current practise of adding reset_on_init
, off_on_close
, and similar "safety" behaviours to devices that modify context opening and closing is rather more dangerous than not, since the default values of these are often set to occur by default at the moment, and this can often lead to unexpected behaviours as a result, or accidental resets of devices or powering setups when developing icicle-backed scripts.
I would suggest hard-deprecating this form of behaviour in ICICLE as a whole (with a minor version bump); however, this would require Dirigent, InstrumentCluster, and other downstream dependencies to pull reliance on the feature and reimplement any such safety measures in a local context. @tharte, @bristic, @gbonomel, @dabacher; any thoughts?