fixing presel for DIPZ case, new DIPZ syntax and test chains

See merge request atlas/athena!67623

Ines Ochoa authored 1 year ago and Edward Moyse committed 1 year ago

fixing presel for DIPZ case, new DIPZ syntax and test chains

TrigT1TRT: fixed clang warnings

See merge request atlas/athena!67661

Use MC:: namespace explicitly for MuDstarFilter

See merge request atlas/athena!67648

Andrii Verbytskyi authored 1 year ago and Edward Moyse committed 1 year ago

Use MC:: namespace explicitly for MuDstarFilter

HF Classifier Package.

See merge request atlas/athena!67455

Adrian Berrocal Guardia authored 1 year ago and Edward Moyse committed 1 year ago

Cleaning of HadronOriginClassifier code.

During the implementaiton of the HF classification, the code of
HadronOriginClassifier was modified to find a bug in it. Most of this
modifications were comments and prints to find the bug and they have
been removed now that is fixed.

first test of using LeptonTaggers in MUON5

See merge request atlas/athena!67496

Marco Vanadia authored 1 year ago and Edward Moyse committed 1 year ago

Convert r21 decorators to const Accessor for vertex fits

Previously, secondary vertex decoration was done using a syntax like

(*decorator)(*vertex) = value;

This has been changed in two places to use a const Accessor, as this
makes the logic of the decoration more obvious and might avoid some
subtle bugs with decoration. This was an attempt to resolve a warning

WARNING saveSecondaryVertices - missing "SecondaryVertexIndex" variable

but this change does not seem to fix the problem.

Protect vertex momentum and sumPt decoration to avoid overwriting locked store

See merge request atlas/athena!67643

Thomas Strebler authored 1 year ago and Edward Moyse committed 1 year ago

Protect vertex momentum and sumPt decoration to avoid overwriting locked store

Removed the local variant of isHadron from MCTruthClassifier

See merge request atlas/athena!67605

Andrii Verbytskyi authored 1 year ago and Edward Moyse committed 1 year ago

Removed the local variant of isHadron from MCTruthClassifier

Update in jFEXCondAlgo to read the correct parameters from COOL after change of json structure for jFEX noise cuts

See merge request atlas/athena!67638

Niklas Schmitt authored 1 year ago and Edward Moyse committed 1 year ago

Update in jFEXCondAlgo to read the correct parameters from COOL after change of json structure for jFEX noise cuts

Update in jFEXCondAlgo to read the correct parameters from COOL after change of json structure for jFEX noise cuts

CxxUtils: Fix cppcheck warnings.

See merge request atlas/athena!67659

Scott Snyder authored 1 year ago and Edward Moyse committed 1 year ago

CxxUtils: Fix cppcheck warnings.

cppcheck needs to see assert() to get assumptions right.
Ignored function return value.

AthenaAuditors: Fix use of splay_set::erase.

Closes ATLINFR-5179

See merge request atlas/athena!67651

Scott Snyder authored 1 year ago and Edward Moyse committed 1 year ago

AthenaAuditors: Fix use of splay_set::erase.

Forgot to change erase to erase_and_dispose in a few places
in the last change.
Fixes compilation with gcc11.

Rename Barcode class to PartPropCache for InDetValidation

See merge request atlas/athena!67613

Andrii Verbytskyi authored 1 year ago and Edward Moyse committed 1 year ago

Rename Barcode class to PartPropCache for InDetValidation

Braces at initialization of multi-dimensional arrays

Externals Update, main branch (2023.12.05.)

See merge request atlas/athena!67612

Attila Krasznahorkay authored 1 year ago and Edward Moyse committed 1 year ago

StripGmxInterface: fixed signature of the addSplitSensor() virtual method

Added one extra argument, as required by GeoModel 4.5.0.

Segment use move to ctors

See merge request atlas/athena!67624

Christos Anastopoulos authored 1 year ago and Edward Moyse committed 1 year ago

Segment use move to ctors

Separated readout geometry calculation from geometry build in MuonGeoModel::Mdt

See merge request atlas/athena!67634

Joseph Boudreau authored 1 year ago and Edward Moyse committed 1 year ago

Separated readout geometry calculation from geometry build in MuonGeoModel::Mdt

Compilation fixes for the main--HepMC2 nightly

See merge request atlas/athena!67640

John Derek Chapman authored 1 year ago and Edward Moyse committed 1 year ago

Compilation fixes for the main--HepMC2 nightly

LumiBlock+AFP+TPCnv: use default test geometry tags

See merge request atlas/athena!67633

MuonSpectrometer: use default test geometry tags

See merge request atlas/athena!67632

OverlayConfiguration: Update legacy overlay RDO compression settings to match the new configuration

Closes ATLASSIM-7002

See merge request atlas/athena!67614

Alaettin Serhan Mete authored 1 year ago and Edward Moyse committed 1 year ago

OverlayConfiguration: Update legacy overlay RDO compression settings to match the new configuration

Add missing configuration dependencies

See merge request atlas/athena!67635

Will Buttinger authored 1 year ago and Edward Moyse committed 1 year ago

Add missing configuration dependencies

ITk: cleanup some of the utility/tests scripts and use the default geometry

See merge request atlas/athena!67631

More changes to MDT CSV dumper for ACTS standalone interoperability

See merge request atlas/athena!67598