Former-commit-id: 606b8ebb36b6664ff40472bd625dbc70aec620a4

Former-commit-id: 5bd6df1a88922e04455be3f968c8292f4067b0c9

Former-commit-id: a3ea614f07970c516f7828716fa8c1b7276db5f9

synchronize CI scripts

See merge request !1077

Former-commit-id: d13ccf502127b81f1663d74169c2944de7377243

The python scripts used by the CI system have evolved a bit. While
the current version of the CI scripts in 21.0 are still functional
they exhibit a different subtly different behavior (most importantly
the assignment of review labels). To simplify the life of the MR
review shifters and to streamline the CI setup, this MR brings in
the changes to the CI scripts from the master branch.


Former-commit-id: 29ff962eed9d7851fce8e404329c19503d89a63a

Updates to the Jenkins CI infrastructure rely on some changes in the
CI scripts. This MR ports those changes from the master branch.


Former-commit-id: b702d0793c696e10c59c926ee6ab5964be882e77

Former-commit-id: 8cde96e16b0ae6eff5c78df4b595e311895dda97

In the case of short-circuited MRs (skipping the review process),
a MR can be closed before the CI job for assigning the Gitlab labels
is run. In this case, domain labels should still be assigned to
facilitate future searches for MRs by domain. Review labels are still
added in case a post-facto review is desired.


Former-commit-id: 7b12fb512e0d7e5811a2c83e01c457f7c74277d4

Due to the problem of creating duplicate CI jobs when a MR is updated
while the initial CI job is still running, a mechanism has been put
in place to cancel the second (duplicate) job. This leads to a failed
Jenkins CI job. Publishing the build status using the functionality
of the jenkins-gitlab plugin would cause major confusion since the
developer would quickly get a 'failed build' comment from the aborted
job and later the actual build result from the initial CI job (which
can take up to 5h to complete). Therefore, this functionality is not
used but a comment with the build status (and links to the logfiles)
is added manually to the Gitlab MR discussion.


Former-commit-id: babe005cce971347d5a0298e544545fc018d1a4b

Former-commit-id: a5a37ae4ff4dedbbb876d63912c63c11511e7842

Former-commit-id: 8408e2e806bea863de82a90aca9a649db4f70b79

Former-commit-id: e2bc07f238f7ce6cb3aad44d16e22b1cd79ddfa5

Former-commit-id: 5f693b27cda4c5c1492d264d4e2d2abcff381bee

Former-commit-id: b155bf984de1f529bd409227c305e7b5d723e765

Since the set of affected packages is used in various places of this code,
it should not be modified in any of those functions.


Former-commit-id: 012ea93776c3d89924117c08b19929918b7404ad

For repository-wide changes, many packages are affected. If the list
of affected packages becomes very long, the automatic comment from
the atlasbot does not really help, but only makes following the
discussion on the Gitlab web interface more difficult. Therefore,
the list of affected packages is only printed for at most 20 packages.

Closes ATLINFR-1488


Former-commit-id: c5080e62274c294ccd3405c10f8b31e3b4072639

If the list of affected packages grows large, having them sorted
alphabetically helps finding individual packages.


Former-commit-id: c844da50a22e0f93d8cd69200b5c5fc30c9339f9

Since at the moment it is not possible to filter MRs in Gitlab based
on their target branch, we add a label specifying the target branch
manually. In this way, review shifters and release coordinators can
easily filter MRs by their target release.


Former-commit-id: f6c9b071dd0ee9d69b7e4dbed43422dd33e6c858

cherry-picked from 507b29295bf5dd0d66 [formerly 66fe598885987cc7c3]


Former-commit-id: c8f7a2c584f84d750081c751da7730f2aa6cdcdf

The way how we detect include-directories of Athena packages may
seem a bit complicated. The logic is now described better.


Former-commit-id: 19f9ece50ef254d06fac09ce542481c7bcd6f306

Former-commit-id: 71905d54a78bd0ffed29f9feb6104161d3bfb39f

More descriptive variable names are used in list comprehensions.
Also, the way the log level is set (introduced in 3d42f186) does
not work as expected and has been fixed.


Former-commit-id: fdc060a4a528cb7378b7281bc580b8e04d2a6cd6

Former-commit-id: 36e474332424b6f38b03b0ae404dfa13072cb136

Former-commit-id: 553d83a47a2721dc62451f8c5625098635e1a181

The 'eval()' function is actually not needed and poses a security
risk. The logging module understands string arguments to the log
level as well.


Former-commit-id: 7f58ad58a9ca4bdbe580f35bb4921f52fc6bf812

Rejected was quite strong. In case changes are really rejected, it
is sufficient to comment and close the MR. There is no need to label
those MR as rejected. In case the MR needs some more work from the
developer the label 'review-postponed' should be added.


Former-commit-id: 69277c8b8409186b03cbc33a12a235ed0a0ce6b6

All unit tests are labelled in ctest with the name of the package.
For very short package names (e.g. CI) this could lead to false-
positive matches (e.g. LUCID...). This is improved by requiring that
the package should match the beginning of the unit test label.


Former-commit-id: af32abe0c855c3dcf43daf4f4ad42c82532c92d4

Similar to the rest of the CI scripts, we can make use of the
python-gitlab module which is a neat wrapper around the Gitlab API.
Previously there was a bug when fetching the changes introduced by
a merge request. This is fixed in python-gitlab v0.17. Therefore,
the manual workaround using HTTP requests directly is not needed
any longer.


Former-commit-id: 31762bcf4f36217ff1d24e065f2f7ce682c28123

This ports the tested CI setup from the aogt8 git repository.


Former-commit-id: 1be771e881f9260a13a36002ae4a53a1d3e640ca