Skip to content
Snippets Groups Projects
  1. Apr 11, 2016
  2. Apr 01, 2016
  3. Mar 22, 2016
  4. Mar 21, 2016
  5. Mar 18, 2016
  6. Mar 16, 2016
  7. Mar 15, 2016
  8. Mar 14, 2016
  9. Mar 11, 2016
  10. Mar 10, 2016
    • Benedikt Hegner's avatar
      updated HEPTools/LCG version to 84 · 9ea0f970
      Benedikt Hegner authored
      Fixes GAUDI-1195
      
      See merge request !134
      9ea0f970
    • Benedikt Hegner's avatar
      Register Tools declared in ToolHandleArray in parent Algorithm/AlgTool · f84ad021
      Benedikt Hegner authored
      data deps of Tools in ToolHandleArrays are not pushed to parent Alg/AlgTool
      
      need to add a declareProperty(... ToolHandleArray<T> ...) to Algorithm and AlgTool, and add all ToolHandleArrays thus declared to a container that gets processed during initToolHandles. In order to avoid adding tools from Arrays that haven't been retrieved, we have to add a bool flag to the GaudiHandleArrayBase to detect if it's been retrieved. there's a bit of ugliness in extracting a ptr to an IAlgTool from the untemplated GaudiHandleArrayBase, as we have to explicitly retrieve the tool from the ToolSvc by name, but since it's already been retrieved when the Array gets retrieved, we won't be doing any new creations.
      
      I believe that the testing for whether the retrieved tool is public or private is redundant, as I don't think you can put a Public tool into a Private ToolHandleArray (at least you can't seem to do so in ATLAS), but I left it in just in case.
      
      
      See GAUDI-1190
      
      
      
      See merge request !124
      f84ad021
    • Benedikt Hegner's avatar
      use StringKey for Alg name, add IAlgorithm::setIndex · 02f25600
      Benedikt Hegner authored
      this patch does 3 things:
      
      - makes Algorithm::index() const (as it should have been), set the initial value to 0 instead of 123 (!)
      - adds a protected Algorithm::setIndex(unsigned int) method. this allows you to distinguish between clones. AlgResourcePool is the one who does the setting, and is declared as a friend to IAlgorithm
      - turns Algorithm::m_name into a StringKey (from a string), so we can hash on the name of Algorithms more easily (a useful ability when dealing with Alg clones, and trying to treat them all the same way)
      
      See merge request !125
      02f25600
Loading