Skip to content
Snippets Groups Projects
  1. Apr 27, 2018
  2. Apr 26, 2018
    • scott snyder's avatar
      AthenaPoolUtilities, RecAthenaPool: Allow skipping tests if required libraries aren't present. · 27811990
      scott snyder authored
      Synchonize with 21.2:
      
      Some *AthenaPool tests are failing in AthDerivation because they require
      libraries that aren't present in the build.  For example, RecAthenaPool
      is failing because JetEventAthenaPool isn't included.  In this case,
      we end up having to add a fair number of libraries to the build
      in order to get it to work --- probably more than we'd like to.
      
      So extend the cmake_parse_arguments macro to take a REQUIRED_LIBARARIES
      argument.  If any of the libraries listed here are not found
      on LD_LIBRARY_PATH, then the test is skipped.
      
      Use this in RecAthenaPool.
      
      
      Former-commit-id: 71ff378c73757fe155ff4dd765c5c36638d3ea68
      27811990
  3. Apr 19, 2018
  4. Apr 14, 2018
  5. Apr 11, 2018
  6. Apr 05, 2018
    • Olivier Arnaez's avatar
      Add new TrackParticleTruth persistent classes using HepMcParticleLink_p2 · 450b1833
      Olivier Arnaez authored
      Add new `TrackParticleTruthCollection_p2` and `TrackParticleTruthCollectionContainer_p2`
      classes which use `HepMcParticleLink_p2` and corresponding TP Converters.
      NB The peristent versions using `HepMcParticleLink_p1` are still written
      out by default.
      (cherry picked from commit aa3286c2a93ac47d342d30131581dc15970e1f27)
      
      Add unit tests the for `TrackParticleTruth` TP Converters
      (cherry picked from commit 4d3cc18027874d378522730b6e941ced8e8eba5a)
      
      Updated `TrackParticleTruthTPCnv` unit tests to use valid `HepMcParticleLinks`
      
      
      Former-commit-id: 902bc6e9
      450b1833
  7. Mar 28, 2018
  8. Mar 23, 2018
  9. Mar 22, 2018
    • Bertrand Martin's avatar
      Update of online monitoring for 2018 tau triggers · 6c06b13e
      Bertrand Martin authored
      This MR implements the online monitoring (ATR-17829, ATR-17806) for 2018 tau triggers running the RNN identification algorithm (which will supersede the BDT identification, hopefully).
      A minor modification was made to TauJetRNN.h in order to be able to retrieve a map that caches all calculated variables used as input to the RNN.
      The new variables to be monitored were added to TrigTauRecMerged.cxx, and the corresponding histograms are defined in TrigTauRecMonitoring.py.
      I set the 'urgent' label because this MR is needed for the startup release.
      Thanks!
      
      
      Former-commit-id: c30332d6e43c3684867e3f855388a9fa50323716
      6c06b13e
    • Hideyuki Oide's avatar
      VrtSecInclusive: fixed the bug found in test production in DATREP-106... · 30c1accd
      Hideyuki Oide authored
      VrtSecInclusive: fixed the bug found in test production in DATREP-106 (https://its.cern.ch/jira/browse/DATREP-106); protecting the code by chatching exceptions
      
      Former-commit-id: 8d2c4ca4a05b1398e48a75379c1c350560e23873
      30c1accd
    • Marcelo Vogel's avatar
      Transform support for Event Service (ATLASJT-379) · b23e275b
      Marcelo Vogel authored
      This branch provides support for activating the Event Service mode
      of AthenaMP for general transforms, specifically in reconstruction.
      It also updates the support to simulation transforms by refactoring
      the existing code.
      
      
      Former-commit-id: 8695d7f118345e1c2e6ea3c753df0991aea283db
      b23e275b
  10. Mar 21, 2018
    • Tamara Vazquez Schroeder's avatar
      Merge branch 'my-uprecoart' into '21.0' · b19ec3de
      Tamara Vazquez Schroeder authored and Atlas Nightlybuild's avatar Atlas Nightlybuild committed
      Correct input paths and add input files in RecJobTransformTests
      
      See merge request atlas/athena!9784
      
      (cherry picked from commit 45eb344b [formerly a7e4c922d187880eb7e3846a7a0e45c400bac270])
      
      cafbf6e3 correct input paths and add input files
      
      Former-commit-id: 2b1281f8a072f908b0e3db65ed4629d849aaccf7
      b19ec3de
  11. Mar 16, 2018
  12. Mar 15, 2018
  13. Mar 09, 2018
  14. Mar 07, 2018
    • Bertrand Martin's avatar
      Bugfix for 2017 tau triggers with BDT tau ID · 43bdf4af
      Bertrand Martin authored
      It was found (ATR-17789,ATR-17771) that during the implementation of 2018 tau triggers, the counts of 2017 tau triggers had significantly dropped.
      This was traced to the retrieval of mu in TauIDVarCalculator, which was moved from execute() to eventInitialize(), to be performed once per event.
      However, the piece of tau trigger code which takes care of the BDT evaluation did not call eventInitialize, which resulted in a null default value for mu.
      And the BDT cut is a function of tau pt and mu...
      TrigTauDiscriBuilder now calls eventInitialize and eventFinalize.
      In TauIDVarCalculator, the retrival of mu is done via EventInfo and not via TauEventData, in order to save the implementation of a TauEventData layer in TrigTauDiscriBuilder.
      Because this TauEventData would have been used only in TauIDVarCalculator for the mu retrieval, which is overkill and we then save a bit of memory...
      This MR also changes algorithm names (prefix), which were set to be identical for 2017 and 2018 chains, by mistake.
      Finally, 2 ROOT files used for RNN ID flattening were updated in TrigTauAlgorithmsHolder.py.
      Their transfer to cvmfs has been requested (ATLINFR-2299) but is not yet effective.
      The previous ROOT files were not closed properly. The content is identical.
      
      
      Former-commit-id: b174be85ccbea158980f24e02ff7efb67e87c2e2
      43bdf4af
  15. Mar 03, 2018
  16. Mar 01, 2018
  17. Feb 28, 2018
  18. Feb 27, 2018
Loading