Vakhtang Tsulaia authored 6 years ago and Atlas Nightlybuild committed 6 years ago

sending unimportant INFO msg to DEBUG as issued in every event

See merge request atlas/athena!11222

(cherry picked from commit 677bfa8d [formerly 87bb434ef74cc536d8bf51ed758b309dff13560b])

45a0be18 sending rather unimportant INFO msg to DEBUG as issued in every event
2bc0aa9d sending unimportant INFO msg to DEBUG

Former-commit-id: 73f82e4221cc2063c935cab224736ff24c29ff8b

sending unimportant INFO msg to DEBUG as issued in every event

See merge request atlas/athena!11222

(cherry picked from commit 677bfa8d [formerly 87bb434ef74cc536d8bf51ed758b309dff13560b])

45a0be18 sending rather unimportant INFO msg to DEBUG as issued in every event
2bc0aa9d sending unimportant INFO msg to DEBUG

Former-commit-id: e62d5c1f309e238c8c91a5b5c61905440fe80557

  
Disable LAr alignment to avoid spurious warnings.

Former-commit-id: c55f849e169b5ae0f37075d8fc4118baab19c2e8

The ~"21.0" branch does not support RUN3 configurations, so these packages will
never be used in production. Just tidying up the build warnings anyway.


Former-commit-id: 7c3f41f0754b6e6681e68c13cafdb0e531111703

Private data members should start with m_; other identifiers should not.


Former-commit-id: cb2b2a2f47e7b1bc835e3ddb420f32d4eeb1f2c5

Mark Hodgkinson authored 6 years ago and Atlas Nightlybuild committed 6 years ago

fixing get_files script to retrieve locally installed files

See merge request atlas/athena!10792

(cherry picked from commit 141422c4 [formerly 1765e50609b8d1a1f61a12fcfa6fcb9aa10eab4b])

21544891 fixing get_files script to retrieve locally installed files
24b01702 changing /bin/sh to /bin/bash on advice of shifter

Former-commit-id: 7e3f8034b5c1ee084ea842cb5d996abb8579f3f2

Mark Hodgkinson authored 6 years ago and Atlas Nightlybuild committed 6 years ago

fixing get_files script to retrieve locally installed files

See merge request atlas/athena!10792

(cherry picked from commit 141422c4 [formerly 1765e50609b8d1a1f61a12fcfa6fcb9aa10eab4b])

21544891 fixing get_files script to retrieve locally installed files
24b01702 changing /bin/sh to /bin/bash on advice of shifter

Former-commit-id: 3bf4def825f1ddd93442e72f47894ab199adfc1b

Former-commit-id: 7f930e5c64ce2c249b30551f2712c517d60807f2

Emil Obreshkov authored 6 years ago and Oana Vickey Boeriu committed 6 years ago

RPMs copy to eos script updated to create repodata on the local machine and then copy it to eos.

See merge request atlas/athena!10686

(cherry picked from commit 58c8f633 [formerly e80a4038])

bae0e820  RPMs copy to eos script updated to create repodata on the local machine and then copy it to eos.

Former-commit-id: 131853f6110bba875f54931bb515feefb99587af

Adam Edward Barton authored 6 years ago and Atlas Nightlybuild committed 6 years ago

Two TileCal dead modules are fixed so the fraction of dead modules are updates

See merge request atlas/athena!10402

(cherry picked from commit 80220075 [formerly 5582a9d91d4b3bff80427827dc8010df375a125b])

4ec9a57e Two TileCal dead modules are fixed so the fraction of dead modules are updates

Former-commit-id: c0bb4aca7797db54747a93d243d3f3eadacb4f96

Former-commit-id: 96a56a1dfae907a6d7b043bdecf97b6821d3f1a8

Vakhtang Tsulaia authored 6 years ago and Stewart Martin-Haugh committed 6 years ago

More gitignore

See merge request atlas/athena!10019

(cherry picked from commit 8276f3c2 [formerly d39d58ac])

a861566a Remove some emacs temporary files
8a9b6580 Add some binary formats to .gitignore
56a575c7 Remove some KDevelop configurations
c6bd22bb Remove binary and KDE fragments
d2668f85 Add root and tmp.* binary files

Former-commit-id: f77f83827739a86e5fc96980241f71405119c9c8

Emil Obreshkov authored 6 years ago and Atlas Nightlybuild committed 6 years ago

RPM to EOS copy: 5 retries for mkdir and cp before counting failure as an error

See merge request atlas/athena!10083

(cherry picked from commit e74ddf61 [formerly 492b0b9a15e082eaa45254b2a326b1f92c2e3133])

c1147375 RPM to EOS copy: 5 retries for mkdir and cp before counting failure as an error
356c6297 RPM to EOS copy: 6 retries (>10m tot) for mkdir and cp before counting failure as an error

Former-commit-id: 85302a414ffc07d1267541d7827a86723987f347

Emil Obreshkov authored 6 years ago and Atlas Nightlybuild committed 6 years ago

RPM to EOS copy: 5 retries for mkdir and cp before counting failure as an error

See merge request atlas/athena!10083

(cherry picked from commit e74ddf61 [formerly 492b0b9a15e082eaa45254b2a326b1f92c2e3133])

c1147375 RPM to EOS copy: 5 retries for mkdir and cp before counting failure as an error
356c6297 RPM to EOS copy: 6 retries (>10m tot) for mkdir and cp before counting failure as an error

Former-commit-id: 2aaf9fc2813ee03f72ed9c5b2bb3ee186bb4379c

Fix an error in branch 21.0: modify "’" into "'" in the following line:
fileList="['${ArtInFile//,/', '}’]"
Add the following lines:


Former-commit-id: cc633060e106d52963ea719541020945a00b6d81

Certain muon tracks were getting duplicate AEOTs because
of the fact that the hole recovery procedure was calling
the makeAEOTs method multiple times. This commit adds a
check to skip AEOTs already present on track when adding
AEOTs in the makeAEOTs method.


Former-commit-id: 1ba8598f200f2d1ca3acae5566f1ae80647efccd

Former-commit-id: d07168d90e35a7b0595569c7adb463117bf2bc1c

Restore constness of methods in favor of making private members
mutable. Use of smart pointers rather than old-style C++.


Former-commit-id: b5ba8de8171e8e79da45b0b314aa5e71f1c51c22

Former-commit-id: 99fb921ed51819428e685a6cfbc7e04cafb7f666

This commit updates the Muon SDO TP Cnv unit tests in the
`MuonEventTPCnv` package to use valid `HepMcParticleLinks`.


Former-commit-id: dd83c6538dbc2ac7ae1edf5f2daa029288a6880c

There are a few events timing out for TrigMuSuperEF_MGonly.
Looking at them with Persint showed that there is high activity
in RPC chambers. Profiling the jobs indicated that the fit is
done very (probably too) often. During this procedure the
RpcReadoutElement is used a lot which for its part hammers on
the IdHelper to get again and again the same answer rather than
caching it. This merge request implements the caching (to reduce
the fits will be done later). The time saved is ~30% for this
particular events, but is likely not visible for others. The
frozen Tier0 tests passed without problems. Please, PROC, take
special care that the request does not violate any frozen Tier0
tests. It must not change the output by any means and if it does
there is a bug.


Former-commit-id: d12c8ffbee52c7b2c541ab07894ac1e3ba68bd32

ART test scripts of MuonRecRTT and MooPerformace have been merged
into master branch and running for a time. Now we merge them into
21.0 so that they can run on that branch.


Former-commit-id: 54b70d1367afbaf4c8bea5df164d79970d28ed03

Former-commit-id: dd2e9304af72baf4e0e78ff5351996fef4103efd

For a number of years the barcodes of truth particles created during simulation
have started at 200001. Most downstream truth manipulation code assumes this
value and uses it to separate truth particles created in the simulation step
from those created in the generation step. There are some cases such as heavy
ion collisions where it is possible that the generator could create more than
200k particles though causing a problem. So in general it would be preferable
to set this offset to a higher value. Sometime ago changes were made to make
value configurable in the `MCTruthClassifier`, but this option was not
implemented in the configuration for most instances of the tool. This merge
request implements this configuration for the instances used by the Inner
Detector and Muon reconstruction code and some derivations. The derivations
should be fixed properly in the `21.2` branch though. A fix to the Jet
reconstruction code configuration will be added as a separate merge request.

After the changes in this merge request reconstruction shows identical output
in the cases that the offset is set to 200k or 1M (other than the truth barcodes
of course). Should fix ATLASRECTS-2962 and allow for another iteration of
ATLPHYSVAL-553.


Former-commit-id: 825a0071d627a40e5f756294d02761ff7432e86b

Former-commit-id: ca3896fa7317be108a7c2c50ccf3e15a7aff2540

Vakhtang Tsulaia authored 7 years ago and Atlas Nightlybuild committed 7 years ago

FPE fix in MSVertexTrackletTools

See merge request atlas/athena!8329

(cherry picked from commit d88e15da [formerly 5c2b1464eeac4413e0b93db3ebc680cfcce83d11])

ab332766 FPE fix to MSVertexTrackletTool.cxx
924e45bc Fix FPE in MSVertexTrackletTool.cxx
f64d95ed Merge remote branch 'origin/master'
664d1c3d Added absolute value when checking if yPi is 0

Former-commit-id: be3475821fa07e6e0f27e5ebdf891778be203675

Adam Edward Barton authored 7 years ago and Zhidong Zhang committed 7 years ago

Migrating nightly test of MuonGeomRTT from RTT to ART

See merge request atlas/athena!8258

(cherry picked from commit f95b71bc [formerly f6dc4b0dde15e91120caff5f5f4acc7fa67a1138])

70c8010c Migrating nightly test of MuonGeomRTT from RTT to ART

Former-commit-id: 6dc58beb6d488af231c5d5ae2f7720d12f1bb423

This fix ensures that barcode shifts for the MuonTruthDecorationAlg, MuonTruthAssociationAlg, and MuonSegmentTruthAssociationAlg are correctly set in the configuration.
This resolves some of the muon issues reported in the validation of the MC18 truth strategy (see ATLPHYSVAL-553 for more details), owing to that strategy using different barcode shifts.
It also helps to address longstanding problems with muon truth matching not being barcode-independent (see ATLASRECTS-2962 for more details).
Tier0 test results are available at /afs/cern.ch/work/w/wleight/public/MuonSW/ATLASRECTS-2962/: no differences are observed, as expected.
The Tier0 test does claim a new memory leak in q431 AODtoTAG, but as there was a problem with the script during this part of it, and these changes don't affect AODtoTAG, I'm inclined not to believe in it.


Former-commit-id: 1d714251bd18cfbf0c39a9fbee9dfe40417e32be

Merge branch 'master-ATLASRECTS-4156' into 'master'

See merge request !6410

(cherry picked from commit 1dffc760 [formerly 035505f9f8f95677836427c3db29b395275bc42f])

2dcf6ba9 Merge branch 'master-ATLASRECTS-4156' into 'master'

Former-commit-id: 277bac1a4a57d35b640d1307ca23ffdf3134310a

James Beacham authored 7 years ago and Tamara Vazquez Schroeder committed 7 years ago

resize one MDT DQ histo

See merge request !6629

(cherry picked from commit a26f5081 [formerly 80fd8df80ee804516b0764f1b3a6006e143e44f5])

be4132dd resize one MDT DQ histo

Former-commit-id: 082ed5eb35d12e0646607771ce130593a85cac20

Bugfix for ADC values from BMGs.

See merge request !6306


Former-commit-id: 8063d85deaccd4b84057f203374ccfb1646d71d4

James Beacham authored 7 years ago and Tamara Vazquez Schroeder committed 7 years ago

Fix for ATLASRECTS-3964

See merge request !6732

(cherry picked from commit e752ce03 [formerly 49a2623b57bc1d6323816f0e9fe8e5607fdd27ff])

36ed0ee3 Fix for ATLASRECTS-3964

Former-commit-id: d0bc12aa391ce34c352764d2f9a6b85557b8a134

This downgrades an unnecessary warning message in the MuonChamberHoleRecoveryTool.


Former-commit-id: 36ed0ee3f98de314ffc84a005d427bdf6badfaf5

Vakhtang Tsulaia authored 7 years ago and Zhidong Zhang committed 7 years ago

Migration MuonRecRTT from RTT to ART ATLASRECTS-4132

See merge request !4196

Former-commit-id: 9bfbb721e981efd8dfd32136fa3e5136e11302ce

Former-commit-id: be4132dd9c8512932640be77763ef09ad700f093

Tim Martin authored 7 years ago and Tamara Vazquez Schroeder committed 7 years ago

Former-commit-id: 69a367d785d9e8a4fa97b053a7ab124ed5d66f6f

Adam Edward Barton authored 7 years ago and Vakhtang Tsulaia committed 7 years ago

Fixed dump-athfile.py crash when running over RAW files (ATLASRECTS-4156)

See merge request !4482

Former-commit-id: 2dcf6ba9c6761d9df498591adaa49478256c74cd

Declare interface fixes 21.3

See merge request !4814


Former-commit-id: 53299a6cc812697ab08f8b8d02b7f8c6c42b3a5a

Further fixes for ATLASRECTS-3796

See merge request !6159

Former-commit-id: f86dec45954face70c8862608b9a63288b9f31af

Former-commit-id: 0d1b753f9bea5a8a375aa45a8835fee728715e62