Skip to content
Snippets Groups Projects
  1. Mar 29, 2018
  2. Nov 10, 2017
  3. Jun 23, 2017
  4. Jun 07, 2017
  5. May 19, 2017
    • Goetz Gaycken's avatar
      Correct logic concerning the track parameters to be converted. · 6cea4d08
      Goetz Gaycken authored
      Originally the first and last track parameter set was added to xAOD
      TrackParticles if the property KeepParameters was true, and all track
      parameter sets were written only, when KeepParameters was not set true
      but the property KeepAllPerigee was true. After the inclusion of the
      bad cluster identification, all parameters are stored if the
      BadClusterID property is false and KeepAllPerigee is true, independent
      of KeepParameters.
      
      Now the original behaviour is restored that either the first and the
      last or all track parameters are stored depending on the properties
      KeepParameters and KeepAllPerigee.
      
      
      Former-commit-id: 6bfe1887411f5892e8124dd65fdb54506773cb53
      6cea4d08
  6. Apr 18, 2017
  7. Apr 12, 2017
    • Attila Krasznahorkay's avatar
      Fixed the linking problems of TrkParticleCreator by linking its main · c05b1352
      Attila Krasznahorkay authored
      library explicitly against PixelGeoModelLib.
      
      Unfortunately some trigger packages do include the header file of the
      package, even though it should not be usable for anything. (Its symbols
      are not available outside of the package.) Still, to keep those packages
      working, I introduced an interface library for the one header for now.
      
      That should just be removed from the configuration once the clients of
      the package are removed.
      
      
      Former-commit-id: af1cb77404c05dc8ac090e2761dfccbf775120f8
      c05b1352
  8. Mar 09, 2017
    • Goetz Gaycken's avatar
      Always use ROTs for electron fits. · 534f93d8
      Goetz Gaycken authored
      This is a workaround for a short coming in the GlobalChi2Fitter, which
      currently does not properly treat brem fits when starting from
      PrepRawData. This addresses ATLASRECTS-3949. (TrkAmbiguityProcessor-01-00-14-04)
      
      
      Former-commit-id: fb4c9ce2303b6ffe70a1aeb3cee825f73c877964
      534f93d8
  9. Feb 14, 2017
    • Goetz Gaycken's avatar
      Ported coverity and compiler fixes from the trunk. · 025c94ae
      Goetz Gaycken authored
      Ported fixes from th trunk:
      - Fixed initialisation ordering,
      - overrides are marked,
      - for coverity issues 108647,108648,111140
      - Const fix.
      - Fix duplicate property declaration.
      - 'endreq' -> 'endmsg.' (TrkAmbiguityProcessor-01-00-14-03)
      
        * Fix coverity defects:
      108647 26/04/2016 (Medium) Uninitialized scalar field :/Tracking/TrkTools/TrkAmbiguityProcessor/src/DenseEnvironmentsAmbiguityProcessorTool.cxx in function "DenseEnvironmentsAmbiguityProcessorTool"
      111140 15/06/2016 (High) Use after free :/Tracking/TrkTools/TrkAmbiguityProcessor/src/DenseEnvironmentsAmbiguityProcessorTool.cxx in function "addTrack"
      108648 26/04/2016 (Medium) Uninitialized scalar field :/Tracking/TrkTools/TrkAmbiguityProcessor/src/SimpleAmbiguityProcessorTool.cxx in function "SimpleAmbiguityProcessorTool"
        * tag as TrkAmbiguityProcessor-02-00-05
      
      2016-09-20  scott snyder  <snyder@bnl.gov>
      
              * Tagging TrkAmbiguityProcessor-02-00-04.
      	* Const fix.
      	* Fix duplicate property declaration.
      	* endreq -> endmsg.
      
      2016-05-03 Roland Jansky
          * Adding in functionality to save distance between collimated tracks and refit them.
      	* Tagging TrkAmbiguityProcessor-01-00-11
      
      
      Former-commit-id: 974f2dbfca71ba7c09077c1d546d97dffdddfd0e
      025c94ae
    • Goetz Gaycken's avatar
      Fix memory leak (coverity issue 112296). · 4884f2a1
      Goetz Gaycken authored
      The energy loss object was also cloned when only setting persistification
      hints, but the object was never deleted in this case. (TrkTrackSlimmingTool-00-06-01)
      
      	* fix memory leak introduced by TP converter level slimming mode
      	(coverity issue 112295).
      
      2017-01-26 Alex Alonso
      	* Migrate TrkTrackSlimmingTool-00-05-03 to trunk
      	* tag as TrkTrackSlimmingTool-00-06-00
      
      
      Former-commit-id: ba9d493b
      4884f2a1
  10. Feb 01, 2017
  11. Sep 01, 2016
    • Peter Kluit's avatar
      fix memory leak surface ATLASRECTS-3102 (TrkMaterialProvider-00-00-47) · 64c42f2d
      Peter Kluit authored
              * another try to fix memory leak in TrkMaterialProvider ATLASRECTS-3102
              * leaking surface const Trk::Surface& surf = *(meot->associatedSurface().clone())
              * TrkMaterialProvider-00-00-47
      
      2016-08-29 Peter Kluit
              * another fix memory leak in TrkMaterialProvider ATLASRECTS-3102
              * TrkMaterialProvider-00-00-46
      
      2016-08-22 Peter Kluit
              * fix memory leak in TrkMaterialProvider ATLASRECTS-3102
              * TrkMaterialProvider-00-00-45
      
      
      Former-commit-id: ca76137a
      64c42f2d
  12. Aug 19, 2016
    • Peter Kluit's avatar
      ' bug fix residuals aeots' (TrkResidualPullCalculator-01-01-04) · 041a4096
      Peter Kluit authored
          * fixed bug needs TrkiPatFitterUtils-00-12-13 or later
          * TrkResidualPullCalculator-01-01-04
      
      2016-06-30 Peter Kluit
          * updated the residual pull calculations for AEOTs
          * using the signed distance and projections as in the fit (TrkiPatUtilities)
          * TrkResidualPullCalculator-01-01-03
      
      2016-06-29 Edward.Moyse@cern.ch
          * Just tagging Peter's changes below
          * TrkResidualPullCalculator-01-01-02
      
      2016-06-22 Peter Kluit
            * changed interface for alignment effects on track to use const aeots
            * ResidualPullCalculator.cxx and ResidualPullCalculator.h
            * no tag
      
      2016-06-21 Edward.Moyse@cern.ch
          * ResidualPullCalculator.cxx: fixed bug
          * tag as TrkResidualPullCalculator-01-01-01
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: 80b1375b
      041a4096
    • Edward Moyse's avatar
      'IResidualPullCalculator.h: changed interface for alignment effects on track... · 2f855321
      Edward Moyse authored
      'IResidualPullCalculator.h: changed interface for alignment effects on track to use const aeots.' (TrkToolInterfaces-01-03-12)
      
          * Tagging as TrkToolInterfaces-01-03-12
      
      2016-05-22 Peter Kluit
          * IResidualPullCalculator.h: changed interface for alignment effects on track to use const aeots
          * no tag yet
      
      
      Former-commit-id: fab7e0e9
      2f855321
  13. Jul 02, 2016
  14. Jun 14, 2016
  15. May 27, 2016
    • Jochen Meyer's avatar
      tagging with CMakeLists.txt (TrkMaterialProvider-00-00-44) · 74374065
      Jochen Meyer authored
      	* tag with automatically generated CMakeLists.txt
      	* Tagging TrkMaterialProvider-00-00-44
      
      2016-04-02  Vakho Tsulaia  <tsulaia@cern.ch>
      	* Dropping obsolete dependency on EventInfo
      	* Tagging TrkMaterialProvider-00-00-43
      
      2016-03-29 Peter Kluit
              * fix for crash in updateVectorMS ATLASRECTS-2428
      	* changed the order: first apply MS Eloss and X0 scale factors and after that add the CaloTSOS
      	* tag TrkMaterialProvider-00-00-42
      
      2016-01-13 Peter Kluit
              * Jira ATLASRECTS-2026
              * correct the TSOS for an X0 scale (1) and Eloss scale (0.93) in the MuonSpectrometer
              * uses method updateVectorMS with the scales as	arguments
      	* scale factors come from the EnergyLossUpdator and were determined on MC
              * tag TrkMaterialProvider-00-00-41
      
      2016-01-11 Peter Kluit
      ...
      (Long ChangeLog diff - truncated)
      74374065
    • Atlas-Software Librarian's avatar
      'CMakeLists.txt' (TrkCompetingRIOsOnTrackTool-01-00-01) · 2ad5ec9c
      Atlas-Software Librarian authored
      	* cmt/requirements
      		Specify the required ROOT components for cmake (transparent to CMT)
      	* Tagged as TrkCompetingRIOsOnTrackTool-01-00-01
      2ad5ec9c
    • Atlas-Software Librarian's avatar
      'CMakeLists.txt' (TrkParticleCreator-01-01-31) · 609fc6a4
      Atlas-Software Librarian authored
      	* address coverity
      31565 14/10/2015 (Medium) Inferred misuse of enum :/Tracking/TrkTools/TrkParticleCreator/src/TrackParticleCreatorTool.cxx in function "setTrackSummary"
      	* by adding coverity code annotation, declaring it as intentional. Checked at compile time with static_assert
      	* tag as TrkParticleCreator-01-01-31
      609fc6a4
  16. Jan 19, 2016
  17. Nov 13, 2015
    • Atlas-Software Librarian's avatar
      'CMakeLists.txt' (TrkAmbiguityProcessor-01-00-09) · 07865e7c
      Atlas-Software Librarian authored
      	* Coverity fix:
      31259 19/08/2015 (Medium) Dereference before null check :/Tracking/TrkTools/TrkAmbiguityProcessor/src/DenseEnvironmentsAmbiguityProcessorTool.cxx in function "updatePixelSplitInformationForCluster"
      	* Tagged as TrkAmbiguityProcessor-01-00-09
      
      2015-08-13 Nick Styles
      	* Merge changes from -07-branch
      	* Tagged as TrkAmbiguityProcessor-01-00-08
      
      2015-07-27 Shaun Roe
      	* Coverity fixes:
      14358 09/07/2014 (Medium) Not restoring ostream format :/Tracking/TrkTools/TrkAmbiguityProcessor/src/SimpleAmbiguityProcessorTool.cxx in function "statistics"
      20175 21/10/2014 (Medium) Not restoring ostream format :/Tracking/TrkTools/TrkAmbiguityProcessor/src/DenseEnvironmentsAmbiguityProcessorTool.cxx in function "statistics"
      20056 21/10/2014 (Medium) Dereference after null check :/Tracking/TrkTools/TrkAmbiguityProcessor/src/DenseEnvironmentsAmbiguityProcessorTool.cxx in function "updatePixelSplitInformation"
      28940 17/01/2015 (Medium) Dereference before null check :/Tracking/TrkTools/TrkAmbiguityProcessor/src/DenseEnvironmentsAmbiguityProcessorTool.cxx in function "updatePixelSplitInformation"
      
      2015-06-27 Miriam Diamond
      	* Add DBM to printouts
      	* tagged as TrkAmbiguityProcessor-01-00-07-04
      
      2015-05-19 Nick Styles
      ...
      (Long ChangeLog diff - truncated)
      07865e7c
    • Atlas-Software Librarian's avatar
      'CMakeLists.txt' (TrkToolInterfaces-01-03-10) · 6c02eb8d
      Atlas-Software Librarian authored
      	* Add new interface to TRT_PID. Requested by fast digi.
      	* Tagged as TrkToolInterfaces-01-03-10
      6c02eb8d
    • Goetz Gaycken's avatar
      Renamed TRTLocalOccupancy to TRTTrackOccupancy. (TrkParticleCreator-01-01-30) · fb2a41d0
      Goetz Gaycken authored
      	* renamed TRTLocalOccupancy to TRTTrackOccupancy.
      
      2015-10-07 Goetz Gaycken
      	* Fixed compiler warning when compiling without -DNDEBUG.
      fb2a41d0
  18. Oct 10, 2015
  19. Sep 15, 2015
    • Peter Kluit's avatar
      'Fix crash in cosmics' (TrkMaterialProvider-00-00-38) · 4317e9e7
      Peter Kluit authored
             * Fixes for crash in cosmics
             * q/p = 0 or 100000. and no perigee
             * tag TrkMaterialProvider-00-00-38
      
      2015-09-02 Peter Kluit
             * JIRA ATLASRECTS-1970 and 1971 and ATR-10679
             * solve and suppress the warnings of types "Unable to retrieve
             Calorimeter TSOS from extrapolateM caloTSOS->size() etc"
             * tag TrkMaterialProvider-00-00-37
      4317e9e7
  20. Aug 05, 2015
  21. May 17, 2015
Loading