James Beacham authored 6 years ago and Atlas Nightlybuild committed 6 years ago

LArMonTools modified to be able to set the output file name from JO

See merge request atlas/athena!16010

(cherry picked from commit 40178cfc [formerly 72230d76aa83d198c7c50c2906c33b0dd58770f6])

50ef29f1 LArMonTools modified to be able to set the output file name from JO

Former-commit-id: fa7fe8b8781d8c8870b4096c4c958da74a420b1c

Former-commit-id: 50be6f4898bccde5a5e5cb143becd040cf0ee58e

ATLLARONL-318: Added a summary plot for LAr Noise Correlation

See merge request atlas/athena!15668
Conflicts:

	LArCalorimeter/LArMonTools/src/LArNoiseCorrelationMon.cxx


Former-commit-id: fa386cf027155e3947c34c2e0ce50aecc52d6377

Former-commit-id: f3129d1687db217d34cc9d62d1aa475d39a098ee

Former-commit-id: fba8cb2856d955a82cf46d6f549b899c6fbe488f

Former-commit-id: 71bb8ab085f9ece8de2f3e5472aaa7ace83cc614

Former-commit-id: 4ec6b669e4b99846807d0cbea070828f1936b396

Former-commit-id: 583d1d2d5e4dae7f0db002bd0171d20f74dbdc0c

Former-commit-id: d8ab6b313d2c25bb8c144880e4e30d9ec551cd2a

Former-commit-id: 1ce5e30361742387dc98aa8ff2fb200f6a383ab4

Former-commit-id: 55b812872e6c86dddbf44c55b3482dfcbd050330

Vakhtang Tsulaia authored 6 years ago and Atlas Nightlybuild committed 6 years ago

Use direct G4Tubs query method

See merge request atlas/athena!14359

(cherry picked from commit f79491e4 [formerly 8f1b7dea])

b40dc36d Use direct G4Tubs query method

Former-commit-id: 0475a288cdd7d3c27b082bee78639f6d46b88727

Former-commit-id: f688de963798de7fac22fca6c269204d4a4a9d01

Former-commit-id: f2628e34910f911ec3f487599b5a80a2f4fe34f3

Some methods had non-standard indentation, which has been fixed.
Added a base-configuration method, with common configuration, which
will be more useful when further common configuration is added in
an up-coming merge-request.


Former-commit-id: 601e5b70f9e2b311a702a19d903a62f3a0c04c0f

Former-commit-id: a7ad8a0d4e0f4085a7e033d11f37d4f9ac6020be

Frank Winklmeier authored 6 years ago and John Derek Chapman committed 6 years ago

LArG4Code: Fix dictionary generation warning

See merge request atlas/athena!13745

(cherry picked from commit fcbb5fb9 [formerly ba7beb7c6611ae5c7f449f8a58cda1b9c798e83b])

828a527d Remove "variable" dictionary rule as there are no variables (only enums) in LArG4

Former-commit-id: 59ac9a2925ad9f8d4a9c98e7c93b879ac002b968

Denis Oliveira Damazio authored 6 years ago and Edward Moyse committed 6 years ago

Change conditions in order to include LArMinBiasAverage so that CaloLumiBCIDTool can also be used for superCells


Former-commit-id: 8aadb2b22bd400b3b7421d8af0089746fc9fb9e1

Former-commit-id: c027dc3fb1686fdaf745f94412d3cfd49bffa14a

cold back walls of the endcap cryostat - 5.7 tons of Al per side introduced
in LAr-Revised-18.


Former-commit-id: 3fd4be5c7b03fc19c505b373a720b449860c2a35

Standardised indentation. Use ATH(UN)LIKELY macros to optimize
branch prediction.


Former-commit-id: 4f0af37f8345a4bce3ae49f6f9da389e5bf3e1fd

Add a new `CreateFakeStep` method to the `SimulationEnergies`
class based on the version in `(Tile)EscapedEnergyProcessing`,
but incorporating some of the functionality from the
`SimulationEnergies::ProcessEscapedEnergy` method. This is then called
from `SimulationEnergies::ProcessEscapedEnergy` prior to the
calls to `(Tile)EscapedEnergyProcessing::Process`. Remove
obsolete `CreateFakeStep` methods from
`(Tile)EscapedEnergyProcessing` classes.

Drop old `Process` method and rename `ProcessNew` to `Process` in
`(Tile)EscapedEnergyProcessing`. Switch `ProcessEscapedEnergy`
to provide a `G4Step` as input to the `Process` calls.

Part of the tidying for ATLASSIM-3718.


Former-commit-id: e2efc345963b0b26b20dcaa5e544934266bb7981

The new tempoary `ProcessNew` method takes over most of the functionality
of the `Process` method without requiring clients to adapt their interface.
The `Process` method now creates a fake `G4Step` and uses that as
the input to `ProcessNew`. Part of the tidying for ATLASSIM-3718.


Former-commit-id: d463e219a0a311ff3adbb64cb4db9acb384d3568

Updating `EscapedEnergyProcessing` (LAr) and `TileEscapedEnergyProcessing`
classes to create fake `G4Step` instances in a separate method.
For thread-safety reasons these instances are created each time the
method is called rather than simply updating a version pointed at by
a static pointer. To prevent memory leaks the fake `G4Step` instances
are pointed at by a `std::unique_ptr`. This is part of the tidying
for ATLASSIM-3718.


Former-commit-id: cca461cd32f6dd3a3b72ae942256600d6c1da409

Former-commit-id: 35f860d93709824733131649e1b727019b1b735e

Former-commit-id: f100dc963bc3465ca5942e535ceb9dc7cf738ab9

Former-commit-id: c7b36e999c9e536487df2984c48104aa915fc1fd

coherent noise algorithm adjusted to fill in correlation plot properly. Correlation computation moved to procHist


Former-commit-id: 03f54886b5fc37791778074a046678812c4f5eaf

Former-commit-id: ffe62ec2b4b6aa41325a21e7e7517790bdab8e5b

Former-commit-id: 9fc1a872632b2eb451dbb8df4e65a33dac61179e

Former-commit-id: e0c15196afe3a2e615dc9b75e5088c5c60697387

Former-commit-id: 74a0ba14d6672ed37122d5d6afdc854449cfdc48

Former-commit-id: 0ba4bddafc1273cfc841f94df4be15f143bdb5e2

Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: ffc9ec29d05010b853bca289ddb799d2e448ed46

Whether we are running a test-beam job or not should be known at
configuration time, so it is much more efficient to set a configurable
property at this point rather than checking whether we are using
a test beam geometry *every single step* in the pre-sampler. Part of
the changes for ATLASSIM-2643. (Does not change the output in my local tests.)


Former-commit-id: 94d71c38165cec8d43a49c10adf7610d5cb04c8a

Making a variables const where possible and tidying some syntax.


Former-commit-id: ad6fa0646125011fba809da00dc46837544d988f

As mentioned in	ATLASSIM-2643, lines using char* literals cause	short-lived
heap-allocations, harming simulation performance. This merge request aims
to mitigate this by making the strings in question static const.


Former-commit-id: 9680dee1dc3df5ad5ad7958a1fda116ddf76d85f

As mentioned in ATLASSIM-2643, lines using char* literals cause short-lived
heap-allocations, harming simulation performance. This merge request aims
to mitigate this by making the strings in question static const.


Former-commit-id: 9f80174247e061081f80592aac85f5429fa5de79

Initialize all member variables in the constructor.


Former-commit-id: 28472fb56aa828e9836e1fa8ce156aac7cef9e0f

Remove logically dead-code in `LArEMECChargeCollection`.


Former-commit-id: f7ab082c842de3998c7e35d79735c620652d5095