Skip to content
Snippets Groups Projects
  1. Apr 26, 2018
  2. Apr 25, 2018
    • Tamara Vazquez Schroeder's avatar
      Merge branch 'mr-2018-02' into '21.0' · 91b41c16
      Tamara Vazquez Schroeder authored and Atlas Nightlybuild's avatar Atlas Nightlybuild committed
      clean-up of pixel athena monitoring histograms
      
      See merge request atlas/athena!10675
      
      (cherry picked from commit c8f2ed38 [formerly 61abfa5e5dba2370bae1012a631b6b873439d472])
      
      1c56efd2 unchecked pointer, uninitialized variable
      886785a7 Minor clear commentted vars
      68ce615f Minor clear commentted vars
      0c92b342 Merge branch 'tmp/bugFix1' into 'mr-2017-09'
      d8b0082f Disable copy constructor and '=' operator for 3 classes
      c91f26ec fix indentation of the destructor
      9a682a01 revert indentation
      434611de Merge branch 'tmp/bugFix3' into 'mr-2017-09'
      f37938b4 optimisation and clean-up of tracking loop
      89b2a865 Enforce bracketing/parenthesis rules
      56152d7d Merge branch 'feature/track-loop-opt' into 'mr-2017-09'
      92bb27f2 Initialize pointer for Coverity issue (118575), Use 'strncpy' function for issue (115518)
      88beaf32 remove unused histograms triggered by m_doESD flag; remove flag as well
      92d0e9e4 remove m_error_time, m_occupancy_time and m_cluster_occupancy_time online…
      2c2e7b0c Merge branch 'feature/monitor-anff1' into mr-2018-02
      d0cd7003 removing LorentzAngle histograms and corresponding selections: histograms not useful for monitoring
      7d52b76f removing m_avgocc_ratioIBLB0_per_lumi histogram, not useful - the ratio filled…
      21b91569 adjusting protection for efficiency
      b4cdb5b7 adding color to the plot
      002b32bd removing m_Xcluster and m_clusocc_sizenot1 histograms
      3be8238b compillation error and warnings after last commit fixed
      e69175a3 removing further unused code
      0c8a90b0 adjusting range of hit eff histos
      8a95190a Merge branch 'tmp/mr-2018-02' into mr-2018-02
      2d4380c5 removng unused histograms
      38666b07 change in the protection of ratio histograms
      1a8829cc put back Size>1 Cluster occupancy histograms - can be useful for tracking noisy…
      
      Former-commit-id: a980985709496db3c2821a519014aa3d5986a240
      91b41c16
  3. Apr 23, 2018
  4. Apr 07, 2018
    • James Beacham's avatar
      Merge branch 'tmp/mr-2018-01' into '21.0' · 1ce648fa
      James Beacham authored and Atlas Nightlybuild's avatar Atlas Nightlybuild committed
      updates mr-2018-01 to pixel athena monitoring code
      
      See merge request atlas/athena!10174
      
      (cherry picked from commit e4adeecd [formerly c8e49c3d7cd886609701441ee5dd10e28ddcd4c4])
      
      dc40c0a8 adding 100 LB occupancy and track efficiency histograms
      d05a320d making previous commit compiling and working by adding helper function to divide LW histos
      c3523049 bugfix in new 100lb histograms
      781bdefa procHistograms: adding more info in case of failure
      7b05135b adjustments to 100LB histograms anticipating their a-posteriori merging
      bc78136b fixing last 100 LB track efficiency histograms
      390b1026 adding labels to 100 LB histogram to ensure proper merging (by label) in case of publishing hiccups
      9c252561 fixes to 100 LB and the related filling code after debugging
      bf60bb86 bugfix in m_average_pixocc histogram (IBL FE map)
      66edcd06 Adding per PP0 histograms into Hits and Clusters On Track; suppoting code mainly…
      161cfa8f unchecked pointer, uninitialized variable
      b712bffe Minor clear commentted vars
      7b227e5c Minor clear commentted vars
      47cc6648 Disable copy constructor and '=' operator for 3 classes
      c08eab91 fix indentation of the destructor
      1bf14f3b revert indentation
      ff87ae86 optimisation and clean-up of tracking loop
      3b4357b3 Enforce bracketing/parenthesis rules
      7a98ee7a fixing access index
      3f90d646 Modify Cluster to fix Coverity issues 115555 etc
      9efa7324 removing IBL split for Occupancy_per_pixel histos, can't maintain proper…
      
      Former-commit-id: 52ad94549c16c878b2b45b930971ab4f3ca746c4
      1ce648fa
  5. Mar 29, 2018
  6. Mar 28, 2018
  7. Mar 26, 2018
  8. Mar 08, 2018
  9. Mar 02, 2018
    • John Chapman's avatar
      Drop declareInterface line from BCM_DigitizationTool · 9a02af07
      John Chapman authored
      Now that `PileUpToolBase` uses the `extends<...>` pattern, it is no longer
      neccessary to use the obsolete `declareInterface<IPileUpTool>` in the classes
      which inherit from `PileUpToolBase`. ATLASSIM-3439.
      
      
      Former-commit-id: 37d691bf99a659ffba09cac8ba037cda98dad5d5
      9a02af07
  10. Feb 27, 2018
    • John Chapman's avatar
      Fix for Coverity Defect 118357 · 27a47a52
      John Chapman authored
      Removing the declared constructor for `TRT_Hit_p2` should get rid of
      this defect as this is the main difference with  the `TRT_Hit_p1`
      implementation, where no defect is generated. ATLASSIM-3591
      
      
      Former-commit-id: 252a00a7d17b4318483c826a1e50284b899d6f8c
      27a47a52
    • John Chapman's avatar
      Fix for Coverity Defect 118355 · 037ffa41
      John Chapman authored
      Removing the declared constructor for `SiHit_p2`  should get rid of
      this defect as this is the main difference with  the `SiHit_p1`
      implementation, where no defect is generated. ATLASSIM-3591
      
      
      Former-commit-id: 1045fb120a226af44477ef5f35bef94dc6bec020
      037ffa41
  11. Feb 26, 2018
  12. Feb 23, 2018
  13. Feb 22, 2018
  14. Feb 20, 2018
  15. Feb 19, 2018
  16. Feb 16, 2018
  17. Feb 15, 2018
  18. Feb 12, 2018
    • Matthew Gignac's avatar
      add in xAODSiSPTrackCandidates key, so user can control the output name of the... · 618f7d21
      Matthew Gignac authored
      add in xAODSiSPTrackCandidates key, so user can control the output name of the track candidates; separate key for which track candidiates should be used for input(previously this pointed to the SiSPSeededTracks, and the user couldn't change this name without breaking a lot of other things..)
      
      
      Former-commit-id: b6c8e2b74d0da5a5af26973c72a594371dbc2c03
      618f7d21
  19. Feb 11, 2018
  20. Feb 10, 2018
  21. Feb 09, 2018
  22. Feb 07, 2018
    • John Chapman's avatar
      Set the barcode offset for MCTruthClassifier · 70b3ee14
      John Chapman authored
      For a number of years the barcodes of truth particles created during simulation
      have started at 200001. Most downstream truth manipulation code assumes this
      value and uses it to separate truth particles created in the simulation step
      from those created in the generation step. There are some cases such as heavy
      ion collisions where it is possible that the generator could create more than
      200k particles though causing a problem. So in general it would be preferable
      to set this offset to a higher value. Sometime ago changes were made to make
      value configurable in the `MCTruthClassifier`, but this option was not
      implemented in the configuration for most instances of the tool. This merge
      request implements this configuration for the instances used by the Inner
      Detector and Muon reconstruction code and some derivations. The derivations
      should be fixed properly in the `21.2` branch though. A fix to the Jet
      reconstruction code configuration will be added as a separate merge request.
      
      After the changes in this merge request reconstruction shows identical output
      in the cases that the offset is set to 200k or 1M (other than the truth barcodes
      of course). Should fix ATLASRECTS-2962 and allow for another iteration of
      ATLPHYSVAL-553.
      
      
      Former-commit-id: 825a0071d627a40e5f756294d02761ff7432e86b
      70b3ee14
  23. Feb 06, 2018
Loading