Skip to content
Snippets Groups Projects
  1. Sep 28, 2017
  2. Sep 22, 2017
    • John Chapman's avatar
      Move Compressor class from EventCommonTPCnv to AthenaPoolCnvSvc · 50009585
      John Chapman authored
      The `Compressor` class has no dependencies other than on the STL
      and is not used by any other class in `EventCommonTPCnv` moving
      it to `AthenaPoolCnvSvc` means that `CaloSimEventTPCnv` and
      `LArSimEventTPCnv` no longer depend on `EventCommonTPCnv`.
      In turn this means that `EventCommonTPCnv` no longer needs to be
      part of the AthSimulation release. See ATLASSIM-3441.
      
      
      Former-commit-id: e20bb7940afb3ce84074f560a8acb8fae0c3abc1
      50009585
  3. Sep 10, 2017
  4. Aug 21, 2017
  5. Aug 17, 2017
  6. Aug 16, 2017
  7. Aug 15, 2017
  8. Aug 08, 2017
  9. Jul 10, 2017
  10. Jul 06, 2017
    • John Chapman's avatar
      Update LAr SimpleSDTools to use standard OutputCollectionNames property · 99ca1da9
      John Chapman authored
      In ATLASSIM-3365 it was noted that the `LArHitContainer` names were
      not being set properly as the LAr `SimpleSDTools` were using their
      own `HitCollectionName` property rather than the standard
      `OutputCollectionNames` property from the base class.
      
      
      Former-commit-id: b846b2b29ab147707c71497840e68464fa23fc75
      99ca1da9
  11. Jun 20, 2017
  12. May 29, 2017
  13. May 23, 2017
  14. May 22, 2017
    • John Chapman's avatar
      Bugfix for LArG4MiniFCAL genConf issue · 1707ac15
      John Chapman authored
      Components in the LArG4MiniFCAL library were not properly registered
      with genConf due to a typo in the CMakeLists.txt file. This should fix
      ATLASSIM-3226.
      
      
      Former-commit-id: aef5ce872e59ca1458f4b33c8bad8a4c6d20fd93
      1707ac15
  15. May 19, 2017
  16. May 05, 2017
  17. May 02, 2017
    • John Chapman's avatar
      Drop obsolete V1 UserAction Implementations · 6ac6955c
      John Chapman authored
      In the cases where both V1 and V2 implmentations are present, the V1
      implementations can just be dropped. See ATLASSIM-3023
      
      
      Former-commit-id: 76c689072772ec83c3e9098156d81a2112a5a8ea
      6ac6955c
    • John Chapman's avatar
      Migrate LArG4H6SD UserActions to V2 Implemenation · f0cf0901
      John Chapman authored
      The V1 UserAction implementation is obsolete, so should be replaced
      by the V2 UserAction implementation wherever it appears. See ATLASSIM-3023.
      
      
      Former-commit-id: 668d76a64b737db4de09b3147d5b20cf47266945
      f0cf0901
  18. Apr 27, 2017
  19. Apr 24, 2017
    • Guillaume Unal's avatar
      LArCalorimeter/LArDigitization/python/LArDigitizationFlags.py : add new flag... · dc285187
      Guillaume Unal authored
      LArCalorimeter/LArDigitization/python/LArDigitizationFlags.py : add new flag to enable useage of High Gain in EMEC inner wheel digitization
          default value = True, i.e same behavior as before this change
          this flag should be set to False to emulate the detector configuration for 2017 data taking
      
      LArCalorimeter/LArDigitization/python/LArDigitizationConfig.py : set property for LArPileUpTool according to flag above => MG/HG switching value
       set to 0 if High gain is not enable in the digitization => cells can only be in Medium or Low gain
      
      LArCalorimeter/LArDigitization/LArDigitization/LArPileUpTool.h
      LArCalorimeter/LArDigitization/src/LArPileUpTool.cxx  : add specific gain switching values for EMEC IW region.  Default value are as in rest of EM calorimeter
      
      
      Former-commit-id: 05d512fc
      dc285187
  20. Apr 18, 2017
  21. Apr 12, 2017
    • Guillaume Unal's avatar
      Fix in LArDigitization for MC+MC overlay jobs · 4808da13
      Guillaume Unal authored
             * src/LArPileupTool.cxx LArDigitization/LArPileupTool.h : add isMcOverlay flag to distinguish MC+MC overlay (and not to the dedicated ramp intercept correction)
              * python/LArDigitizationConfig.py : configure the property above
      
      
      Former-commit-id: eb48d7d07336a3dd4dada8d8cd7d41726dbad9cf
      4808da13
  22. Feb 01, 2017
    • Guillaume Unal's avatar
      change Warning message to Info in LArCellHVCorr (LArCellRec-02-13-15) · 29f3527d
      Guillaume Unal authored
              * src/LArCellHVCorr.cxx  change Warning message to Info in case difference of HV correction <0.9
                 to avoid many warnings after fix for EMECPS HV mapping
              * tag LArCellRec-02-13-15
      
      23-01-2017 Pavol Strizenec Mpavol @ mail.cern.ch>
      	* merged with branch LArCellRec-02-12-94-branch used during 2016 datataking
      	* tag LArCellRec-02-13-14
      	* following changes were there:
      	------------------------------------------------------------
      	2016-10-11 Emma Kuwertz <emma.sian.kuwertz@cern.ch>
      		* Tagging LArCellRec-02-12-94-16
      
      	2016-10-07 Emma Kuwertz <emma.sian.kuwertz@cern.ch>
      		* Adding MNB FEB list to be configurable in job options
      
      	5-08-2016 Pavol Strizenec <pavol @ mail.cern.ch>
      		* fixing typo for IW front wheel FEB exclusion
      		* tag LArCellRec-02-12-94-15
      
      	3-08-2016 Pavol Strizenec <pavol @ mail.cern.ch>
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: 4177ba0111894ed858b01b9ae6ddd51ac70e3576
      29f3527d
    • John Derek Chapman's avatar
      python/LArG4FastSimulationConfig.py (getFCALFastShower, getFCAL2FastShower):... · 8814efcd
      John Derek Chapman authored
      python/LArG4FastSimulationConfig.py (getFCALFastShower, getFCAL2FastShower): increase EMinEneShowerLib from 0.51 MeV to 3 MeV. ATLASSIM-2188. Tagging: LArG4FastSimulation-05-00-08-01 (LArG4FastSimulation-05-00-08-01)
      
      	* Branch for 20.3.7.7 and 21.0.15
      	* python/LArG4FastSimulationConfig.py
      	(getFCALFastShower, getFCAL2FastShower): increase EMinEneShowerLib
      	from 0.51 MeV to 3 MeV. ATLASSIM-2188
      	* Tagging: LArG4FastSimulation-05-00-08-01
      
      2016-09-01 Steve Farrell <Steven.Farrell@cern.ch>
      	* Cleaned up long lines, whitespace, variable naming conventions.
      	* Changed loop-by-value to loop-by-reference over EnergySpot in
      	  LArFastShower to prevent unnecessary copies.
      	* Fixed thread-unsafe usage of static LArG4Identifiers in the fastsim
      	  SDs by converting them into class members.
      	* Tagging: LArG4FastSimulation-05-00-08
      
      2016-06-01  Zach Marshall <ZLMarshall@lbl.gov>
      
      	* Tagging: LArG4FastSimulation-05-00-07
      	* No shower libraries at very low energy.  Skipping the application for
      	such particles.
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: 05f32644db63019cdaf04f901181885ea250f68a
      8814efcd
    • Ksenia Gasnikova's avatar
      src/FCALDistEtaEnergyShowerLib.cxx fixing inconsistency for particle energy... · 562e2061
      Ksenia Gasnikova authored
      src/FCALDistEtaEnergyShowerLib.cxx fixing inconsistency for particle energy definition (LArG4ShowerLib-01-00-11)
      
      	* Tagging LArG4ShowerLib-01-00-10.
      	* Comply with ATLAS naming conventions.  Pass large objects by
      	const reference, not by value.
      
      
      Former-commit-id: bcb4e066
      562e2061
    • Guillaume Unal's avatar
      Fix for incorrect interpration of HV mapping for endcap presampler (LArHV-00-00-36) · 3b664719
      Guillaume Unal authored
      	* src/EMECPresamplerHVManager.cpp   Fix for incorrect interpration of HV mapping for endcap presampler:
                 There are 32 modules in phi (0-31)
                 each module has 2 cell in phi, in the mapping database this is referred by "gapIndex"
                 0 is on the low phi side (in the ATLAS frame)
                 1 in on the  high phi side
                 so in total 64 sectors in phi given by 2*phiIndex+gapIndex
                  the two gap of these sectors are powered by the same line and have the same HV
             (while in the previous code, there were 32 sectors for HV in phi, with the two gaps powered by the two different HV lines)
               * tag LArHV-00-00-36
      
      
      Former-commit-id: 459ea028
      3b664719
  23. Dec 16, 2016
  24. Dec 09, 2016
    • Walter Lampl's avatar
      fix one-time leak of AttributeListSpecificaton (LArAffectedRegion-00-01-06) · ab51ad48
      Walter Lampl authored
      	* fix one-time leak of AttributeListSpecificaton
      	* tag LArAffectedRegion-00-01-06
      
      1-12-2016 Pavol Strizenec <pavol @ mail.cern.ch>
      	* Fixing one time memory leak (ATLASRECTS-3222)
         	* tag LArAffectedRegion-00-01-05
      
      2016-09-20  scott snyder  <snyder@bnl.gov>
      
      	* Tagging LArAffectedRegion-00-01-04.
      	* Comply with ATLAS naming conventions.
      
      
      Former-commit-id: bb9440d7273126998f47310809d33e76233eeb46
      ab51ad48
    • John Derek Chapman's avatar
      src/LArG4CalibSD.cc (ProcessHits): Comment out line which skips steps with a... · 3b6b1718
      John Derek Chapman authored
      src/LArG4CalibSD.cc (ProcessHits): Comment out line which skips steps with a TotalEnergyDeposit of zero. obo Guillaume Unal. Should fix ATLASSIM-3065. Tagging LArG4Code-00-08-18-01 (LArG4Code-00-08-18-01)
      
      	* Tagging LArG4Code-00-08-18-01
      	* src/LArG4CalibSD.cc (ProcessHits): Comment out line which skips
      	steps with a TotalEnergyDeposit of zero. obo Guillaume
      	Unal. Should fix ATLASSIM-3065.
      
      
      Former-commit-id: 49ae4091eee7a71281f74d5ad787fa57d655e76d
      3b6b1718
Loading