Skip to content
Snippets Groups Projects

Factor out external interactions from ThroughputProfileHandler, add test and cleanup

Merged Rosen Matev requested to merge rmatev-refactor-throughput into master
All threads resolved!
  • Remove obsolete UpgradeThroughputHandler
  • Fix old tests for python 3 and update README (use pytest)
  • Update the environment instructions
  • Add gitignore
  • Refactor ThroughputProfileHandler
    • split out external interactions with CouchDB and GitLab/Mattermost such that they can be reused
    • clean up the code
  • Add test for the ThroughputProfileHandler
  • Add functions for interacting with the LHCbPR BE and use it in the ThroughputProfileHandler
Edited by Rosen Matev

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Rosen MatevRosen Matev 4 years ago (Apr 22, 2021 10:04am UTC)

Merge details

  • Changes merged into master with f4b61339 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christoph Hasse
  • Dmitry Popov
  • Dmitry Popov
  • Rosen Matev added 1 commit

    added 1 commit

    • de591a6f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Rosen Matev added 1 commit

    added 1 commit

    • 33026acd - Improve query for getting LHCbPR job ids

    Compare with previous version

  • Rosen Matev added 2 commits

    added 2 commits

    • 025c3489 - Add get_latest_job_id
    • 51e309a5 - Use exact=true for querying job ids and add test

    Compare with previous version

  • Rosen Matev resolved all threads

    resolved all threads

  • Christoph Hasse
  • Christoph Hasse
  • Christoph Hasse
  • Christoph Hasse
  • Christoph Hasse
  • mentioned in issue #4 (closed)

  • Christoph Hasse mentioned in issue #5

    mentioned in issue #5

  • Rosen Matev added 1 commit

    added 1 commit

    • f3aedbc7 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Rosen Matev resolved all threads

    resolved all threads

  • added 1 commit

    • dd46e317 - support removing labels in post_gitlab_feedback

    Compare with previous version

  • Rosen Matev added 20 commits

    added 20 commits

    • dd46e317...f6eeca4f - 7 commits from branch master
    • f6d7a9c9 - Remove obsolete UpgradeThroughputHandler
    • 5d8b0d5f - Update the environment instructions
    • f5809c47 - Add gitignore
    • 46ea10bb - Refactor ThroughputProfileHandler
    • 685f2fa5 - Add test for the ThroughputProfileHandler
    • 5c2ae2b8 - Add functions for interacting with the LHCbPR BE
    • b1291ef0 - Fix old tests for python 3 and update README
    • f2f02039 - Apply 1 suggestion(s) to 1 file(s)
    • 27b2029b - Improve query for getting LHCbPR job ids
    • 802f7a88 - Add get_latest_job_id
    • a8af7132 - Use exact=true for querying job ids and add test
    • 8f16939f - Apply 1 suggestion(s) to 1 file(s)
    • cabe1875 - support removing labels in post_gitlab_feedback

    Compare with previous version

  • Rosen Matev added 1 commit

    added 1 commit

    • ba02c0d2 - Update environment setup instructions

    Compare with previous version

  • Rosen Matev marked this merge request as ready

    marked this merge request as ready

  • Rosen Matev added 1 commit

    added 1 commit

    • 34fb9238 - Ignore local environment artifacts

    Compare with previous version

  • Author Developer

    Let test this in production :rocket: :see_no_evil:

  • merged

  • Rosen Matev mentioned in commit f4b61339

    mentioned in commit f4b61339

  • Rosen Matev mentioned in merge request !198 (merged)

    mentioned in merge request !198 (merged)

  • Rosen Matev mentioned in merge request !199 (merged)

    mentioned in merge request !199 (merged)

  • Rosen Matev mentioned in commit e6bc10c6

    mentioned in commit e6bc10c6

  • Rosen Matev mentioned in merge request !200 (merged)

    mentioned in merge request !200 (merged)

  • Rosen Matev mentioned in commit 8eaa0e95

    mentioned in commit 8eaa0e95

  • Please register or sign in to reply
    Loading