Skip to content
Snippets Groups Projects

Add a sprucing bandwidth test

Merged Shunan Zhang requested to merge add-new-bandwidth-tests into master
All threads resolved!

A new bandwidth tests, Moore_spruce_bandwidth, is added to monitor the rate/event size/bandwidth of Sprucing lines.

This test will be launched in LHCbPR everyday for each lhcb-master and lhcb-head build, and will replace the current Moore_spruce_rate_and_size test.

Some major changes to

  • filesize.py
  • line-and-stream-rates.py
  • line-similarty.py
  • make_bandwidth_test_page.py
  • stream_overlap.py

to make the scripts also work for Sprucing test.

One big change is on the unpacking algorithm, as reading MDF is different for Sprucing.

In summary, the old unpacking algorithm

    manifest = load_tck(args.tck)
    algs = do_unpacking(manifest, input_process=args.process)
    algsnew = algs[0:4] + [algs[-1]]

is replaced by

    algs = []
    unpack = unpack_rawevent(
        bank_types=['ODIN', 'HltDecReports', 'DstData', 'HltRoutingBits'],
        configurables=True)
    hlt2 = [hlt_decisions(source="Hlt2", output_loc="/Event/Hlt2/DecReports")]
    if args.process == 'Spruce':
        spruce = [
            hlt_decisions(
                source="Spruce", output_loc="/Event/Spruce/DecReports")
        ]
    else:
        spruce = []
    decoder = decoder(input_process=args.process)
    algs = [unpack] + hlt2 + spruce + [decoder] + [createODIN(ODIN='myODIN')]

The Hlt2 results before/after this change are identical.

I've generated two preview pages for Hlt2 and Sprucing.

Requires lhcb/Moore!2365 (merged).

Work towards lhcb-dpa/project#199 and lhcb/Moore#507 (closed).

cc @enoomen @sstahl @nskidmor @abertoli

Edited by Shunan Zhang

Merge request reports

Pipeline #5675759 passed

Pipeline passed for 005b862a on add-new-bandwidth-tests

Approved by

Merged by Nicole SkidmoreNicole Skidmore 1 year ago (Jun 8, 2023 12:53pm UTC)

Merge details

Pipeline #5705208 passed

Pipeline passed for a79bea1d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shunan Zhang added 2 commits

    added 2 commits

    Compare with previous version

  • Shunan Zhang added 1 commit

    added 1 commit

    Compare with previous version

  • Sascha Stahl approved this merge request

    approved this merge request

  • Hello @shunan, can you assign to somebody with karma so that this gets merged as soon as lhcb/Moore!2365 (merged) goes in? Thanks.

  • Eduardo Rodrigues resolved all threads

    resolved all threads

  • assigned to @rmatev

  • Nicole Skidmore mentioned in commit a79bea1d

    mentioned in commit a79bea1d

  • @shunan I have merged this - please keep an eye out for any problems

  • Please register or sign in to reply
    Loading