[RTADPA BW TESTS] Fix Moore_spruce_latest_bandwidth test

Fix the construction of the yaml config file for the sprucing job, and make sure the job tries to download it from the right place. To test the construction of the config I ran the HLT2 step locally, which produces a yaml that looks correct, then copied that into the directory where the sprucing test is ran and observed that the sprucing test is now all OK - this is a rough emulation of what the test does on the LHCbPR machine.

Also remove an obviated test script and step.

• Needs re-testing again as I fixed it locally before Christmas.

scripts/benchmark-scripts/Moore_bandwidth_test.sh

@@ -151,7 +151,7 @@ case $PROCESS in
         ;;
         latest)
         # "latest" corresponds to using the uploaded full-stream output from a "process=hlt2, input-data=nominal" test.
-        # These files are overwritten during "lhcb-master" builds of "process=hlt2, input-data=nominal", i.e. Daily.
+        # These files are overwritten during "lhcb-master" builds of "process=hlt2, input-data=nominal", i.e. ~daily.
         CONFIG_FILE="tmp/hlt2_bw_testing__production__full__metadata.yaml"
         EXTRA_OPTS='-um --read-evt-max-from-config $MOOREROOT/options/muon_geometry_v2.py'
         ;;
@@ -227,18 +227,13 @@ echo 'Combining all rate and bandwidth tables'
 time python $PRCONFIGROOT/python/MooreTests/combine_rate_output.py --process $PROCESS
 STORE_ERR_CODE
 
-# 7. Test on the feasibility of a chained HLT2->Sprucing test
-if [ $PROCESS = "spruce" ] && [ $INPUTDATA = "nominal" ]; then
-    echo 'Testing downloads of Hlt2 output for the future'
-    time python -m MooreTests.download_hlt2_output
-    STORE_ERR_CODE
-elif [ $PROCESS = "hlt2" ] && [ $INPUTDATA = "nominal" ]; then
-    # 7.1 Required information for 'latest' sprucing Jobs.
-    echo 'Generating metadata.yaml for potential upload to eos'
+# 7. Required information for 'latest' sprucing jobs.
+if [ $PROCESS = "hlt2" ] && [ $INPUTDATA = "nominal" ]; then
+    echo 'Generating yaml metadata to upload to eos for Moore_spruce_latest_bandwidth test'
     time python -m MooreTests.generate_hlt2_fullstream_metadata -c $CONFIG_FILE
     STORE_ERR_CODE
 fi
 
 # 8. Produce plots and HTML pages; add the --building-locally flag to make the links work if you are building the html pages locally
 echo 'Making plots and HTML pages'
-time python -m MooreTests.make_bandwidth_test_page -p $PROCESS -c $CONFIG_FILE -s $SCRIPT_PATH -e $ERR_CODE
\ No newline at end of file
+time python -m MooreTests.make_bandwidth_test_page -p $PROCESS -c $CONFIG_FILE -s $SCRIPT_PATH -e $ERR_CODE