Skip to content

[devel] Add macOS support for BookkeepingReport.__getNodeInformation

Chris Burr requested to merge cburr/LHCbDIRAC:fix-tests-on-macos into devel

Currently all the unit tests pass on macOS except for Workflow/Modules/test/Test_Modules_BookkeepingReport.py::test_execute which fails due to BookkeepingReport.__getNodeInformation not supporting macOS. While it's probably not useful to support macOS, I think the fix might be simple enough to justify merging? If you disagree this can be closed.

While writing this I think I found a bug currently result["Memory(kB)"] contains the 4th line of /proc/meminfo (Buffers):

MemTotal:        6100340 kB
MemFree:         4450804 kB
MemAvailable:    5580624 kB
Buffers:           19764 kB
Cached:          1300544 kB
SwapCached:            0 kB
Active:           348608 kB

I guess this is supposed to report MemAvailable or MemTotal instead?

Edited by Chris Burr

Merge request reports