Skip to content

Quality of Life improvements for LbAPI

Emir Muhammad requested to merge emmuhamm-yaml-not-in-folder into main

This merge request aims to do a few things:

  1. Checks if a file is in a folder or not
  2. Auto tags the MR if the number of events requested goes above PPG thresholds.
  3. Add error message if .yml is the file extension

Note:

Rough tests were added, but they are in no way optimal. Its nice for this to go in first, and then we can fix it later as the improvements would be helpful now rather than later.

TODO:

  • make pytests for all of this
  • tag issues with the QEE as well?
  • Clean up the rough tests made
  • Add test for the tags

Checks if file is in a folder:

It is possible that analysts / liaisons accidentally put the yaml files outside a folder, breaking the CI as it can't find a job to run (I know, I've done this myself 😅)

TODO:

  • Check which kind of 'not in a folder' we would like to test

Tags MR if above PPG thresholds

Sometimes (rather often in QEE for some reason ¯\_(ツ)_/¯) requests are sufficiently large enough that they need to go to PPG approval. This limit is ambiguous, so its useful if we have a tag that lets the relevant people know that this should go through to PPG before they can submit.

For now aim should just be to tag it, we can add a rule later 😄

PPG Limit:

Full details can be found here, and further discussion in the LbMCSubmit mattermost.

But essentially, PPG is required if the merge request contains :

  • 4M events for DST

  • 20M events for mDST

TODO:

  • Add hacky implementation of it
  • Refine it based on the parameters discussed above

.yml checks

Its possible someone accidentally submits a .yml file, which is hard to find because there is no error messages to quickly point towards it. This adds in the .yml check and shows up as an error message so people can easily identify where the mistake is.

Add WG Labels in production issues

It would be nice to add some WG labels in the production issues. This merge request also adds that in.

Warning Check this commit in MCRequest (made by myself), theres a possibility that someone will submit a .yaml file and a .yml file, so this sohuld be checked if it can work or not. 14fcfede7bddecb4f6957afc0a39c739d00d3b1d

TODO:

  • Review implementation
  • Add test for this
Edited by Emir Muhammad

Merge request reports