First go at removing Run2 specific code

Here is an attempt to describe what is being dropped. Someone more competent can follow up with issues or re-adding back adapted code where appropriate.

• Partially removed:
  • ATrackSelector (Alignment/AlignTrTools): remove TT/IT/OT filters
  • AlignSaveTuple and AlignTrackMonitor (Alignment/AlignTrTools): remove TT/IT/OT quantity calculation and saving/histograming
    • These two algorithms seems to share a lot of identical code (some of which is removed here). Some refactoring will be needed to get rid of that duplication.
    • fitTrackPiece is removed, which looks generic and probably usable for Run3
    • boxOverlap is almost generic (except for a bit of ST knowledge), so it can probably be reused
  • GetElementsToBeAligned (Alignment/TAlignment): remove Run 1-2 detectors
  • VAlign (Alignment/VeloAlignment): remove counting of number of R/Phi hits per track. Probably to be replaced with VP equivalent.
• Completely removed:
  • GAlign (Alignment/TAlignment): an unused alignment algorithm?
  • AlRobustAlignAlg (Alignment/TAlignment): used only for magnet off alignment of TT/IT/OT startings from VELO tracks? Creates residual histograms.
    • This seems reasonably generic code that can probably be reused
  • Calibration/OTCalibration package

See Rec!1714 (merged) for some motivation behind this

mentioned in merge request Rec!1714 (merged)

changed the description

• [2019-10-01 15:55] Validation started with lhcb-lcg-test#5
• [2019-10-02 08:18] Validation started with lhcb-lcg-test#6
• [2019-10-08 14:52] Validation started with lhcb-lcg-test#7
• [2019-10-09 18:06] Validation started with lhcb-lcg-test#8
• [2019-11-11 09:09] Validation started with lhcb-lcg-test#9
• [2019-11-13 10:41] Validation started with lhcb-lcg-test#10
• [2019-11-13 15:54] Validation started with lhcb-lcg-test#11
• [2019-11-22 10:16] Validation started with lhcb-lcg-test#12
• [2019-11-25 11:50] Validation started with lhcb-lcg-test#13
• [2019-12-04 00:13] Validation started with lhcb-head#2452

added 1 commit

• 008261b0 - First go at removing Run2 specific code

Compare with previous version

added 1 commit

• 8caaa70a - First go at removing Run2 specific code

Compare with previous version

added 5 commits

• 8caaa70a...c95fbc13 - 4 commits from branch master
• 03e34871 - First go at removing Run2 specific code

Compare with previous version

added 7 commits

• 03e34871...cb091612 - 6 commits from branch master
• eee8575f - First go at removing Run2 specific code

Compare with previous version

added 1 commit

• dfc310a9 - First go at removing Run2 specific code

Compare with previous version

unmarked as a Work In Progress

assigned to @devieira and @wouter

@devieira @wouter Could you please go through these changes and review what's being removed?

In particular, before we proceed with this clean up we should be sure we're not removing something that is definitely needed, but also we should open issues when similar functionality to that being removed will be needed for Run 3.

assigned to @gunther

added lhcb-head label

assigned to @rmatev and unassigned @wouter, @devieira, and @gunther

changed the description

@smalde @wouter I have made an attempt to describe what is being dropped. Someone more competent can follow up with creating issues and/or re-adding back adapted code where appropriate.

With that I would say we can merge this now, especially since it's blocking other developments

added Tracking label and removed lhcb-head label

unassigned @rmatev

approved this merge request

merged

mentioned in commit ea22cc8b