Muon upgrade Alignment

• Preparation of muon detector alignment for the upgrade.

• Temporarily includes fixed copies of relevant configured fitters from Rec which are broken in TAlignment. Will replace them with a more permanent solution in the future.

• Alignables.py now has upgrade option for switching M1 on or off. Option and M1 could be removed completely.

• Several modifications to remove M1.

• New algorithm MuonTrackSelector in AlignTrTools to replace deprecated TrackFilterAlg.

• Updated muon track selections and fitting in TAlignment/TrackSelections.py for upgrade

• Added Escher options file for muon upgrade alignment

@pgriffit once you think this is ready please remove the WIP and if you have an idea of someone, assign them to do a review.

unmarked as a Work In Progress

changed the description

assigned to @devieira

mentioned in issue Moore#136 (closed)

@pgriffit @devieira @rmatev @smalde Can this be merged?

@bimitres I need to make one more commit to account for changes in Rec and from my point of view it can be merged. I will be able to do so this afternoon.

added 1 commit

• b2f7b7cf - follow Rec

Compare with previous version

@pgriffit we should add qmtest here. You're 95% of the way there and for the rest, take some inspiration from https://gitlab.cern.ch/lhcb/Alignment/-/blob/master/Alignment/Escher/tests/qmtest/escher.qms/align-vp-halves.qmt and https://gitlab.cern.ch/lhcb/Alignment/-/blob/master/Alignment/Escher/tests/options/validate-align-vp-halves.py for the actual validator.

You can find useful info about running/writing tests in the Moore docs. Let me know if you need help with this.

can you please rebase on master (or merge it into your branch)? This will fix the pipeline issue (you might need to apply some formatting on the modified/new files).

Since TrackMuonMatching is changed to support only 4 station, we should fully remove the M1 from the code sooner rather than later. If you prefer not to do it now just resolve this thread into an issue.

The new MuonTrackSelector algorithm should be "modernised", but I would postpone this to another MR, after we have a working test for the muon alignment.

mentioned in issue #1

assigned to @pgriffit and unassigned @devieira

assigned to @svecchi

added 19 commits

• b2f7b7cf...fe7513a8 - 9 commits from branch master
• 6e4b3216 - add new muon track filter
• 7cc9723f - fixed number of muon stations
• 16a62c0d - add muon upgrade alignment options
• 6b37e867 - add option for muon upgrade alignables
• 9fd35794 - add option for muon upgrade alignables
• 341e48fa - add temporary fitters for muon
• 3a0d64c7 - update muon TrackSelections for upgrade
• 5175d049 - fix copyright and whitespace
• 3565682c - follow Rec
• b1348aa0 - Merge branch 'muon-upgrade' of https://gitlab.cern.ch/lhcb/Alignment into muon-upgrade

Compare with previous version

added 1 commit

• 70415325 - Fixed formatting

Compare with previous version

added 1 commit

• 4401476e - use nSTATIONS to define m_zMS size

Compare with previous version

added 1 commit

• e2dbb2a8 - add qmtests. options file needs data input when file in TestFileDB

Compare with previous version

added 2 commits

• e5a7aded - remove M1 from Alignables and Scenarios. Remove upgrade argument from...
• ee0ce14f - cleanup

Compare with previous version

added 2 commits

• e5ffc156 - Fixed formatting
• 184d8367 - add test file

Compare with previous version

added 1 commit

• 0b1ba774 - fix formatting

Compare with previous version

added 22 commits

• 4bce2015 - add new muon track filter
• 9261f986 - fixed number of muon stations
• 9a56172b - add muon upgrade alignment options
• 343716d4 - add option for muon upgrade alignables
• 8e7e6f1e - add option for muon upgrade alignables
• a5b5fc7e - add temporary fitters for muon
• e9695100 - update muon TrackSelections for upgrade
• 31e9e546 - fix copyright and whitespace
• b6ff1e61 - follow Rec
• 05aa7493 - add muon upgrade alignment options
• 1456c551 - add option for muon upgrade alignables
• d621fd78 - add temporary fitters for muon
• a1b10c18 - fix copyright and whitespace
• 171660f0 - follow Rec
• 6d9b086d - Fixed formatting
• 993d5cb4 - use nSTATIONS to define m_zMS size
• 451ea5ce - add qmtests. options file needs data input when file in TestFileDB
• 97612e31 - remove M1 from Alignables and Scenarios. Remove upgrade argument from...
• 7bc12308 - cleanup
• 703e1080 - Fixed formatting
• 8cb90e79 - add test file
• 216abd23 - fix formatting

Compare with previous version

added 1 commit

• 9c5cc2aa - Fixed formatting

Compare with previous version

added 2 commits

• 54695e33 - add qmtest for muon
• d8e2143e - fix formatting

Compare with previous version

resolved all threads

mentioned in merge request lhcb-datapkg/PRConfig!121 (merged)

@dovombru this looks good to me, let's just run it in a ci-test

assigned to @dovombru and unassigned @pgriffit and @svecchi

resolved all threads

added 1 commit

• c47dff8b - Apply suggestion to Alignment/Escher/tests/qmtest/escher.qms/align-muon.qmt

Compare with previous version

resolved all threads

added 1 commit

• 741e45a7 - Apply suggestion to Alignment/Escher/tests/qmtest/escher.qms/align-muon.qmt

Compare with previous version

• [2020-04-23 11:20] Validation started with lhcb-master-mr#705

assigned to @pgriffit and unassigned @dovombru

resolved all threads

added Muon new feature testing labels

approved this merge request

unassigned @pgriffit

merged

mentioned in commit 962dd471

mentioned in issue Moore#163 (closed)