Alignment code clean up in preperation of dd4hep migration

The alignment projects needs to migrated to the dd4hep geometry. This is easier if some of the legacy code is removed. Currently, the project contains two alignment algorithms:

• the original millepede algorithm, with separate implementations for Velo and T-stations
• the global chi2 algorithm based on the LHCb kalman filter trackfit (Alignment/TAlignment)

The millepede algorithms have essentially not been used since 2011. Since it is not clear who would do the migration, we propose to remove them. The removed packages are:

• Alignment/VeloAlignment
• Alignment/AlignmentTools
• Alignment/MisAligner

changed the description

unmarked as a Work In Progress

added 1 commit

• f5c837f5 - removed since it makes little sense (yet) to migrate this to dd4hep

Compare with previous version

added 1 commit

• b28990d9 - removed obsolete package MisAligner

Compare with previous version

changed the description

@sponce, @bimitres, @sborghi, @lgrillo FYI

changed the description

added all-slots label

assigned to @acasaisv

/ci-test --merge

Started reference and integration test builds. Once done, check the comparison of build and test results.

There are some warnings with Escher when compiling on all slots which introduce a problem when using the options. This probably has to be fixed before merging.

Can you point me to an example? Thanks ...

When compiled there is this warning:

Subdirectory 'Alignment/Escher' declares dependency on unknown subdirectory
  'Alignment/AlignmentTools'

And if you look at one of the tests output in the stdout cannot find Escher and none of them runs.

I could reproduce that the configurable was missing. I hope that it is fixed now.

/ci-test --merge

Started reference and integration test builds. Once done, check the comparison of build and test results.

It looks good now, the missing configurable is solved and tests run as expected.

• [2020-06-25 11:45] Validation started with lhcb-master-mr#985
• [2020-06-26 00:16] Validation started with lhcb-dd4hep#568
• [2020-06-26 00:20] Validation started with lhcb-sanitizers#607
• [2020-06-26 00:25] Validation started with lhcb-lcg-test#75
• [2020-06-26 00:26] Validation started with lhcb-head#2633
• [2020-06-26 00:28] Validation started with lhcb-gaudi-head#2644
• [2020-06-26 01:06] Validation started with lhcb-sanitizers#607
• [2020-06-26 08:28] Validation started with lhcb-dd4hep#569
• [2020-06-26 09:23] Validation started with lhcb-dd4hep#570
• [2020-06-26 09:37] Validation started with lhcb-dd4hep#571
• [2020-06-26 16:52] Validation started with lhcb-master-mr#991
• [2020-06-27 00:16] Validation started with lhcb-dd4hep#572
• [2020-06-27 00:18] Validation started with lhcb-sanitizers#608
• [2020-06-27 00:20] Validation started with lhcb-lcg-test#76
• [2020-06-27 00:25] Validation started with lhcb-head#2634
• [2020-06-27 00:31] Validation started with lhcb-gaudi-head#2645
• [2020-06-27 12:27] Validation started with lhcb-gaudi-head#2646
• [2020-06-28 00:11] Validation started with lhcb-lcg-test#77
• [2020-06-28 00:11] Validation started with lhcb-sanitizers#609
• [2020-06-28 00:15] Validation started with lhcb-gaudi-head#2647
• [2020-06-28 00:18] Validation started with lhcb-dd4hep#573
• [2020-06-28 00:26] Validation started with lhcb-head#2635
• [2020-06-29 00:12] Validation started with lhcb-sanitizers#610
• [2020-06-29 00:14] Validation started with lhcb-gaudi-head#2648
• [2020-06-29 00:16] Validation started with lhcb-dd4hep#574
• [2020-06-29 00:17] Validation started with lhcb-head#2636
• [2020-06-29 00:18] Validation started with lhcb-lcg-test#78

assigned to @wouter

added 2 commits

• 21a4ea28 - remove VeloAlignment
• f2cc9904 - make sure Escher configurable is generated

Compare with previous version

added 1 commit

• 659993ed - Fixed formatting

Compare with previous version

added 1 commit

• 1f0c0c61 - remove empty file

Compare with previous version

assigned to @jonrob

merged

mentioned in commit a0c33fd2

unassigned @jonrob, @wouter, and @acasaisv

added cleanup label