NTupleSvc in VP aligment options and removing convergence in modules test
- An option for creating an ntuple was added in
AlignVPHalves.pyandAlignVPHalvesModules.py, it is commented so the we don't create an ntuple when tests run. - The convergence check was removed from
align-vp-halves-modulesso that the test checks only the eigenvalues. The validating script for convergence is still available to be included in another test if needed.
Merge request reports
Activity
assigned to @gunther
added testing label
Resolved by Andre Gunther/ci-test --merge --platforms=x86_64-centos7-gcc9-opt
added ci-test-triggered label
- [2020-09-25 08:46] Validation started with lhcb-master-mr#1366
- [2020-09-26 00:44] Validation started with lhcb-head-2#19
- [2020-09-27 00:15] Validation started with lhcb-head-2#20
- [2020-09-28 00:16] Validation started with lhcb-head-2#21
Edited by Software for LHCbadded lhcb-head-2 label
mentioned in merge request Rec!2212 (merged)
- Resolved by Dorothea Vom Bruch
The test had two parts: one is checking for the eigenvalues and the other was the convergence. It is a better idea to check for convergence for more events as now for this number of events we don't gain much information on the convergence, so it would be good to leave this test to check the only the eigenvalues.
The test still runs when the ntuple is made, but we don't need to generate an ntuple each time we run the test as that takes a lot of space. To make the ntuple
VPTrackMonitorneeds to be added in the configuration of the Alignment, and the user can do it locally if needed to use that option. We don't need to use the ntuple for the tests, I added the option commented so it stays if needs to be used.Edited by Biljana Mitreska
mentioned in issue Moore#212 (closed)
removed ci-test-triggered lhcb-head-2 labels
mentioned in commit d10b4929