Skip to content
Snippets Groups Projects

Prototype of new alignment configuration

Merged Florian Reiss requested to merge pyconf into master

Overview

This MR contains a prototype for configuring alignment jobs using a Moore-like configuration. Its main purpose is documenting the work done during past hackathons and to serve as basis for the next steps. It includes track and vertex selections, adding constraints and defining the elements to be aligned. The fundamental change is making the Alignment project depend on Moore instead of Phys.

Some documentation how to use the new configuration is provided in Alignment/Humboldt/README.md

Next steps and open points are summarised in #17 and #20

Configurations

The configurations added are

Alignment/Humboldt/options/AlignVPHalvesModules.py #example Velo alignment job
Alignment/Humboldt/options/AlignVPHalvesModules_PrKalman.py #example Velo job using PrKalman (see #16)
Alignment/Humboldt/options/AlignFTStationsLayers.py #example SciFi job
Alignment/Humboldt/options/AlignVPHalvesModules_Analyzer.py #run analyser part of example alignment job
Alignment/Humboldt/options/AlignVPHalvesModules_Iterator.py #run iterator part of example alignment job

Helper functions to set up new configuration are in Alignment/Humboldt/python/Humboldt/utils.py.

Central track and particle selections are started to be defined in

Alignment/Humboldt/python/Humboldt/TrackSelections.py
Alignment/Humboldt/python/Humboldt/ParticleSelections.py

New functionality (WIP)

  • add AlignIterator taking parts from OnlineAlignment to perform iterator part offline

Tests

  • add Alignment/Humboldt/tests/qmtest/humboldt.qms/align-vp-halves-modules.qmt to test new configuration
  • add Alignment/Humboldt/tests/qmtest/humboldt.qms/analyzer-vp-halves-modules.qmt to test Analyzer part
  • add Alignment/Humboldt/tests/qmtest/humboldt.qms/iterator-vp-halves-modules.qmt to test Iterator part
  • add Alignment/Humboldt/tests/qmtest/humboldt.qms/align-vp-halves-modules-splititer.qmt to test gaudisplititer.py (WIP)

Uses Rec!2495 (merged)

Edited by Rosen Matev

Merge request reports

Merge request pipeline #3515129 passed

Merge request pipeline passed for 9c1fc2d7

Approved by

Merged by Rosen MatevRosen Matev 3 years ago (Feb 1, 2022 3:11pm UTC)

Merge details

  • Changes merged into master with 4b26c873.
  • Deleted the source branch.

Pipeline #3515132 passed

Pipeline passed for 4b26c873 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sascha Stahl
  • Sascha Stahl
  • Florian Reiss mentioned in merge request Rec!2495 (merged)

    mentioned in merge request Rec!2495 (merged)

  • Florian Reiss added 19 commits

    added 19 commits

    • 0e203bb7...7662eab4 - 15 commits from branch master
    • f499456a - Merge remote-tracking branch 'origin/master' into pyconf
    • 12b46d5e - get tracks and PVs from reconstruction object
    • bfa60e2d - Merge branch 'pyconf2' into pyconf
    • d5df1748 - Merge remote-tracking branch 'origin/master' into pyconf

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss changed the description

    changed the description

  • Florian Reiss
  • Florian Reiss added 3 commits

    added 3 commits

    • da2513dd - use VeloClusterTrackingSIMDFull in new configuration
    • cd1d48d1 - reorganize new configuration in Humboldt
    • 224e887f - prototype for new SciFi configuration

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss marked the checklist item refactoring the different steps into separate files/functions as completed

    marked the checklist item refactoring the different steps into separate files/functions as completed

  • Florian Reiss mentioned in issue #17

    mentioned in issue #17

  • Florian Reiss added 5 commits

    added 5 commits

    • 07ad9549 - rename Velo.py
    • 16c0106c - workaround for different PV locations
    • 4692cbbc - add script to use PrKalman
    • 279e822b - try to recosntruct D0 for SciFi alignment
    • d46a3b9d - Merge remote-tracking branch 'origin/pyconf' into pyconf

    Compare with previous version

  • Florian Reiss changed the description

    changed the description

  • Florian Reiss added 17 commits

    added 17 commits

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    • 78d7501f - use fastet reco for alignment with PrKalman

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    Compare with previous version

  • Florian Reiss mentioned in merge request Moore!1152 (merged)

    mentioned in merge request Moore!1152 (merged)

  • Florian Reiss added 1 commit

    added 1 commit

    • 7d0bfde7 - add missing copyright statements

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    • 9fefbe56 - manually fix some formatting

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    • 517acbdd - manually fix some formatting

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    • 35c7157e - manually fix some formatting

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 8 commits

    added 8 commits

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    • ed7b8db5 - add switch to choose between old and new configuration in gaudiiter
    • 49207f6a - set up Humboldt tests

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 3 commits

    added 3 commits

    • de177e29 - Expect single quotes when parsing XMLWriter vectors
    • 142cbc05 - use fixed XMLWriter parser
    • e573abe4 - mark TODO in gaudiiter

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 4 commits

    added 4 commits

    • b9710a96 - add exception when trying to run new configuration with more than one iteration
    • 7aa2f863 - set default XMLWriters to empty list
    • 3c0fef05 - add tests for Humboldt
    • 1036882c - fix validate-analyzer.py

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    • 65325256 - write out xml files from AlignIterator

    Compare with previous version

  • Florian Reiss added 5 commits

    added 5 commits

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    • 10fefe0c - add test for iterator using putput from analyser
    • 718a8f1b - finalize Humboldt tests

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    • 117fc6cb - add Humboldt test for gaudisplititer
    • 3bb092fa - fix gaudisplititer test

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Reiss changed the description

    changed the description

  • Florian Reiss added 1 commit

    added 1 commit

    • 02161bb6 - change test to check for output files instead of convergence

    Compare with previous version

  • Florian Reiss added 2 commits

    added 2 commits

    • 2f144657 - clean up AlignIterator
    • 56549005 - set UpdateInFinalize to False as default

    Compare with previous version

  • Florian Reiss added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading