Skip to content
Snippets Groups Projects

fix: cmake warning configurable CountingPrescaler missining in database

Merged Christoph Hasse requested to merge chasse_fix_cmake_warning into master
All threads resolved!

Supposed to fix a warning we see in the nightlies.

This was already logged as issue in #15 (closed) where @rmatev actually mentions this exact fix but said it didn't work for him.

But based on the documentation of lhcb_add_confuser_dependencies I do think that the dependency isn't correct and the build.ninja file does have the following changes with the fix:

from:

build Alignment/Escher/genConfDir/Escher/Escher_user.confdb: CUSTOM_COMMAND ../Alignment/Escher/python/Escher/Configuration.py || Alignment/TAlignment/TAlignment_confuserdb

to:

build Alignment/Escher/genConfDir/Escher/Escher_user.confdb: CUSTOM_COMMAND ../Alignment/Escher/python/Escher/Configuration.py || Alignment/AlignKernel/libAlignKernel.so Alignment/TAlignment/libTAlignment.so Alignment/TAlignment/libTAlignmentLib.so

Before the change I was able to reproduce the problem locally, afterwards I wasn't.
So let's take this for a spin in the nightlies.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading