Skip to content
Snippets Groups Projects

avoid hardwiring hashes in algorithm names

Merged avoid hardwiring hashes in algorithm names
avoid-hardwiring-hashes into master
1 unresolved thread
Merged Gerhard Raven requested to merge avoid-hardwiring-hashes into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gerhard Raven added bug fix label

    added bug fix label

  • Gerhard Raven added 1 commit

    added 1 commit

    • 1318bb2a - avoid hardwiring hashes in algorithm names

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • c12b0df0 - avoid hardwiring hashes in algorithm names

    Compare with previous version

  • Software for LHCb added RTA label

    added RTA label

  • Rosen Matev assigned to @freiss and @bimitres

    assigned to @freiss and @bimitres

  • Rosen Matev removed bug fix label

    removed bug fix label

  • Rosen Matev added cleanup label

    added cleanup label

  • Rosen Matev resolved all threads

    resolved all threads

  • Rosen Matev assigned to @rmatev and unassigned @freiss and @bimitres

    assigned to @rmatev and unassigned @freiss and @bimitres

  • Software for LHCb added ci-test-triggered label

    added ci-test-triggered label

  • L
    Software for LHCb @lhcbsoft ·
    Developer
  • Rosen Matev added needs ref update label

    added needs ref update label

  • Software for LHCb mentioned in commit e8659bdf

    mentioned in commit e8659bdf

    • L
      Software for LHCb @lhcbsoft ·
      Developer

      The RefBot pipeline created the following reference update MRs: !391 (merged)

      Click this to see encountered Alignment warnings 
      Alignment: Warning, results for test: Humboldt.align-ft-modules not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g', 'x86_64_v3-centos7-gcc11+detdesc-opt+g'}
Alignment: Different test results for Alignment/Humboldt/tests/refs/align-ft-modules.ref on platforms ['x86_64_v2-centos7-gcc11-opt', 'x86_64_v2-centos7-gcc11-dbg', 'x86_64_v2-centos7-clang12-opt', 'x86_64_v2-el9-gcc12-opt']
Alignment: Comparing x86_64_v2-centos7-gcc11-opt to:
Alignment:	 x86_64_v2-centos7-gcc11-dbg differs by:
Alignment:	 Differences in CountersMismatch:
Alignment:	x86_64_v2-centos7-gcc11-opt:
    (CaloTrackBasedElectronShowerAlg_... new) average DLL | 1003 | -52.02665 | -0.051871 | 0.086185 | -0.53790 | 0.24086
    (CaloTrackBasedElectronShowerAlg_...2 new) average DLL | 998 | -52.24504 | -0.052350 | 0.086984 | -0.53846 | 0.23604
Alignment:	x86_64_v2-centos7-gcc11-dbg:
    (CaloTrackBasedElectronShowerAlg_... new) average DLL | 1003 | -52.02664 | -0.051871 | 0.086185 | -0.53790 | 0.24086
    (CaloTrackBasedElectronShowerAlg_...2 new) average DLL | 998 | -52.24503 | -0.052350 | 0.086984 | -0.53846 | 0.23604
Alignment:	 x86_64_v2-centos7-clang12-opt differs by:
Alignment:	 Differences in CountersMismatch:
Alignment:	x86_64_v2-centos7-gcc11-opt:
    (CaloTrackBasedElectronShowerAlg_... new) average DLL | 1003 | -52.02665 | -0.051871 | 0.086185 | -0.53790 | 0.24086
    (CaloTrackBasedElectronShowerAlg_...2 new) average DLL | 998 | -52.24504 | -0.052350 | 0.086984 | -0.53846 | 0.23604
Alignment:	x86_64_v2-centos7-clang12-opt:
    (CaloTrackBasedElectronShowerAlg_... new) average DLL | 1003 | -52.02664 | -0.051871 | 0.086185 | -0.53790 | 0.24086
    (CaloTrackBasedElectronShowerAlg_...2 new) average DLL | 998 | -52.24503 | -0.052350 | 0.086984 | -0.53846 | 0.23604
Alignment:	 x86_64_v2-el9-gcc12-opt differs by:
Alignment:	 Differences in CountersMismatch:
Alignment:	x86_64_v2-centos7-gcc11-opt:
    (CaloTrackBasedElectronShowerAlg_... new) average DLL | 1003 | -52.02665 | -0.051871 | 0.086185 | -0.53790 | 0.24086
    (CaloTrackBasedElectronShowerAlg_...2 new) average DLL | 998 | -52.24504 | -0.052350 | 0.086984 | -0.53846 | 0.23604
Alignment:	x86_64_v2-el9-gcc12-opt:
    (CaloTrackBasedElectronShowerAlg_... new) average DLL | 1003 | -52.02664 | -0.051871 | 0.086185 | -0.53790 | 0.24086
    (CaloTrackBasedElectronShowerAlg_...2 new) average DLL | 998 | -52.24503 | -0.052350 | 0.086984 | -0.53846 | 0.23604
Alignment: Warning, results for test: Humboldt.align-ft-halfmodules not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g', 'x86_64_v3-centos7-gcc11+detdesc-opt+g'}
Alignment: Warning, results for test: Humboldt.align-vp-halves-modules-prkalman not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g', 'x86_64_v3-centos7-gcc11+detdesc-opt+g'}
Alignment: Warning, results for test: Humboldt.align-run3-collisions not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g', 'x86_64_v3-centos7-gcc11+detdesc-opt+g'}
Alignment: Warning, results for test: Humboldt.align-vp-halves-modules-tmf not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g', 'x86_64_v3-centos7-gcc11+detdesc-opt+g'}
Alignment: Different test results for Alignment/Humboldt/tests/refs/align-vp-halves-modules-tmf.ref on platforms ['x86_64_v2-centos7-gcc11-opt', 'x86_64_v2-centos7-gcc11-dbg', 'x86_64_v2-centos7-clang12-opt', 'x86_64_v2-el9-gcc12-opt']
Alignment: Comparing x86_64_v2-centos7-gcc11-opt to:
Alignment:	 x86_64_v2-centos7-gcc11-dbg differs by:
Alignment:	 Differences in Output Diff:
Alignment:	x86_64_v2-centos7-gcc11-opt:
 Average number of tracks per vertex: 7.38278
 Normalised alignment change chisquare: 0.00472847
 Number of active parameters:    168
 Number of alignables with insufficient statistics: 0
 Number of negative eigenvalues: 24
 ToolSvc.EigenDiagSolvTool              INFO Number / total chi2 of rejected eigenvalues: 0 0
 ToolSvc.updateTool                     INFO Applying post-conditioning
+Alignment delta chisquare/dof: 0.680899 / 144
+Alignment delta chisquare/track dof: 5.18298e-06
+Alternative ...
Alignment:	x86_64_v2-centos7-gcc11-dbg:
Alignment:	 x86_64_v2-centos7-clang12-opt differs by:
Alignment:	 Differences in Output Diff:
Alignment:	x86_64_v2-centos7-gcc11-opt:
Average number of tracks per vertex: 7.38278
Normalised alignment change chisquare: 0.00472847
Number of active parameters:    168
Number of alignables with insufficient statistics: 0
Number of negative eigenvalues: 24
ToolSvc.EigenDiagSolvTool              INFO Number / total chi2 of rejected eigenvalues: 0 0
ToolSvc.updateTool                     INFO Applying post-conditioning
+Alignment delta chisquare/dof: 0.680899 / 144
+Alignment delta chisquare/track dof: 5.18298e-06
+Alternative ...
Alignment:	x86_64_v2-centos7-clang12-opt:
Alignment:	 x86_64_v2-el9-gcc12-opt differs by:
Alignment:	 Differences in Output Diff:
Alignment:	x86_64_v2-centos7-gcc11-opt:
Average number of tracks per vertex: 7.38278
Normalised alignment change chisquare: 0.00472847
Number of active parameters:    168
Number of alignables with insufficient statistics: 0
Number of negative eigenvalues: 24
ToolSvc.EigenDiagSolvTool              INFO Number / total chi2 of rejected eigenvalues: 0 0
ToolSvc.updateTool                     INFO Applying post-conditioning
+Alignment delta chisquare/dof: 0.680899 / 144
+Alignment delta chisquare/track dof: 5.18298e-06
+Alternative ...
Alignment:	x86_64_v2-el9-gcc12-opt:
Alignment: Warning, results for test: Humboldt.align-vp-halves-modules-splititer not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g', 'x86_64_v3-centos7-gcc11+detdesc-opt+g'}

      Click this to see encountered MooreOnline warnings 
      MooreOnline/x86_64_v2-centos7-gcc11-opt: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v2-centos7-gcc11-opt: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v2-centos7-gcc11-dbg: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v2-centos7-gcc11-dbg: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v2-centos7-clang12-opt: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v2-centos7-clang12-opt: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v3-centos7-gcc11-opt+g: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v3-centos7-gcc11-opt+g: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v2-centos7-gcc11+detdesc-opt: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v2-centos7-gcc11+detdesc-opt: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v2-centos7-gcc11+detdesc-dbg: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v2-centos7-gcc11+detdesc-dbg: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v2-centos7-clang12+detdesc-opt: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v2-centos7-clang12+detdesc-opt: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v3-centos7-gcc11+detdesc-opt+g: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v3-centos7-gcc11+detdesc-opt+g: Test without ref failed: MooreScripts.hlt2slim!
MooreOnline/x86_64_v2-el9-gcc12-opt: Test MooreScripts.hlt2slim contains nonzero exit code and/or warnings!
MooreOnline/x86_64_v2-el9-gcc12-opt: Test without ref failed: MooreScripts.hlt2slim!

    • Rosen Matev
      Rosen Matev @rmatev ·
      Maintainer

      @freiss you can check on the linked MR how names changed

    • Florian Reiss
      Florian Reiss @freiss ·
      Maintainer

      it looks like the hashes in the names haven't been fully removed. For example, there is a change TrackVertexMonitor/PatPVLeftRightFinderMerger_c5a0159dVertexMonitor-> rackVertexMonitor/VertexMonitor__Event_PatPVLeftRightFinderMerger_c5a0159d_OutputVertices.

      But that's fine, we'll have another look as we finalise the naming for the monitoring

    • G
      Gerhard Raven @graven ·
      Author Developer

      in order to generate a unique name for TrackVertexMonitor (i.e. without hash) it uses the TES location that this monitor uses in its name, as that location is unique. What you see above is that that TES location in turn is automatically derived from the name of the producer, and the producer (i.e. PatPVLeftRightFinderMerger) happens to still have a hash in its name. So this is a 'second order' effect that still has to be cured.

    • Florian Reiss
      Florian Reiss @freiss ·
      Maintainer

      thanks for the explanation!

    • Please register or sign in to reply
  • Software for LHCb mentioned in merge request !391 (merged)

    mentioned in merge request !391 (merged)

  • Rosen Matev approved this merge request

    approved this merge request

  • Rosen Matev resolved all threads

    resolved all threads

  • Rosen Matev merged

    merged

  • Rosen Matev mentioned in commit d65d9766

    mentioned in commit d65d9766

  • Rosen Matev mentioned in commit 555603cb

    mentioned in commit 555603cb

  • Yang Gao mentioned in issue Moore#598 (closed)

    mentioned in issue Moore#598 (closed)

Please register or sign in to reply