Fix compilation warnings as in !73

Please do not merge until it has been tested in the nightlies

• [2019-05-08 00:16] Validation started with lhcb-run2-patches#381
• [2019-05-09 00:17] Validation started with lhcb-run2-patches#382

There are a few tests failing, but I have the impression it's just due to a difference in output. Should I merge and prepare new references?

Please wait, I haven't had a chance to look yet.

Indeed the test failures seem to be entirely due to output changes related not to this MR but to the move to Gaudi/master. There is a crashing test, due to a typo in a script that will be removed when LHCb!1878 (merged) is merged. So yes, you can update the references, except for $ESCHERROOT/tests/refs/escherhltd0-par.ref

Concerning this MR, there are still two compilation warnings, that I'd like to try to fix before you merge

added 1 commit

• 9b8052af - Fixed compilation warnings

Compare with previous version

added 1 commit

• 771286c5 - fix deprecated auto_ptr warning, use unique_ptr instead

Compare with previous version

added 1 commit

• df693cea - Fix exception by value warning

Compare with previous version

@devieira this is ready for merge. You can also update the test references, except for $ESCHERROOT/tests/refs/escherhltd0-par.ref as discussed above

Ok, thanks. I will try to update the references sometime tomorrow.

merged

mentioned in commit a7c62668

added modernisation label