Add test for VP halves alignment

• also update version of Phys dependency

marked as a Work In Progress

assigned to @rmatev

Thanks a lot @bimitres!

@smalde I assigned this to myself as I want to review it but who is ultimately going to sign this off and merge?

Hi Rosen, I shouldn't sign off on this because i have no familiarity with this code. Daniel Vieira is the package manger here. I can't see how to tag him.

@devieira - Hi Daniel, these are start of the tests to make the alignment package easier to maintain. Please could you review the merge request and liaise with Rosen as necessary? Cheers

assigned to @devieira

Thanks @rmatev for checking, I can remove the WIP, if you think this should be merged.

added 3 commits

• ba379491 - some fixes
• d4458d60 - some fixes
• 07890f3f - some fixes

Compare with previous version

@bimitres, @rmatev, @smalde, Thank you for the notice, I was already following this MR. At first glance, everything looks fine to me, but due to the little overlap time I had with Giulio, I'm not quite sure what would be the appropriate checks to be performed here, besides the nightlies. Would you have any suggestions?

The type of checks we are initially looking for are for functionality - i.e to test that all parts of the alignment algorithms can continue to run if there are any changes to Rec etc. This will help the alignment package keep up with latest changes. The second level of tests would also be to check the output of the algorithm such that one can check that the results do not go haywire. I think it will be easier for the some of tests to be proposed by the developers especially as their work progresses, however it would be useful if you can be involved. I know that @sstahl and @rmatev had some ideas too.

added 7 commits

• 07890f3f...7f7d1c87 - 5 commits from branch master
• 8323b26a - Merge remote-tracking branch 'origin/master' into upgrade-fix-2019
• 9c20f4a7 - Follow removal of HltMonitors in Rec!1604 (merged)

Compare with previous version

@bimitres I merged the current master as this branch was quite behind and then I fixed a small issue to follow up on Rec!1604 (merged) .

The test passes for me locally!

I'll add some more comments today

unmarked as a Work In Progress

changed title from WIP: Change of Rec version and added VP Halves alignment test to Add test for VP halves alignment

changed the description

Great, I did not have that issue when making the merge request it's a rather new change.

• [2019-07-10 00:18] Validation started with lhcb-gaudi-head#2313
• [2019-07-10 00:20] Validation started with lhcb-head#2297
• [2019-07-10 00:21] Validation started with lhcb-tdr-test#603
• [2019-07-10 10:13] Validation started with lhcb-gaudi-merge#792
• [2019-07-10 16:11] Validation started with lhcb-gaudi-merge#793
• [2019-07-10 16:30] Validation started with lhcb-gaudi-merge#793
• [2019-07-10 16:49] Validation started with lhcb-gaudi-merge#793
• [2019-07-11 00:13] Validation started with lhcb-head#2298
• [2019-07-11 00:17] Validation started with lhcb-gaudi-head#2314
• [2019-07-11 00:20] Validation started with lhcb-tdr-test#604
• [2019-07-11 10:29] Validation started with lhcb-gaudi-merge#794
• [2019-07-12 00:15] Validation started with lhcb-gaudi-head#2315
• [2019-07-12 00:18] Validation started with lhcb-head#2299
• [2019-07-12 00:23] Validation started with lhcb-tdr-test#605
• [2019-07-12 16:08] Validation started with lhcb-gaudi-head#2258
• [2019-07-13 00:19] Validation started with lhcb-tdr-test#606
• [2019-07-13 00:22] Validation started with lhcb-gaudi-head#2316
• [2019-07-13 00:24] Validation started with lhcb-head#2300
• [2019-07-14 00:19] Validation started with lhcb-tdr-test#607
• [2019-07-14 00:19] Validation started with lhcb-head#2301
• [2019-07-14 00:19] Validation started with lhcb-gaudi-head#2317
• [2019-07-15 00:20] Validation started with lhcb-gaudi-head#2318
• [2019-07-15 00:21] Validation started with lhcb-head#2302
• [2019-07-15 00:22] Validation started with lhcb-tdr-test#608
• [2019-07-15 16:35] Validation started with lhcb-gaudi-head#2259
• [2019-07-16 00:20] Validation started with lhcb-head#2303
• [2019-07-16 00:21] Validation started with lhcb-gaudi-head#2319
• [2019-07-16 00:22] Validation started with lhcb-tdr-test#609
• [2019-07-17 00:20] Validation started with lhcb-tdr-test#610
• [2019-07-17 00:20] Validation started with lhcb-head#2304
• [2019-07-17 00:24] Validation started with lhcb-gaudi-head#2320
• [2019-07-17 11:00] Validation started with lhcb-gaudi-head#2260
• [2019-07-17 17:01] Validation started with lhcb-gaudi-head#2261
• [2019-07-17 17:07] Validation started with lhcb-gaudi-merge#795
• [2019-07-18 00:17] Validation started with lhcb-head#2305
• [2019-07-18 00:18] Validation started with lhcb-gaudi-head#2321
• [2019-07-18 00:27] Validation started with lhcb-tdr-test#611
• [2019-07-18 12:07] Validation started with lhcb-gaudi-head#2322
• [2019-07-19 10:31] Validation started with lhcb-tdr-test#612
• [2019-07-19 10:33] Validation started with lhcb-gaudi-head#2323
• [2019-07-20 00:16] Validation started with lhcb-head#2307
• [2019-07-20 00:19] Validation started with lhcb-tdr-test#613
• [2019-07-20 00:22] Validation started with lhcb-gaudi-head#2324
• [2019-07-21 00:14] Validation started with lhcb-gaudi-head#2325
• [2019-07-21 00:16] Validation started with lhcb-head#2308
• [2019-07-21 00:17] Validation started with lhcb-tdr-test#614
• [2019-07-22 00:18] Validation started with lhcb-tdr-test#615
• [2019-07-22 00:19] Validation started with lhcb-gaudi-head#2326
• [2019-07-22 00:23] Validation started with lhcb-head#2309
• [2019-07-22 11:18] Validation started with lhcb-gaudi-merge#796
• [2019-07-22 18:36] Validation started with lhcb-gaudi-merge#797
• [2019-07-23 01:06] Validation started with lhcb-head#2311
• [2019-07-23 01:14] Validation started with lhcb-gaudi-head#2328
• [2019-07-23 01:15] Validation started with lhcb-tdr-test#617
• [2019-07-24 00:18] Validation started with lhcb-tdr-test#618
• [2019-07-24 00:18] Validation started with lhcb-gaudi-head#2329
• [2019-07-24 00:18] Validation started with lhcb-head#2312
• [2019-07-25 00:10] Validation started with lhcb-dd4hep#258
• [2019-07-25 00:14] Validation started with lhcb-head#2313
• [2019-07-25 00:14] Validation started with lhcb-tdr-test#619
• [2019-07-25 00:16] Validation started with lhcb-gaudi-head#2330
• [2019-07-26 00:09] Validation started with lhcb-dd4hep#259
• [2019-07-26 00:11] Validation started with lhcb-head#2314
• [2019-07-26 00:12] Validation started with lhcb-tdr-test#620
• [2019-07-26 00:15] Validation started with lhcb-gaudi-head#2331
• [2019-07-27 00:07] Validation started with lhcb-dd4hep#260
• [2019-07-27 00:10] Validation started with lhcb-head#2315
• [2019-07-27 00:10] Validation started with lhcb-gaudi-head#2332
• [2019-07-27 00:11] Validation started with lhcb-tdr-test#621
• [2019-07-28 00:06] Validation started with lhcb-dd4hep#261
• [2019-07-28 00:10] Validation started with lhcb-gaudi-head#2333
• [2019-07-28 00:15] Validation started with lhcb-head#2316
• [2019-07-28 00:25] Validation started with lhcb-tdr-test#622
• [2019-07-29 00:09] Validation started with lhcb-dd4hep#262
• [2019-07-29 00:11] Validation started with lhcb-gaudi-head#2334
• [2019-07-29 00:11] Validation started with lhcb-head#2317
• [2019-07-29 00:14] Validation started with lhcb-tdr-test#623
• [2019-07-30 00:07] Validation started with lhcb-dd4hep#263
• [2019-07-30 00:10] Validation started with lhcb-gaudi-head#2335
• [2019-07-30 00:12] Validation started with lhcb-head#2318
• [2019-07-30 00:13] Validation started with lhcb-tdr-test#624
• [2019-07-31 00:09] Validation started with lhcb-dd4hep#264
• [2019-07-31 00:12] Validation started with lhcb-head#2319
• [2019-07-31 00:14] Validation started with lhcb-gaudi-head#2336
• [2019-07-31 00:14] Validation started with lhcb-tdr-test#625
• [2019-08-01 00:07] Validation started with lhcb-dd4hep#265
• [2019-08-01 00:12] Validation started with lhcb-gaudi-head#2337
• [2019-08-01 00:15] Validation started with lhcb-tdr-test#626
• [2019-08-01 00:16] Validation started with lhcb-head#2320
• [2019-08-02 00:07] Validation started with lhcb-dd4hep#266
• [2019-08-02 00:12] Validation started with lhcb-gaudi-head#2338
• [2019-08-02 00:12] Validation started with lhcb-tdr-test#627
• [2019-08-02 00:13] Validation started with lhcb-head#2321
• [2019-08-02 23:01] Validation started with lhcb-gaudi-merge#798
• [2019-08-03 00:07] Validation started with lhcb-dd4hep#267
• [2019-08-03 00:14] Validation started with lhcb-head#2322
• [2019-08-03 00:18] Validation started with lhcb-tdr-test#628
• [2019-08-03 00:26] Validation started with lhcb-gaudi-head#2339
• [2019-08-04 00:05] Validation started with lhcb-dd4hep#268
• [2019-08-04 00:09] Validation started with lhcb-head#2323
• [2019-08-04 00:11] Validation started with lhcb-tdr-test#629
• [2019-08-04 00:12] Validation started with lhcb-gaudi-head#2340
• [2019-08-05 00:08] Validation started with lhcb-dd4hep#269
• [2019-08-05 00:10] Validation started with lhcb-tdr-test#630
• [2019-08-05 00:15] Validation started with lhcb-gaudi-head#2341
• [2019-08-05 00:16] Validation started with lhcb-head#2324
• [2019-08-06 00:09] Validation started with lhcb-dd4hep#270
• [2019-08-06 00:12] Validation started with lhcb-gaudi-head#2342
• [2019-08-06 00:16] Validation started with lhcb-head#2325
• [2019-08-06 00:16] Validation started with lhcb-tdr-test#631
• [2019-08-06 17:24] Validation started with lhcb-gaudi-merge#799
• [2019-08-07 00:09] Validation started with lhcb-dd4hep#271
• [2019-08-07 00:14] Validation started with lhcb-gaudi-head#2343
• [2019-08-07 00:14] Validation started with lhcb-head#2326
• [2019-08-07 00:15] Validation started with lhcb-tdr-test#632
• [2019-08-08 00:10] Validation started with lhcb-dd4hep#272
• [2019-08-08 00:14] Validation started with lhcb-head#2327
• [2019-08-08 00:15] Validation started with lhcb-tdr-test#633
• [2019-08-08 00:20] Validation started with lhcb-gaudi-head#2344
• [2019-08-09 00:08] Validation started with lhcb-dd4hep#273
• [2019-08-09 00:15] Validation started with lhcb-gaudi-head#2345
• [2019-08-09 00:16] Validation started with lhcb-head#2328
• [2019-08-09 00:17] Validation started with lhcb-tdr-test#634
• [2019-08-09 09:50] Validation started with lhcb-head#2329
• [2019-08-09 09:52] Validation started with lhcb-tdr-test#635
• [2019-08-09 09:52] Validation started with lhcb-gaudi-head#2346
• [2019-08-09 15:06] Validation started with lhcb-gaudi-merge#801
• [2019-08-10 00:07] Validation started with lhcb-dd4hep#274
• [2019-08-10 00:15] Validation started with lhcb-gaudi-head#2347
• [2019-08-10 00:20] Validation started with lhcb-tdr-test#636
• [2019-08-10 00:21] Validation started with lhcb-head#2330
• [2019-08-11 00:09] Validation started with lhcb-dd4hep#275
• [2019-08-11 00:09] Validation started with lhcb-head#2331
• [2019-08-11 00:12] Validation started with lhcb-gaudi-head#2348
• [2019-08-11 00:16] Validation started with lhcb-tdr-test#637
• [2019-08-12 00:06] Validation started with lhcb-dd4hep#276
• [2019-08-12 00:14] Validation started with lhcb-gaudi-head#2349
• [2019-08-12 00:14] Validation started with lhcb-head#2332
• [2019-08-12 00:17] Validation started with lhcb-tdr-test#638
• [2019-08-13 00:11] Validation started with lhcb-dd4hep#277
• [2019-08-13 00:15] Validation started with lhcb-head#2333
• [2019-08-13 00:17] Validation started with lhcb-gaudi-head#2350
• [2019-08-13 00:18] Validation started with lhcb-tdr-test#639
• [2019-08-14 00:10] Validation started with lhcb-dd4hep#278
• [2019-08-14 00:14] Validation started with lhcb-gaudi-head#2351
• [2019-08-14 00:18] Validation started with lhcb-head#2334
• [2019-08-14 00:23] Validation started with lhcb-tdr-test#640
• [2019-08-15 00:07] Validation started with lhcb-dd4hep#279
• [2019-08-15 00:14] Validation started with lhcb-head#2335
• [2019-08-15 00:14] Validation started with lhcb-gaudi-head#2352
• [2019-08-15 00:17] Validation started with lhcb-tdr-test#641
• [2019-08-16 00:08] Validation started with lhcb-dd4hep#280
• [2019-08-16 00:12] Validation started with lhcb-gaudi-head#2353
• [2019-08-16 00:14] Validation started with lhcb-tdr-test#642
• [2019-08-16 00:16] Validation started with lhcb-head#2336
• [2019-08-16 09:28] Validation started with lhcb-gaudi-head#2354
• [2019-08-16 16:51] Validation started with lhcb-gaudi-merge#802
• [2019-08-17 00:06] Validation started with lhcb-dd4hep#281
• [2019-08-17 00:16] Validation started with lhcb-tdr-test#643
• [2019-08-17 00:18] Validation started with lhcb-gaudi-head#2355
• [2019-08-17 00:18] Validation started with lhcb-head#2337
• [2019-08-18 00:07] Validation started with lhcb-dd4hep#282
• [2019-08-18 00:10] Validation started with lhcb-head#2338
• [2019-08-18 00:13] Validation started with lhcb-gaudi-head#2356
• [2019-08-18 00:15] Validation started with lhcb-tdr-test#644
• [2019-08-19 00:10] Validation started with lhcb-dd4hep#283
• [2019-08-19 00:14] Validation started with lhcb-tdr-test#645
• [2019-08-19 00:15] Validation started with lhcb-head#2339
• [2019-08-19 00:17] Validation started with lhcb-gaudi-head#2357
• [2019-08-19 17:31] Validation started with lhcb-gaudi-merge#803
• [2019-08-20 00:08] Validation started with lhcb-dd4hep#284
• [2019-08-20 00:15] Validation started with lhcb-tdr-test#646
• [2019-08-20 00:16] Validation started with lhcb-head#2340
• [2019-08-20 00:19] Validation started with lhcb-gaudi-head#2358
• [2019-08-20 10:14] Validation started with lhcb-head#2341
• [2019-08-20 10:19] Validation started with lhcb-tdr-test#647
• [2019-08-20 16:39] Validation started with lhcb-gaudi-merge#804
• [2019-08-20 18:43] Validation started with lhcb-gaudi-merge#805
• [2019-08-21 00:07] Validation started with lhcb-dd4hep#285
• [2019-08-21 00:13] Validation started with lhcb-head#2342
• [2019-08-21 00:19] Validation started with lhcb-tdr-test#648
• [2019-08-21 00:23] Validation started with lhcb-gaudi-head#2359