prefer std::optional<T> over std::pair<bool, T>

replace std::pair<bool, T> with std::optional<T> and adapt code.

Also, avoid looking up the same thing twice...

mentioned in commit e15f0cd8

added 1 commit

• 53662797 - prefer std::optional<T> over std::pair<bool, T>

Compare with previous version

changed the description

added RTA label

added 8 commits

• 53662797...382a74f8 - 7 commits from branch master
• 8c2951d1 - prefer std::optional<T> over std::pair<bool, T>

Compare with previous version

mentioned in issue Moore#506 (closed)

/ci-test

added ci-test-triggered label

• [2022-12-25 10:44] Validation started with lhcb-master-mr#6646
• [2023-01-28 10:50] Validation started with lhcb-master-mr#6834
• [2023-01-30 16:43] Validation started with lhcb-master-mr#6860

approved this merge request

resolved all threads

Last test reported broken test in MooreOnline but logs not available anymore. Running a new test.

/ci-test

added 30 commits

• 8c2951d1...3fdbf977 - 28 commits from branch master
• b5045f30 - prefer std::optional<T> over std::pair<bool, T>
• 022bbf7b - Check the optional everywhere before calling empty() on its content

Compare with previous version

resolved all threads

assigned to @raaij

enabled an automatic merge when the pipeline for 022bbf7b succeeds

added hlt1-throughput-increased label

resolved all threads

merged

mentioned in commit b2741ffc

mentioned in issue Moore#518 (closed)

mentioned in commit bf13d609