Add monitoring using global atomicity histograms
Adds monitoring of HLT1 using Gaudi accumulator histograms which are atomicity::none in a wrapper to lock them at the histogram level instead of the bin level as atomicity::full does. Currently this is done in Allen so that it can be added quickly, but we will move it to Gaudi in case any other applications want to use this scheme. Using the single node server to test throughput, this performs within 7.5% of master as allowed by the CI tests, so I do not expect a slowdown. This includes all histograms from the monitoring_pit branch used at the end of 2022 and the ones included in @dcraik's original merge request except for the 2D CALO ones. The histograms added are:
Reconstruction:
- MakeLongTrackParticles (number of tracks, track eta, track phi, track pt)
- pv_beamline_cleanup (number of PVs, PV x, PV y, PV z)
- ConsolidateSciFi (number of tracks, track eta, track phi, number of hits)
- ConsolidateSciFiSeeding (number of seeds, track eta, track phi, number of hits)
- ConsolidateMatchedTracks (number of tracks, track eta, track phi, number of hits)
- VeloConsolidateTracks (number of tracks)
- VeloKalmanFilter (track eta, track phi, number of hits)
- VertexFitter (number of SVs)
Lines:
- D2KPi (mass, pt)
- D2KK (mass, pt)
- D2PiPi (mass, pt)
- LowMassNoipDielectronLine (mass with and without brem correction, same sign and opposite sign)
- KsToPiPi (mass, pt)
- DiMuonDrellYanLine (same sign and opposite sign mass)
- DiMuonMassLine (J/Psi mass)
- DiMuonNoIPLine (same sign and opposite sign mass)
The prescales for LowMassNoipDielectronLine and DiMuonNoIPLine were switched to postscales to allow for those events to fill the monitoring histograms with no change to the overall rate. Once the method is finalized, I will create documentation on how to add monitoring. Many thanks to @dcampora, @nnolte, @raaij, and everyone else who advised on this.
Merge request reports
Activity
added Monitoring label
added RTA label
added 40 commits
-
ada441be...3a49a0ef - 2 commits from branch
master - 89d1f8b1 - monitoring counters for trackers
- ea14baae - calo cluster counter
- 6a5741e2 - number of tracks / event histograms
- ff86f9c9 - d2kpi
- 613e230c - jpsi mass histo
- bf23ad86 - pi0 line
- a516e2f0 - fix pi0 line merge
- e77b746c - fixed track monitoring histrograms
- 83c4bcc7 - enable mass monitoring
- 0b86f8ee - KsToPiPi line mass plot for monitoring
- ae9efbdb - add std::move
- 18de5eef - fixed axis range for kstopipi line
- a712ba5a - velo tack eta, phi, nhits monitoring
- 32a5a2cc - fix for backwards velo tracks eta
- d0439020 - fix CopyTrackParameters dependencies
- be5858bd - monitoring of scifi seeds eta, phi and nhits
- 5ca22fc6 - eta, phi and nhits plots for long tracks (both matching & forward)
- a97ccb14 - long track monitoring
- 783904d4 - fix errors and update pit monitoring for current master
- 89e4d077 - add other line monitoring
- 4c9ba9bd - SV histogram
- 3efe0b16 - working but not perfect
- 0749e8b7 - histogram level lock and dielectron proof of concept
- ba311de1 - change to use new histogram type
- 31ddb607 - updates to dark photon monitoring
- 1f45780b - improve gatherselections monitoring
- e1661484 - fix warnings
- 58af9776 - better buffer use DOES NOT COMPILE
- a1d8c965 - Revert "pi0 line"
- 6fd637f8 - Revert "fix pi0 line merge"
- 8618744c - remove removed functions from headers
- 014e47ec - fix errors and warnings
- 379be677 - updates so buffers are used correctly
- 50a4cc4c - change monitoring to take arrays and counters
- 29307321 - switch monitoring to correct buffer use
- f2f82399 - move CaloFilterClusters counter
- 85c2f33e - Fixed formatting
- db0ee8f5 - Merge branch 'kaaricha_rebase_histogram_level_lock_full' of...
Toggle commit list-
ada441be...3a49a0ef - 2 commits from branch
added 38 commits
- 5dca70c4 - monitoring counters for trackers
- 0f0886c7 - calo cluster counter
- 057357ec - number of tracks / event histograms
- e73b1c8c - d2kpi
- 0723037f - jpsi mass histo
- 020c0dc4 - pi0 line
- 7f3dd81e - fix pi0 line merge
- ebfca9b2 - fixed track monitoring histrograms
- 93f14f4a - enable mass monitoring
- 531730f4 - KsToPiPi line mass plot for monitoring
- 36653d17 - add std::move
- 92baa670 - fixed axis range for kstopipi line
- 26acf81d - velo tack eta, phi, nhits monitoring
- 417290c4 - fix for backwards velo tracks eta
- ce4769ff - fix CopyTrackParameters dependencies
- 4d5a0206 - monitoring of scifi seeds eta, phi and nhits
- 489e5594 - eta, phi and nhits plots for long tracks (both matching & forward)
- df84b772 - long track monitoring
- ff3fab03 - fix errors and update pit monitoring for current master
- 5fa9d1c1 - add other line monitoring
- 31a1af46 - SV histogram
- 8fb7840f - working but not perfect
- efa358ad - histogram level lock and dielectron proof of concept
- e2451583 - change to use new histogram type
- 669ef2d1 - updates to dark photon monitoring
- d31c8452 - improve gatherselections monitoring
- 51fcde50 - fix warnings
- 1e696267 - better buffer use DOES NOT COMPILE
- 9a4f5ff8 - Revert "pi0 line"
- c5bcc3c9 - Revert "fix pi0 line merge"
- b5f2ced2 - remove removed functions from headers
- cfe88173 - fix errors and warnings
- f1a93f65 - updates so buffers are used correctly
- 827a2017 - change monitoring to take arrays and counters
- 55840fff - switch monitoring to correct buffer use
- d23e6acd - move CaloFilterClusters counter
- ada441be - Fixed formatting
- db0ee8f5 - Merge branch 'kaaricha_rebase_histogram_level_lock_full' of...
Toggle commit list- A deleted user
added hlt1-throughput-decreased label
- A deleted user
removed hlt1-throughput-decreased label
- Resolved by Kate Abigail Richardson
@kaaricha why are the rates of the lines for which you added monitoring histograms zero (see failures in the physics efficiency test)?
Resolved by Kate Abigail Richardson@kaaricha sorry for not following the discussion today at WP2 but looking at the list of histograms to be added, I don't see any histograms on PV reconstruction quantities. I seem to remember we had something in 2022, is it already merged? If not, maybe it should be added here?
- Last reply by Kate Abigail Richardson
