Skip to content
Snippets Groups Projects

Fix handling of shared_ptr to provider in allen.py

Merged Roel Aaij requested to merge fix_allen_py_provider into master
All threads resolved!

The MDFProvider was being destructed after the device had been reset.

A shared_ptr<IInputProvider> is used in RuntimeOptions to sort out memory management of the TESProvider in Allen-in-Moore. This was propagated to the allen() function, but there using a shared_ptr is the wrong type. This MR fixes the allen() signature to have a bare pointer instead and then sorts out the mismatch internally.

Together with: MooreOnline!314 (merged)

Edited by Roel Aaij

Merge request reports

Approved by

Merged by Sebastien PonceSebastien Ponce 1 year ago (Feb 9, 2024 3:20pm UTC)

Merge details

  • Changes merged into master with 19abb0b7 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading