Fix handling of shared_ptr to provider in allen.py
The MDFProvider
was being destructed after the device had been reset.
A shared_ptr<IInputProvider>
is used in RuntimeOptions
to sort out memory management of the TESProvider
in Allen-in-Moore. This was propagated to the allen()
function, but there using a shared_ptr
is the wrong type. This MR fixes the allen()
signature to have a bare pointer instead and then sorts out the mismatch internally.
Together with: MooreOnline!314 (merged)
Merge request reports
Activity
added bug fix label
added 1 commit
- d5bfc526 - Fix handling of shared_ptr to provider in allen.py
added RTA label
mentioned in merge request MooreOnline!314 (merged)
mentioned in merge request !1123 (merged)
- Resolved by Sebastien Ponce
/ci-test MooreOnline!314 (merged)
added ci-test-triggered label
- [2024-01-23 15:52] Validation started with lhcb-master-mr#10221
- [2024-01-23 16:09] Validation started with lhcb-master-mr#10224
- [2024-01-24 09:34] Validation started with lhcb-master-mr#10229
- [2024-01-25 14:49] Validation started with lhcb-master-mr#10248
- [2024-01-29 22:12] Validation started with lhcb-master-mr#10304
- [2024-02-05 12:12] Validation started with lhcb-master-mr#10400
- [2024-02-06 12:08] Validation started with lhcb-master-mr#10420
- [2024-02-06 13:57] Validation started with lhcb-master-mr#10422
- [2024-02-08 13:28] Validation started with lhcb-master-mr#10462
- [2024-02-08 15:52] Validation started with lhcb-master-mr#10467
Edited by Software for LHCbmentioned in issue #443
- Resolved by Roel Aaij
/ci-test --without-downstream --platforms x86_64_v3-el9-gcc12+cuda12_1-opt+g MooreOnline!314 (merged)
mentioned in merge request !924 (merged)
added 65 commits
-
c39a3f7b...0ed1d1d4 - 61 commits from branch
master
- 040415bd - Fix handling of shared_ptr to provider in allen.py
- db3c9c63 - Don't use a shared_ptr<IInputProvider> as an argument to allen()
- e1418b92 - Avoid global import of wrapped device algorithms in gaudi_allen_generator.py
- bc022a57 - Fix Allen-in-Moore
Toggle commit list-
c39a3f7b...0ed1d1d4 - 61 commits from branch
added 34 commits
-
bc022a57...5997b9a8 - 30 commits from branch
master
- 63c4ea23 - Fix handling of shared_ptr to provider in allen.py
- d5f2f739 - Don't use a shared_ptr<IInputProvider> as an argument to allen()
- 19349098 - Avoid global import of wrapped device algorithms in gaudi_allen_generator.py
- c84e852a - Fix Allen-in-Moore
Toggle commit list-
bc022a57...5997b9a8 - 30 commits from branch
mentioned in issue Moore#699 (closed)
added 14 commits
-
c84e852a...934d6278 - 10 commits from branch
master
- ed165a44 - Fix handling of shared_ptr to provider in allen.py
- 8cc68fe6 - Don't use a shared_ptr<IInputProvider> as an argument to allen()
- d815cc86 - Avoid global import of wrapped device algorithms in gaudi_allen_generator.py
- 1a3afe86 - Fix Allen-in-Moore
Toggle commit list-
c84e852a...934d6278 - 10 commits from branch
mentioned in merge request !1326 (merged)
mentioned in issue Moore#700 (closed)
mentioned in merge request !1428 (merged)
assigned to @sponce
added hlt1-throughput-decreased label
requested review from @dovombru
removed hlt1-throughput-decreased label
added hlt1-throughput-decreased label
mentioned in commit 19abb0b7