Skip to content
Snippets Groups Projects

Fix Allen UT geometry

Merged Jiahui Zhuo requested to merge jzhuo_FixAllenUT into master

Migrate the fix from LHCb!4395 (merged) to the Allen project, which is more appropriate.

Test with LHCb!4395 (merged)

FYI: @bjashal @adeoyang @raaij @cagapopo @mveghel

Closes #467 (closed)

Edited by Dorothea Vom Bruch

Merge request reports

Approved by

Merged by Andre GuntherAndre Gunther 1 year ago (Feb 23, 2024 9:44am UTC)

Merge details

  • Changes merged into master with 2f67f8f0 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Roel Aaij
    • Resolved by Jiahui Zhuo

      @jzhuo Could you please add a an efficiency test on the expected 2024 MC sample with a sequence including the UT (such as hlt1_pp_forward_then_matching_validation) ? I have recently added this one to test the PV performance on a sample with the beamline not placed at (0,0). It runs on a minimum bias sample however, for a tracking efficiencies BsPhiPhi would be better suited. @ascarabo has already put some in the /scratch/allen_data area in online which can be used. In addition, a throughput test would be good as well. You can just add another sequence here.

  • Jiahui Zhuo added 1 commit

    added 1 commit

    • 36f535ba - Apply Aaij and Dorothea's suggestions

    Compare with previous version

  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Hangyi Wu mentioned in issue #467 (closed)

    mentioned in issue #467 (closed)

  • Dorothea Vom Bruch changed the description

    changed the description

  • mentioned in issue Moore#699 (closed)

  • @spradlin could you launch a ci test here (with LHCb!4395 (merged))?

  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Jiahui Zhuo mentioned in merge request !1384 (closed)

    mentioned in merge request !1384 (closed)

  • mentioned in issue Moore#700 (closed)

  • Jiahui Zhuo added 45 commits

    added 45 commits

    Compare with previous version

  • Dorothea Vom Bruch mentioned in issue #496

    mentioned in issue #496

  • Edited by Software for LHCb
  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Jiahui Zhuo resolved all threads

    resolved all threads

  • Jiahui Zhuo added 17 commits

    added 17 commits

    Compare with previous version

  • A deleted user added hlt1-throughput-decreased label
  • added 27 commits

    Compare with previous version

  • A deleted user removed hlt1-throughput-decreased label
  • A deleted user added hlt1-throughput-decreased label
  • added 1 commit

    Compare with previous version

  • A deleted user removed hlt1-throughput-decreased label
  • Andre Gunther resolved all threads

    resolved all threads

  • Andre Gunther approved this merge request

    approved this merge request

  • merged

  • Andre Gunther mentioned in commit 2f67f8f0

    mentioned in commit 2f67f8f0

  • Christina Agapopoulou mentioned in merge request !1431 (merged)

    mentioned in merge request !1431 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading