Prefer filters over selections
Optimise thread usage by using ODIN event list filters rather than ODIN selection, as discussed in #499 (closed).
No change in the selected number of events is expected and indeed, by running the hlt1_pp_lumi
sequence on master and on this branch, the enclosed logs are found. In particular, we have for both
Hlt1ODINLumi: 4192000/8000000, (15720.00 +/- 5.30) kHz
Some throughput is saved (1.5% on MC, but a larger gain might be expected on data as MC doesn't test e.g. the orbit and nobias lines) closes #499 (closed)
Also, this adds a line selecting ee bunches far from activity (as tagged by ODIN) that are useful for noise estimation (as required in https://gitlab.cern.ch/lhcb/opg/-/work_items/55)
cc @cagapopo to ask a review :)
and lumi conveners @fferrari @elniel @rsadek and @dcraik as this is dealing with luminosity
closes #499 (closed) closes https://gitlab.cern.ch/lhcb/opg/-/work_items/55 goes with MooreOnline!337 (merged)
Merge request reports
Activity
requested review from @cagapopo
added RTA label
assigned to @jhorswil
mentioned in issue Moore#708 (closed)
- Resolved by Saverio Mariani
Might need an Allen reference update for the physics efficiency test @samarian
changed milestone to %RTA/2024.03.04
added ci-test-triggered label
- [2024-02-28 15:32] Validation started with lhcb-master-mr#10799
- [2024-04-11 15:48] Validation started with lhcb-2024-patches-mr#38
- [2024-05-22 19:31] Validation started with lhcb-2024-patches-mr#523
Edited by Software for LHCbadded prioritymid label
mentioned in merge request !1443 (merged)
mentioned in merge request !1398 (merged)
mentioned in merge request Moore!3088 (merged)
added 40 commits
-
5bd78e57...47b0ecab - 33 commits from branch
master
- 2639907a - Prototype for ODIN eventtype filtering in place
- 82a7d0f0 - Fixed formatting
- 22890446 - Remove event_monitoring_lines as suggested by Christina
- e1db28b1 - PreFilter BeamGas line on bx=1 prefilter
- 47026ff5 - Fixed formatting
- 8302675c - Fix indentation
- c29d08c5 - Adapt to rebase
Toggle commit list-
5bd78e57...47b0ecab - 33 commits from branch
added 1 commit
- b7984f58 - Fix missing import and add explicit filter to PbPb line with decoding
mentioned in merge request MooreOnline!337 (merged)