Draft: Follow-up from "Allen RICH decoding"

#491 (closed)

assigned to @caschbur

added RTA label

added 76 commits

• 2f814bea...665c6e6a - 75 commits from branch master
• 72b62007 - Fixed the Allen configuration to allow Rich1 and Rich2 to be decoded.

Compare with previous version

added 1 commit

• a9d4803a - Fixed formatting

Compare with previous version

added 1 commit

• 46df3d01 - Fixed configuration files

Compare with previous version

added 1 commit

• 43a334d4 - Started working on switching the `m_bankTypes`

Compare with previous version

added 12 commits

• 43a334d4...3ab01c6f - 8 commits from branch master
• 2db1f420 - Fixed the Allen configuration to allow Rich1 and Rich2 to be decoded.
• 36037bee - Fixed formatting
• 2f24d90d - Fixed configuration files
• 7791ae54 - Started working on switching the `m_bankTypes`

Compare with previous version

added 26 commits

• 7791ae54...622ec3a9 - 22 commits from branch master
• 42ca033a - Fixed the Allen configuration to allow Rich1 and Rich2 to be decoded.
• 60e640e7 - Fixed formatting
• 1a8ff29b - Fixed configuration files
• 304c937e - Started working on switching the `m_bankTypes`

Compare with previous version

added 1 commit

• 4b288c2d - Error with parsing

Compare with previous version

added 85 commits

• 4b288c2d...230db563 - 80 commits from branch master
• 86490f6e - Fixed the Allen configuration to allow Rich1 and Rich2 to be decoded.
• 0acf381c - Fixed formatting
• acc727eb - Fixed configuration files
• 16a78636 - Started working on switching the `m_bankTypes`
• 5df872c1 - Error with parsing

Compare with previous version

The changes to TransposeRawBank have been included in !1603 (merged) and propagated through the various parts of the configuration.

added 1 commit

• 0d6f0623 - Removed workaround

Compare with previous version

added 55 commits

• 0d6f0623...99ded4dc - 47 commits from branch master
• b8d03a69 - Fixed the Allen configuration to allow Rich1 and Rich2 to be decoded.
• 82186d46 - Fixed formatting
• e6b2eb52 - Fixed configuration files
• b0a0db4c - Started working on switching the `m_bankTypes`
• e041fd0a - Error with parsing
• 6bf57f6e - Removed workaround
• 9efcd737 - Added types() function to iterate over BankTypes
• 3741294c - Fixed errors after rebase

Compare with previous version

added 1 commit

• e07f9770 - Added default argument

Compare with previous version

added 1 commit

• a07320ee - Modified the make_algorithm function to accomodate the different Riches

Compare with previous version

added 1 commit

• e220972b - Added a mapping between BankTypes and RawBank::BankTypes

Compare with previous version

Hi, all of the points in #491 (closed) are now addressed as part of !1603 (merged). Instead of running two testing algorithms, one for each Rich, the SmartIDs decoded by the Allen decoding separately for Rich1 and Rich2 are both taken as input by the testing algorithm and then compared to the Rec decoding in one go.

Alright! That's great, thank you, I'll be checking it out to understand the changes.

added 57 commits

• e220972b...dd160792 - 46 commits from branch master
• 70db3567 - 1 earlier commit
• 8351208c - Fixed formatting
• 1f77967a - Fixed configuration files
• 7316066b - Started working on switching the `m_bankTypes`
• fb37d2f4 - Error with parsing
• d583d1cc - Removed workaround
• 27318a48 - Added types() function to iterate over BankTypes
• 78210ffa - Fixed errors after rebase
• 5b14b4f6 - Added default argument
• 01c2424c - Modified the make_algorithm function to accomodate the different Riches
• a0d4f65a - Added a mapping between BankTypes and RawBank::BankTypes

Compare with previous version

closed