improve lumi counters

Now a block is scheduled per event instead of having a fixed number of blocks that process all events.

In order to get deterministic results for the counters, a intra-block copy of them in created in shared memory, using unsigned long type, and the results are added back to global memory at the end. This, in addition to MooreOnline!395 (merged), makes the counters (and their tests) stable across different runs

Time spent on these algorithms decrease by an order of magnitude (see current.txt and branch.txt files) and overall throughput increases ~13%.

branch.txt

current.txt

fyi @cagapopo @raaij

changed target branch from master to 2024-patches

added 1 commit

• 48fed86e - Fixed formatting

Compare with previous version

added 1 commit

• 8a32a211 - add needed sync after setting shared memory

Compare with previous version

added RTA label

changed milestone to %HLT1 release for 22.04.2024

removed milestone %HLT1 release for 22.04.2024

changed the description

mentioned in issue #532

mentioned in merge request MooreOnline!395 (merged)

added 39 commits

• 8a32a211...82e57f8f - 32 commits from branch 2024-patches
• 789805c6 - launch a block per event instead of fixed number
• dbee6c2a - Fixed formatting
• 38291664 - add needed sync after setting shared memory
• 1a112586 - fix shared memory initialization
• e9103ed4 - deterministic behaviour on calo lumi counters
• 90f01ddc - sort obtained PVs
• 9e0d507b - ensure deterministic behaviour on histogram

Compare with previous version

added 1 commit

• ffdc1246 - Fixed formatting

Compare with previous version

added hlt1-throughput-decreased label

added 1 commit

• ee3ba952 - fix warnings

Compare with previous version

removed hlt1-throughput-decreased label

added 1 commit

• 8c2a8e94 - revert deterministic PVs histos

Compare with previous version

added hlt1-throughput-decreased label

added 1 commit

• 904e2a1c - remove comment

Compare with previous version

removed hlt1-throughput-decreased label

marked this merge request as ready

changed title from Draft: Sandrese improve lumi counters to improve lumi counters

changed the description

added hlt1-throughput-decreased label

Throughput failures are because the pipeline is still pointing to master (there's an open MR to fix this that I need to work on a bit: !1568 (merged)) . I think after MooreOnline!395 (merged) is merged, we can launch a ci with the recent MooreOnline throughput test of @raaij to check the actual throughput improvement on real data :)

changed milestone to %v4r8

mentioned in merge request !1461 (merged)

changed milestone to %RTA/2024.05.06-MayMD

assigned to @jonrob

removed hlt1-throughput-decreased label

added 36 commits

• 904e2a1c...011a2707 - 25 commits from branch 2024-patches
• cbdc4b14 - 1 earlier commit
• 8d7ca66d - Fixed formatting
• e61e3bbd - add needed sync after setting shared memory
• ac09122f - fix shared memory initialization
• 357d1a91 - deterministic behaviour on calo lumi counters
• 40277efd - sort obtained PVs
• 7c6ab519 - ensure deterministic behaviour on histogram
• 337bec6c - Fixed formatting
• 6e15143d - fix warnings
• dfa1b759 - revert deterministic PVs histos
• b5b8ce38 - remove comment

Compare with previous version

added Luminosity label

• [2024-05-03 21:03] Validation started with lhcb-2024-patches-mr#360

resolved all threads

mentioned in commit 346b63d2

mentioned in merge request !1617 (closed)

mentioned in commit Moore@6d526890

mentioned in commit DaVinci@631bc6f3

mentioned in merge request Moore!3409 (closed)

mentioned in commit MooreOnline@c9ea81fa

mentioned in merge request DaVinci!1088 (closed)

mentioned in merge request MooreOnline!427 (merged)

mentioned in commit MooreOnline@584a8629

mentioned in commit 22240443

merged

mentioned in commit MooreOnline@4c7c7469

mentioned in commit MooreOnline@01042be9

mentioned in commit MooreOnline@4dda79ca

mentioned in merge request !1628