Enabled UTError Decoding
This MR will enable UTError
decoding. I've written a two dumpers for UT hits (one for Allen and one for Rec) and added a python checker on the dumped JSON file. This is how I verified that UTError
in Allen was working as expected.
I tested on the first 1000 events in the MEP file /calib/online/MEP_dumps_18_04_24/bu_290819_LHCb_ECEB01_BU_0.mep
taken last week. I verified that Allen is able to decode UTError
. When UTError
is not enabled, I get (disappears when Allen decodes UTError
)
Event 250 Layer 0
Printing UT hits that do not match between <Rec> and <Allen>
+-------+-------------+-------------+-------------+-------------+-------------+-------------+
| Tag | LHCbID | xAtYEq0 | yBegin | yEnd | zAtYEq0 | weight |
+-------+-------------+-------------+-------------+-------------+-------------+-------------+
| Rec | 809517489 | -108.0324 | -574.7568 | -477.3575 | 2321.8464 | 341.3333 |
| Rec | 809518444 | -122.6395 | -383.3716 | -285.9717 | 2321.8464 | 341.3333 |
| Rec | 809520021 | -105.1328 | -192.3664 | -94.9671 | 2321.8464 | 1372.6443 |
+-------+-------------+-------------+-------------+-------------+-------------+-------------+
Event 824 Layer 2
Printing UT hits that do not match between <Rec> and <Allen>
+-------+-------------+------------+------------+------------+-------------+------------+
| Tag | LHCbID | xAtYEq0 | yBegin | yEnd | zAtYEq0 | weight |
+-------+-------------+------------+------------+------------+-------------+------------+
| Rec | 811211080 | 828.6338 | 381.2408 | 478.2701 | 2608.1536 | 341.3333 |
| Rec | 811218297 | 791.8853 | 92.3592 | 189.3959 | 2601.8464 | 341.3333 |
| Rec | 811220474 | 767.4471 | 471.1706 | 568.2047 | 2601.8464 | 341.3333 |
+-------+-------------+------------+------------+------------+-------------+------------+
These are the exact same hits I see when running Allen-vs-Rec UT hits comparison script with Allen-in-Moore (which cannot decode UTError
).
CompareRecAllenUTHits_740447bf INFO ------------------------------------------------------------------------------------------------
CompareRecAllenUTHits_740447bf INFO Printing Allen and Rec hits that are not matched
CompareRecAllenUTHits_740447bf INFO Type LHCbID xAtYEq0 yBegin yEnd zAtYEq0 weight
CompareRecAllenUTHits_740447bf INFO Rec 809517489 -108.032 -574.757 -477.358 2321.85 341.333
CompareRecAllenUTHits_740447bf INFO Rec 809518444 -122.64 -383.372 -285.972 2321.85 341.333
CompareRecAllenUTHits_740447bf INFO Rec 809520021 -105.133 -192.366 -94.9671 2321.85 1372.64
CompareRecAllenUTHits_740447bf INFO ------------------------------------------------------------------------------------------------
CompareRecAllenUTHits_740447bf INFO Printing Allen and Rec hits that are not matched
CompareRecAllenUTHits_740447bf INFO Type LHCbID xAtYEq0 yBegin yEnd zAtYEq0 weight
CompareRecAllenUTHits_740447bf INFO Rec 811211080 828.634 381.241 478.27 2608.15 341.333
CompareRecAllenUTHits_740447bf INFO Rec 811218297 791.885 92.3592 189.396 2601.85 341.333
CompareRecAllenUTHits_740447bf INFO Rec 811220474 767.447 471.171 568.205 2601.85 341.333
CompareRecAllenUTHits_740447bf INFO ------------------------------------------------------------------------------------------------
Merge request reports
Activity
assigned to @raaij
added 113 commits
-
c5631087...545d2b00 - 98 commits from branch
dtou_ut_clustering
- 545d2b00...da603e68 - 5 earlier commits
- 0d3afebe - Updated DumpRecUTHits.cpp
- 639acc3a - Updated UT hits dumping for Rec.
- 5f8be864 - Added python script to compare dumps between two JSON files.
- 587cad7e - Fixed typo.
- db5f3ff5 - Renamed JSON dump of UT hits.
- 7c3c2610 - Fixed Rec dumper.
- 1843cf4f - Added fix to avoid UT hits checking script from going out of bounds.
- d4e6b83f - Enabled UTError decoding in Allen.
- e91b70dc - Cleaned up UTError decoding.
- ca81285e - Fixed compilation errors.
Toggle commit list-
c5631087...545d2b00 - 98 commits from branch
- Resolved by Roel Aaij
I would like to avoid adding additional dumpers to custom formats to the codebase. If we don't manage to fix things to allow checking this with the Allen-in-Moore comparison test then they can stay for the moment, but they should be removed as soon as that works.