Fix out-of-bounds access in ErrorBankFilter

With the UT included we started getting bank type 100 which is currently LastType and is not handled correctly.

Test with LHCb!4486 (merged) Lbcom!730 (merged) MooreOnline!372 (merged) !1514 (merged)

/cc @raaij @cagapopo

added bug fix impactlow priorityhigh rta-hotfix labels

added RTA label

Thanks for fixing this!

There are small changes in physics efficiency for the downstream sequences, see the full log here.

Is an effect on MC samples expected?

resolved all threads

added 7 commits

• 895c5880...9043f456 - 6 commits from branch 2024-patches
• 24b83657 - Fix out-of-bounds access in ErrorBankFilter

Compare with previous version

added hlt1-throughput-decreased label

assigned to @palaguar

mentioned in issue Moore#768 (closed)

removed hlt1-throughput-decreased label

assigned to @chenjia and unassigned @palaguar

changed the description

mentioned in issue Moore#776 (closed)

added 9 commits

• 24b83657...0ce4ee83 - 8 commits from branch 2024-patches
• 4012e452 - Fix out-of-bounds access in ErrorBankFilter

Compare with previous version

resolved all threads

@chenjia, @msaur this is a hotfix, so already used in production. I would propose to run a ci-test when resources allow and then merge as soon as convenient. I don't expect a ref-update is needed.

changed the description

/ci-test LHCb!4486 (merged) Lbcom!730 (merged) MooreOnline!372 (merged)

resolved all threads

added ci-test-triggered label