[ErroBankFilter] Add protection against unexpected bank types

In a MEP saved by the error saver task from run 299878 the 1st event contains a bank that comes from the UT A-side (source ID 10292) that has as bank type 64/FTCluster. This unexpected type resulted in a segfault in the error bank filter. This MR protects against that.

The MEP can be found here on eos: /eos/lhcb/wg/rta/data/jun_2024_mep/Error_0000299878_ECEB01_20240702-145545-173.0010.mep

I've also created an MDF file that contains this event as the first event (and 499 others): /eos/lhcb/wg/rta/data/jun_2024_mdf/Error_299878_ut_ftcluster_type_bank.mdf Please note that since all HLT2 decoders request banks by their type, the faulty bank will show up as an extra bank in the SciFi decoding.

Closes #565 (closed)

added bug fix label

assigned to @cagapopo

changed the description

added RTA label

changed milestone to %RTA/2024.08.12-AugMD

Hey @raaij many thanks for finding this! Could you add in the MR description the underlying issue with the input, as well as the exact MEP where you found it?

In principle it would be good to keep track of the "impossible" cases too, such as a non-UT bank type from a UT source id, including even bank types >= LastType (e.g. I've seen 255 coming out). A simple histogram of all the possible bank type values (0..255) per subdetector should be enough.

@msaur @cagapopo it's true that this crash is not seen often but perhaps we shouldn't wait for August. Can we get it in the next release (or even hot fix the stack)?

added backport RTA/2024.06.03 label

/ci-test

added ci-test-triggered label

• [2024-07-04 13:59] Validation started with lhcb-2024-patches-mr#944
• [2024-07-05 11:08] Validation started with lhcb-2024-patches-mr#958

added rta-hotfix label

changed the description

added 1 commit

• ff5cb3be - [ErrorBankFilter] Add histogram per SD of unexpected banks

Compare with previous version

For the hotfix that we are planning to apply today, probably it's better to just cherry-pick only the first commit @oozcelik given that the second one is quite larger and should probably go through more thorough testing.

added 1 commit

• 88e64aad - [ErrorBankFilter] Add histogram per SD of unexpected banks

Compare with previous version

/ci-test

resolved all threads

merged

mentioned in commit b164d7ac

mentioned in merge request !1668 (merged)