avoid spurious implicit copy of MCVertex
All threads resolved!
All threads resolved!
Due to mistake in MCVertex, it is possible to assign a LHCb::MCVertex const* to a LHCb::MCVertex const& by making an implicit(!) temporary MCVertex. This MR avoids the copy.
Note: LHCb!4843 (merged) will remove this implicit conversion, and hence this MR must either be merged prior to, or together with, LHCb!4843 (merged)
Edited by Gerhard Raven
Merge request reports
Activity
added bug fix label
assigned to @graven
mentioned in merge request LHCb!4843 (merged)
added RTA label
- [2024-12-21 08:44] Validation started with lhcb-master-mr#12138
mentioned in issue Moore#896 (closed)
- Resolved by Dorothea Vom Bruch
Originally there was efficiency drop on 2080Ti, after rerunning it was some fluctuation (as expected).
FYI @dovombru @cagapopo @jzhuo
Reference : test/reference/Beam2680GeV-expected-2024-MagDown-nu3.5_MinBiasMD_hlt1_pp_ref_forward_then_matching_validation_geforcertx2080ti.txt --- /builds/lhcb/Allen/test/reference/Beam2680GeV-expected-2024-MagDown-nu3.5_MinBiasMD_hlt1_pp_ref_forward_then_matching_validation_geforcertx2080ti.txt 2024-12-24 07:44:17.083701220 +0100 +++ efficiency_Beam2680GeV-expected-2024-MagDown-nu3.5_MinBiasMD_hlt1_pp_ref_forward_then_matching_validation_geforcertx2080ti.txt 2024-12-24 07:44:22.902758337 +0100 @@ -22,9 +22,9 @@ long_validator validation: -TrackChecker output : 439/ 19065 2.30% ghosts -for P>3GeV,Pt>0.5GeV : 90/ 8841 1.02% ghosts -01_long : 17195/ 23081 74.50% ( 74.62%), 313 ( 1.79%) clones, pur 99.56%, hit eff 99.03% +TrackChecker output : 439/ 19064 2.30% ghosts +for P>3GeV,Pt>0.5GeV : 90/ 8840 1.02% ghosts +01_long : 17194/ 23081 74.49% ( 74.61%), 313 ( 1.79%) clones, pur 99.56%, hit eff 99.03% -18_long_nSciFiHits_gt_0_AND_lt_5000 : 17480/ 24328 71.85% ( 72.19%), 330 ( 1.85%) clones, pur 99.53%, hit eff 99.04% +18_long_nSciFiHits_gt_0_AND_lt_5000 : 17479/ 24328 71.85% ( 72.19%), 330 ( 1.85%) clones, pur 99.53%, hit eff 99.04% muon_validator validation: -Muon fraction in MCPs to which a track(s) was matched: 196/ 21529 0.01% +Muon fraction in MCPs to which a track(s) was matched: 196/ 21528 0.01% -Tracks identified as muon with isMuon, but matched to non-muon MCP: 869/ 21333 4.07% +Tracks identified as muon with isMuon, but matched to non-muon MCP: 869/ 21332 4.07% @@ -136,16 +136,16 @@ seed_validator validation: -TrackChecker output : 87/ 16031 0.54% ghosts +TrackChecker output : 87/ 16030 0.54% ghosts for P>3GeV,Pt>0.5GeV : 0/ 0 -nan% ghosts -00_P>3Gev_Pt>0.5 : 713/ 8970 7.95% ( 7.00%), 4 ( 0.56%) clones, pur 99.64%, hit eff 97.75% -01_long : 6153/ 23081 26.66% ( 27.88%), 18 ( 0.29%) clones, pur 99.82%, hit eff 98.44% +00_P>3Gev_Pt>0.5 : 712/ 8970 7.94% ( 6.99%), 4 ( 0.56%) clones, pur 99.64%, hit eff 97.74% +01_long : 6152/ 23081 26.65% ( 27.88%), 18 ( 0.29%) clones, pur 99.82%, hit eff 98.44% ---1. phi quadrant : 1501/ 5693 26.37% ( 27.72%), 5 ( 0.33%) clones, pur 99.88%, hit eff 98.50% ---2. phi quadrant : 1570/ 5788 27.13% ( 27.79%), 4 ( 0.25%) clones, pur 99.76%, hit eff 98.52% ---3. phi quadrant : 1559/ 5886 26.49% ( 27.99%), 4 ( 0.26%) clones, pur 99.80%, hit eff 98.30% ----4. phi quadrant : 1523/ 5714 26.65% ( 27.44%), 5 ( 0.33%) clones, pur 99.84%, hit eff 98.44% +---4. phi quadrant : 1522/ 5714 26.64% ( 27.42%), 5 ( 0.33%) clones, pur 99.84%, hit eff 98.44% ---eta < 2.5, small x, large y : 31/ 929 3.34% ( 3.02%), 0 ( 0.00%) clones, pur 99.35%, hit eff 95.70% ----eta < 2.5, large x, small y : 187/ 1559 11.99% ( 10.22%), 2 ( 1.06%) clones, pur 99.46%, hit eff 96.18% +---eta < 2.5, large x, small y : 186/ 1559 11.93% ( 10.19%), 2 ( 1.06%) clones, pur 99.46%, hit eff 96.16% ---eta > 2.5, small x, large y : 1993/ 7461 26.71% ( 28.18%), 4 ( 0.20%) clones, pur 99.86%, hit eff 98.58% ---eta > 2.5, large x, small y : 3942/ 13132 30.02% ( 31.61%), 12 ( 0.30%) clones, pur 99.82%, hit eff 98.50% 02_long_P>5GeV : 3791/ 14278 26.55% ( 28.41%), 12 ( 0.32%) clones, pur 99.82%, hit eff 98.59% @@ -154,8 +154,8 @@ ---eta < 2.5, large x, small y : 66/ 393 16.79% ( 16.77%), 0 ( 0.00%) clones, pur 100.00%, hit eff 98.79% ---eta > 2.5, small x, large y : 1303/ 5052 25.79% ( 27.54%), 3 ( 0.23%) clones, pur 99.88%, hit eff 98.72% ---eta > 2.5, large x, small y : 2398/ 8619 27.82% ( 29.86%), 9 ( 0.37%) clones, pur 99.78%, hit eff 98.52% -03_long_P>3GeV : 6150/ 19350 31.78% ( 33.40%), 18 ( 0.29%) clones, pur 99.82%, hit eff 98.44% -04_long_P>0.5GeV : 6153/ 23081 26.66% ( 27.88%), 18 ( 0.29%) clones, pur 99.82%, hit eff 98.44% +03_long_P>3GeV : 6149/ 19350 31.78% ( 33.40%), 18 ( 0.29%) clones, pur 99.82%, hit eff 98.44% +04_long_P>0.5GeV : 6152/ 23081 26.65% ( 27.88%), 18 ( 0.29%) clones, pur 99.82%, hit eff 98.44% -35_long_nSciFiHits_gt_0_AND_lt_5000 : 7655/ 26080 29.35% ( 30.77%), 25 ( 0.33%) clones, pur 99.82%, hit eff 98.41% +35_long_nSciFiHits_gt_0_AND_lt_5000 : 7654/ 26080 29.35% ( 30.77%), 25 ( 0.33%) clones, pur 99.82%, hit eff 98.41% - Last reply by Jiahui Zhuo
mentioned in commit cc4cca74
mentioned in issue #568 (closed)
Please register or sign in to reply