Draft: Convert cmake include directories into target include directories

This MR intends to remove all the mess of include_directories in Allen and substitute it by introducing some INTERFACE libraries and including directories with the directive target_include_directories.

@raaij I assigned you as I would like to know your opinion on the ongoing modifications in this MR before I go any further. So far, I have converted the Velo, UT and SciFi cmakelists into using target_include_directories. I have also added some INTERFACE libraries such as EventModel, Backend and Gear, which are used in several places as needed.

It was also necessary to move around a couple of definitions files to the EventModel INTERFACE, so that somewhat convoluted requirements disappear (eg. UT does not need any include directories from the Velo, but only its EventModel; the same goes for SciFi and previous tracking detectors).

This looks like the way to go to me. Disentangling the event model is the right approach there.

So I went ahead and "did the thing" for all of Allen. Rec/Allen/CMakeLists.txt has not been updated, but it should be pretty easy to do now that libraries and interfaces are kind of well-behaved. I would be happy to hand that to someone else.

If Rec/Allen/CMakeLists.txt is the only missing piece, I think we should adapt it soon and get this merged before there are too many other changes. Since you did all of the remaining refactoring, would you mind adapting Rec/Allen/CMakeLists.txt as well @dcampora ?

Unfortunately the remaining work here is also on refactoring which admittedly will take some considerable time, and I am not sure I can do it anytime soon.

I've rebased the MR and fixed the stack build (Rec/Allen), I think this is ready for another look.

Some refactoring was needed as a result of the move of the checkers to the sequence through the validator algorithms. I added a HostEventModel library that contains the various MC classes to deal with this issue.

added 2 commits

• f73ac2dd - Remove include_directories from muon/CMakeLists.txt
• 970446bc - Converted all CMakeLists include_directories into target_include_directories.

Compare with previous version

added 1 commit

• d6cefc36 - Unified Boost memory requirement. Fixed compilation with CUDA.

Compare with previous version

added Build label

added 2 commits

• 6b93e84a - Fixed formatting
• f91e496b - Added copyright to missing files.

Compare with previous version

marked this merge request as ready

changed title from Draft: First prototype that converts cmake include directories into target include directories. to Convert cmake include directories into target include directories

added 1 commit

• 589904aa - Fixed HIP backend too.

Compare with previous version

@dcampora Please look at the pipeline test results. The build check is failing and needs to be addressed.

Please assign me (software shifter until Feb 28) when it is ready to test.

@dcampora let me know when pipeline build check is addressed, and assign me (until Mar 14th) when this MR ready to be tested.

Hi @dcampora, please assign me when it is ready to be tested again. I'll be on shift until March 28.

marked this merge request as draft

mentioned in issue Moore#263 (closed)

mentioned in merge request !552 (merged)

added 272 commits

• 589904aa...5a3b1ace - 262 commits from branch master
• ff92ed85 - First prototype that converts cmake include directories into target include directories.
• 19d74b8a - Remove include_directories from muon/CMakeLists.txt
• 0382ed8d - Converted all CMakeLists include_directories into target_include_directories.
• 36255100 - Unified Boost memory requirement. Fixed compilation with CUDA.
• cedde0a7 - Fixed formatting
• 901f1660 - Added copyright to missing files.
• 0130b72e - Fixed HIP backend too.
• a8009a23 - Remove leftover file
• 3bc43caf - inline some methods
• 911e5007 - Fix stack build

Compare with previous version

added 6 commits

• ee2c006b - Fixed formatting
• aa563057 - Added copyright to missing files.
• 388f97be - Fixed HIP backend too.
• bcccca9e - Remove leftover file
• f1731887 - inline some methods
• e5d65103 - Fix stack build

Compare with previous version

added 1 commit

• 68abdadd - Add Catch2 again

Compare with previous version

mentioned in issue Moore#272 (closed)