Skip to content
Snippets Groups Projects

Refactor selections source directory structure

Merged Dorothea Vom Bruch requested to merge dovombru_selections_source_directory_structure into master

This MR groups HLT1 selections defined in device/selections/lines into sub-directories based on the physics of the selections. The names are chosen to match those of the python configuration files introduced in !429 (merged). The selections readme was updated to reflect the changed directory structure.

Merge request reports

Approval is optional

Merged by Rosen MatevRosen Matev 4 years ago (Apr 20, 2021 1:32pm UTC)

Merge details

  • Changes merged into master with 1220e076.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

    • Resolved by Dorothea Vom Bruch

      "technical" means very little, even to those that know the historical usage.

      Lines are used for

      1. physics
      2. calibration (incl. alignment)
      3. monitoring (e.g. velo closing)

      I suggest to rename "alignment" to "calibration", "technical" to "monitoring" and move the passthrough line to "calibration" (as presumably this is the main use of that one)

  • added 1 commit

    • b379986f - rename alignment -> calibration, technical -> monitoring, move Passthrough line to calibration

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Dorothea Vom Bruch resolved all threads

    resolved all threads

  • added 2 commits

    • 96602233 - fix build
    • 4a1287c0 - Merge branch 'dovombru_selections_source_directory_structure' of...

    Compare with previous version

  • assigned to @msaur

  • Edited by Software for LHCb
  • mentioned in issue Moore#265 (closed)

  • added 1 commit

    • 7293cf52 - update pregenerated sequences

    Compare with previous version

  • Miroslav Saur assigned to @jbaptist and unassigned @msaur

    assigned to @jbaptist and unassigned @msaur

  • added 43 commits

    • 7293cf52...523e01a2 - 36 commits from branch master
    • c6e78bc2 - create directory structure in device/selections/lines according to the line...
    • 38ab7f67 - Update selections.md
    • a22a00b9 - remove unnecessary include
    • b47e250d - rename alignment -> calibration, technical -> monitoring, move Passthrough line to calibration
    • 3bb60846 - fix build
    • 6a598c99 - Update selections.md
    • 68f2922c - update pregenerated sequences

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading