SMOG2 trigger lines and prefilters
Implementation of core SMOG2 HLT1 trigger lines and filters (documentation in this twiki)
TODO: Following an old discussion with Alex, who was against trigger lines outputting a mask (breaking the requirement of independency among lines), I implemented as filters the selections outputting a mask. Is this changed now? (resolved in this comment )
Implemented filters:
- CheckPV: filters events with a PV in a z range, to switch off SMOG2 lines for events with only pp collisions (and vice versa, as can be relevant for PbPb + PbSMOG2 datasets)
- LowMult: filters events with a reconstructed number of Velo tracks in a range, to allow (e.g.) CEP physics lines implementation
- BeamCrossingType: filters a given beam crossing type, to be combined with the previous one to measure the SMOG2 lumi via p-e elastic scattering (closes Allen/#225)
Implemented SMOG2 lines:
- SMOG2_MinimumBiasLine: triggers on VELO tracks from the SMOG2 region and with a minimum number of VELO hits. It is required for astrophysics-motivated measurements + efficiency checks (will be prefiltered)
- SMOG2_DiMuonHighMass: triggers on dimuon signatures, required for charm measurements
- SMOG2_DiTrack: triggering on ditrack signatures, instantiated for D0 -> Kpi, eta ->pp and generic
- SMOG2_SingleTrack: generic high-pT signature
To cope with the possible simultaneous data-taking, all SMOG2 lines require the triggering object to be in the SMOG2 region. On pp lines, I applied requirements asking the triggering object to be and/or to be associated to a PV not in the SMOG2 region. This rejects the SMOG2 contamination (yet minor, considering the lower SMOG2 energy and collision rate).
Branch tested with pipeline 3979399. Only failing steps are:
- physics_efficiency, where:
- all physics lines keep the same rate, which demonstrates the requirements of objects not coming from SMOG2 are fully efficient;
- monitoring and HighPtMuNoID lines can change by a unit because of the different hashing string, affecting the postscaling
- physics_efficiency_full tests fail as expected (numbers of SMOG2 events accepted from pp lines go to zero)
Supersedes Allen/!520 (closed) (TODO: clean old branches)
With respect to the configuration:
- The default sequences only allowed the gec filter to be applied to lines. To cope with more complex prefiltering strategies, the make_line_composite_node_with_gec and the line_maker functions are replaced to accept no, a single or a list of prefilter algorithms (and are moved to utils to be shared between HLT1 and HLT1_no_calo);
- Line definition functions (like default_physics_lines and monitoring_lines) only define the lines, the upstream prefiltering is applied with a bind to line_maker
- Line names and hashing strings include the applied prefilters
cc @ggrazian
Merge request reports
Activity
mentioned in merge request !520 (closed)
From a first look at how prefilters are applied to lines, this looks good to me. I will take a look at the lines themselves later.
FYI @thboettc @nnolte @spradlin this is slightly related to the topic we are discussing with the prefilters for the SelReports. However, in this use case, the downstream algorithms of the prefilters only ingest filtered events.
added 1 commit
added RTA label
added 464 commits
-
4e363edd...f4cb46e4 - 455 commits from branch
master
- 7a53224c - Add SMOG2 lines and prefilters
- 00f3b6c8 - Clean
- 50625d5c - Fixed formatting
- 6cc5d787 - Fix failing sequences according to Pipeline #2780221
- 02db06f3 - Clean MB line
- dfdb246d - Clean SMOG2 lines
- 217c6bc1 - Clean HLT1.py
- a8a3ae7c - temporarily removed gitlab-ci.yml; please cherry-pick commits 06353b3f...
- da778c43 - Rebase on master
Toggle commit list-
4e363edd...f4cb46e4 - 455 commits from branch
added 73 commits
-
da778c43...6bf2aa95 - 64 commits from branch
master
- bb3b2f6d - Add SMOG2 lines and prefilters
- 7d775237 - Clean
- 7b9a0f79 - Fixed formatting
- 8bc11312 - Fix failing sequences according to Pipeline #2780221
- 026e7f03 - Clean MB line
- 870c633c - Clean SMOG2 lines
- 20f5fa00 - Clean HLT1.py
- 46c34ece - temporarily removed gitlab-ci.yml; please cherry-pick commits 06353b3f...
- 6e2ca992 - Rebase on master
Toggle commit list-
da778c43...6bf2aa95 - 64 commits from branch
added 2 commits
added 187 commits
-
7f39c2ff...78aa1b70 - 176 commits from branch
master
- dc870b42 - Add SMOG2 lines and prefilters
- 31a8b796 - Clean
- 69988abd - Fixed formatting
- 4cb9aa04 - Fix failing sequences according to Pipeline #2780221
- c9f07db3 - Clean MB line
- 8f55577f - Clean SMOG2 lines
- 851e2a11 - Clean HLT1.py
- 1d28e677 - temporarily removed gitlab-ci.yml; please cherry-pick commits 06353b3f...
- f6cc1cd4 - Rebase on master
- 4f3adbab - Restore filter functionalities
- a5d25fce - Restore SMOG2 lines functionality
Toggle commit list-
7f39c2ff...78aa1b70 - 176 commits from branch
added 1 commit
- 0851f804 - Adapt sequences to updated line_maker to solve failing build tests
- A deleted user
added hlt1-throughput-decreased label
added 2 commits
added 1 commit
- cfb76551 - Avoid output_event_list copy to host to mitigate throughput decreasing