Skip to content
Snippets Groups Projects

Fix out-of-bounds access in UT rawbank v3

Merged Roel Aaij requested to merge fix_ut_asan_error into master

Merge request reports

Merged by Christoph HasseChristoph Hasse 3 years ago (Sep 24, 2021 11:34am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good to me. Thanks also for the refactoring! It certainly makes maintenance easier.

  • Marian Stahl removed review request for @mstahl

    removed review request for @mstahl

  • assigned to @raaij and unassigned @dcampora

  • Roel Aaij added 1 commit

    added 1 commit

    Compare with previous version

  • Roel Aaij resolved all threads

    resolved all threads

  • assigned to @msaur

  • @raaij Could you fix pipelines before ci-test?

  • Roel Aaij added 2 commits

    added 2 commits

    Compare with previous version

  • added lhcb-head label

  • Roel Aaij added 1 commit

    added 1 commit

    • cec77a9a - character array must be 0-byte terminated

    Compare with previous version

  • removed lhcb-head label

  • lhcb-head looks quite well, errors in Moore and Brunel are only various timeouts, however one timeout concerns me, namely RecoConf decoding hlt1_ut_decoding_v4r2 unexpected timeout on x86_64_v2-centos7-gcc10-opt. But that error is just in one platforms, so probably fine.

    @chasse What do you think? Other than that, this MR seems ready to be merged.

  • assigned to @chasse

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading