Fix issues with ROOTService

@dovombru and I had the some idea as clear from !728 (closed). I went a bit further and refactored the ROOTService to only open ROOT files once and write TTrees once at the end instead of for each batch of events.

In addition, a property has been added to disable the tree writing by default in the KsToPiPi and RICH1Calibration lines. For the stack/production builds ROOT will always enabled and making tuples should not be enabled.

To avoid a crash in the SVMonitor it has been disabled. That monitoring code needs to anyway be migrated to a dedicated monitoring algorithm to properly take into account event masks.

FYI @acasaisv @rilane

Closes #289 (closed)

requested review from @dovombru

requested review from @raaij and removed review request for @dovombru

removed review request for @raaij

assigned to @raaij

added 2 commits

• 6e3f64d2 - Improve ROOTService
• 3eaa7077 - Disable SVMonitor

Compare with previous version

added RTA label

assigned to @abrearod

added 1 commit

• c4e75aa5 - Fix call to finalize

Compare with previous version

mentioned in merge request !728 (closed)

mentioned in issue Moore#362 (closed)

added hlt1-throughput-decreased label

added 1 commit

• 27b4349b - Refactor to use the same monitoring file everywhere except the checkers

Compare with previous version

removed hlt1-throughput-decreased label

added 1 commit

• aa188852 - Fix stack build

Compare with previous version

added 1 commit

• 885d6ee2 - Fix build without ROOT

Compare with previous version

added 1 commit

• 39d2e9b6 - Fix stack build and build without ROOT

Compare with previous version

added hlt1-throughput-decreased label

/ci-test

assigned to @rmatev and unassigned @raaij and @abrearod

added ci-test-triggered label

• [2021-12-20 15:13] Validation started with lhcb-master-mr#3381
• [2022-01-10 19:57] Validation started with lhcb-master-mr#3411

removed hlt1-throughput-decreased label

added hlt1-throughput-decreased label

removed hlt1-throughput-decreased label

added hlt1-throughput-decreased label

removed hlt1-throughput-decreased label

@raaij could you rebase on master, which should hopefully fix the pipeline?

added 14 commits

• 39d2e9b6...a0a50ced - 9 commits from branch master
• b083a70c - Improve ROOTService
• 2852fe5e - Disable SVMonitor
• 0b7177de - Fix call to finalize
• 7f489ea8 - Refactor to use the same monitoring file everywhere except the checkers
• 7f7ae742 - Fix stack build and build without ROOT

Compare with previous version

Looks like the pipeline was green before the rebase, but I've done it anyway. This is ready for ci-test.

thanks! The last test was already okay but let's give it a final spin

/ci-test

added hlt1-throughput-decreased label

Some throughput results are low, but only for some sequences. I think this is again a case of unstable tests.

removed hlt1-throughput-decreased label

resolved all threads

added Monitoring bug fix hlt1-throughput-decreased labels

merged

mentioned in commit 501ae5a5

changed the description

mentioned in issue #289 (closed)

mentioned in issue Moore#375 (closed)

mentioned in issue Moore#377 (closed)