Better JSON parsing, simpler new type support
This MR provides much better property parsing.
- Use proper python - json - C++ types when parsing, with nlohmann::json functionality.
-
nlohmann::json
natively supports a richer variety of types than the previous custom-made translations: https://json.nlohmann.me/features/types/ - Supporting new types in JSON can be done by adding a
to_json
andfrom_json
in case the types are not known to nlohmann::json. This MR only introduces one such conversion for typeBankTypes
. - Generated json files with
--write-config
are now reusable as input files. - Properties should now be supplied with their proper type in python configurations as opposed to "always string".
Closes #179 (closed)
Required for #305 (closed)
Edited by Daniel Hugo Campora Perez
Merge request reports
Activity
mentioned in issue #305 (closed)
added RTA label
- Resolved by Roel Aaij
Gaudi has a very powerful parser included as part of
GaudiKernel
, which we already depend on even for the standalone build. Instead maintaining something separate - usingjson
with added things where it's not sufficient - I think it would be worth a try to see if the Gaudi parsers can be used.
added 1 commit
- 9acec088 - Remove all to_string conversions and use nlohmann::json to dump instead.
added enhancement label
- A deleted user
added hlt1-throughput-decreased label
assigned to @msaur
removed hlt1-throughput-decreased label
- A deleted user
added hlt1-throughput-decreased label
added 18 commits
-
7ba390be...0b12a15d - 14 commits from branch
master
- 27dd0730 - Better JSON parsing, ease to support new types in properties.
- d5a6e87c - Fixed formatting
- 20b65dc7 - Remove all to_string conversions and use nlohmann::json to dump instead.
- 068d9319 - Fix remaining configuration issues.
Toggle commit list-
7ba390be...0b12a15d - 14 commits from branch
removed hlt1-throughput-decreased label
- Resolved by Daniel Hugo Campora Perez
/ci-test
Please register or sign in to reply