Throw an exception if required RawBank is not present

Throw an exception if a RawBank is not present, instead of seg-faulting because some later algorithms do not have the required input.

This should be tested with Moore!1429 (merged), LHCb!3456 (closed) and lhcb-datapkg/PRConfig!217 (merged).

added RTA label

mentioned in merge request LHCb!3456 (closed)

mentioned in merge request Moore!1429 (merged)

changed the description

added 1 commit

• 5c050832 - Fixed formatting

Compare with previous version

Hi @dovombru, @dcampora, @raaij, as suggested in #294 (closed), I have created this MR, Moore!1429 (merged) and LHCb!3456 (closed) to introduce some checks requiring that all the banks needed by the sequence are present.
Currently the VPRetinaCluster RawBank has been added to the input_raw_format = 0.5. I made the rawbank_list input of the make_transposed_raw_banks function configurable in Moore!1429 (merged), so that it can be changed by the user if a different input_raw_format is used (for example 4.3 when running MooreAnalysis).
If a RawBank is not present in the Raw_location_db an error is raised with LHCb!3456 (closed).
I also changed TransposeRawBanks in order to throw an exception if a required RawBank is not present.

Can you please have a look and tell me if the changes I implemented are ok?
Currently TransposeRawBanks has a list of required RawBanks specified with a private Gaudi::Property, would it be possible to make this list configurable by the user? In that case a user can run on a sample not including RetinaClusters and specifying an input_raw_format different from 0.5.

mentioned in issue #294 (closed)

assigned to @msaur and @gbassi

Hello @gbassi, can I test this or better to wait for a review?

added 3 commits

• 5c050832...2494b789 - 2 commits from branch master
• ead1d00c - raise an error if a RawBank is not found in RawEvent

Compare with previous version

changed the description

added ci-test-triggered label

• [2022-03-13 19:15] Validation started with lhcb-master-mr#3958
• [2022-03-14 11:42] Validation started with lhcb-master-mr#3967

added 4 commits

• ead1d00c...3fcda761 - 2 commits from branch master
• e3dc73dd - raise an error if a RawBank is not found in RawEvent
• 8c5b28a4 - remove unused this

Compare with previous version

changed the description

mentioned in merge request lhcb-datapkg/PRConfig!217 (merged)

approved this merge request

added 1 commit

• 06aff3d5 - update docs with input DIGI with RetinaClusters and instructions on how to run...

Compare with previous version

added 9 commits

• 06aff3d5...a3e77c85 - 7 commits from branch master
• 9df1f649 - raise an error if a RawBank is not found in RawEvent
• df6e901a - update docs with input DIGI with RetinaClusters and instructions on how to run...

Compare with previous version

If there are no additional comments, can we proceed with merge or additional tests are required?