Draft: Muon standalone reconstruction and MatchVeloMuon

This MR introduces the following reconstruction algorithms:

• FindMuonHits
• FitMuon
• MatchVeloMuon

The first two are devoted to reconstructing MuonTracks from the hits left at the muon stations. The first step looks for muon hits following some search windows and the second fits these hits to line both in ZX and ZY planes. At this stage it might be worth to merge this two algorithms since the best way to apply the clone killing involves using the same fit as it is used to obtain the slopes.

The last algorithm matches VELO tracks to MuonTracks using a chi2 type of metric, following the strategy started in !742 (merged).

The momentum resolution for this types of tracks is ~40% which also encapsulates to some exten the misID of the algorithm, looking at it from muonID algorithm.

Running on a Bs2MuMu sample these is the best performance obtained:

velo_tracks_muon validation:
Muon fraction in all MCPs:                                              56445/  3919389   0.01%
Muon fraction in MCPs to which a track(s) was matched:                   9367/   885491   0.01%
Correctly identified muons with isMuon:                                  4343/     9367  46.36%
Correctly identified muons from strange decays with isMuon:                 0/       27   0.00%
Correctly identified muons from B decays with isMuon:                    4286/     7926  54.08%
Tracks identified as muon with isMuon, but matched to non-muon MCP:      9672/   876124   1.10%
Ghost tracks identified as muon with isMuon:                              276/    33129   0.83%

fyi: @dcampora @gligorov

added RTA label

mentioned in issue Moore#426 (closed)

added 60 commits

• fbaaad01...0f0ba4e2 - 25 commits from branch master
• 7547be94 - MatchVeloMuon first version
• 43263c00 - Refactored quite a bit the code with extreme programming.
• 86006505 - Fix bug.
• 760e5ea4 - Added second loop over M4, also added flagging to avoid clone tracks
• 1358a342 - Succesful use of shared memory for flagging hits
• 499fac57 - All to shared memory, no improvement though
• d0bef4b3 - Removed second loop and changed seeding
• 28a9322f - Added all possible cases
• ec06875f - First implementation of clone removal.
• fff57c5e - Add FitMuon first trial
• 3ef31dc8 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 2bcf2734 - First step towards checkers
• 3b506083 - Velo validation
• af32dc52 - Validators
• 5a7a7077 - More thingies
• bbf24012 - Alternate fit
• 767d3e72 - Added alternate fit
• 0ba23431 - Fixed formatting
• 35466b46 - Added fit result
• 2d1955ce - Played with parameters for best efficiency
• c94d30c1 - Fixed formatting
• d41f4aaa - Fixed formatting
• 7ef73829 - Missing parameter
• 020375f5 - Fixed formatting
• 4c8dac56 - Fixed thiny
• 64d09e77 - Fixing validation VERY STRANGE segfault
• aad1db53 - Assorted things
• ea1f5385 - Fixed problem with segfault
• f25fc695 - Have to put indexing in paralallel for tracks!!!!
• 754c4fd1 - Fixed segfault. FindMuonHits to be checked, search windows?
• 7f92391e - Fixed formatting
• eeb9f0f7 - Tuning parameters and station window passing
• 19b681d8 - This is the best i can do
• 85570cf8 - Fixed formatting
• d6f3903a - Small fix

Compare with previous version

mentioned in issue Moore#432 (closed)

added 113 commits

• d6f3903a...03ed50bd - 76 commits from branch master
• b90b6b18 - MatchVeloMuon first version
• 8ea1b6bd - Refactored quite a bit the code with extreme programming.
• a7af53eb - Fix bug.
• 910c4f59 - Added second loop over M4, also added flagging to avoid clone tracks
• 05c00545 - Succesful use of shared memory for flagging hits
• 0b9458e8 - All to shared memory, no improvement though
• a4e47ac9 - Removed second loop and changed seeding
• 7918248d - Added all possible cases
• 94ac6d3f - First implementation of clone removal.
• b5274ecc - Add FitMuon first trial
• 4ff9233e - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• d5cfeb6f - First step towards checkers
• 6b186a87 - Velo validation
• 24b72fd8 - Validators
• cb537dfb - More thingies
• 59cf388f - Alternate fit
• e2bf183c - Added alternate fit
• f4aac418 - Fixed formatting
• 198c36bf - Added fit result
• adf94af7 - Played with parameters for best efficiency
• 7afb7cbd - Fixed formatting
• c4f4d248 - Fixed formatting
• 2d623df2 - Missing parameter
• 1d67b418 - Fixed formatting
• 9b91dede - Fixed thiny
• 996d27a3 - Fixing validation VERY STRANGE segfault
• 0934d536 - Assorted things
• 417df9a2 - Fixed problem with segfault
• 6d9e3a0c - Have to put indexing in paralallel for tracks!!!!
• d02faef4 - Fixed segfault. FindMuonHits to be checked, search windows?
• ee67986d - Fixed formatting
• f858a264 - Tuning parameters and station window passing
• 5674504e - This is the best i can do
• 21ffa57b - Fixed formatting
• c9e5267a - Small fix
• abac2625 - Fit instead of dists
• 02c3cd20 - Merged FitMuon into FindMuonHits. Removed prefix sums by now

Compare with previous version

added 1 commit

• d0acb705 - Fixed formatting

Compare with previous version

added hlt1-throughput-decreased label

added 44 commits

• d0acb705...74abe94b - 5 commits from branch master
• aef1f5e3 - MatchVeloMuon first version
• cdcc6201 - Refactored quite a bit the code with extreme programming.
• fd536565 - Fix bug.
• f500e2fa - Added second loop over M4, also added flagging to avoid clone tracks
• 6c908ab7 - Succesful use of shared memory for flagging hits
• fe9ffe3c - All to shared memory, no improvement though
• 6c3df203 - Removed second loop and changed seeding
• 4300b5a2 - Added all possible cases
• 829bc86a - First implementation of clone removal.
• 42aec2ff - Add FitMuon first trial
• 7b69222a - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• eed65e00 - First step towards checkers
• d85540bf - Velo validation
• 630dd9df - Validators
• 8800ee35 - More thingies
• 912dfa7c - Alternate fit
• 42e4ee0a - Added alternate fit
• ec42c77b - Fixed formatting
• cd626c63 - Added fit result
• d88df771 - Played with parameters for best efficiency
• 9a8363b2 - Fixed formatting
• 7fadc090 - Fixed formatting
• db245817 - Missing parameter
• 17e86cbc - Fixed formatting
• ad776cf1 - Fixed thiny
• 6b0a2c4e - Fixing validation VERY STRANGE segfault
• c639d465 - Assorted things
• c201b0e7 - Fixed problem with segfault
• 1ba52ad7 - Have to put indexing in paralallel for tracks!!!!
• c0dc1b6d - Fixed segfault. FindMuonHits to be checked, search windows?
• ba7a02d2 - Fixed formatting
• e0012eb8 - Tuning parameters and station window passing
• b29311ef - This is the best i can do
• d7040274 - Fixed formatting
• d46acf19 - Small fix
• e189b356 - Fit instead of dists
• d885cbf1 - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• f1d76308 - Fixed formatting
• 95a83de7 - Fixed indexing causing segfault

Compare with previous version

added 129 commits

• 95a83de7...1ce04df5 - 89 commits from branch master
• cbabb4b3 - MatchVeloMuon first version
• bf8f2c07 - Refactored quite a bit the code with extreme programming.
• edc816e0 - Fix bug.
• e4dd56ed - Added second loop over M4, also added flagging to avoid clone tracks
• 034a0a13 - Succesful use of shared memory for flagging hits
• 6d1c43da - All to shared memory, no improvement though
• 84db5b11 - Removed second loop and changed seeding
• 42d745a3 - Added all possible cases
• f16c6329 - First implementation of clone removal.
• f2023b09 - Add FitMuon first trial
• 36d463b8 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 4b29262e - First step towards checkers
• eca9c1da - Velo validation
• afc11d38 - Validators
• fe0a278b - More thingies
• 0d5301bc - Alternate fit
• 51c47131 - Added alternate fit
• b76ac9ef - Fixed formatting
• c69b3f8f - Added fit result
• e3cf03b6 - Played with parameters for best efficiency
• 6ec6eb53 - Fixed formatting
• bc1a1cc2 - Fixed formatting
• 132bfcde - Missing parameter
• 91b08183 - Fixed formatting
• 718e5302 - Fixed thiny
• aa4a073c - Fixing validation VERY STRANGE segfault
• ef60c72e - Assorted things
• 4e476b08 - Fixed problem with segfault
• 69dbe436 - Have to put indexing in paralallel for tracks!!!!
• 34542515 - Fixed segfault. FindMuonHits to be checked, search windows?
• ce436d04 - Fixed formatting
• 2dd7c9f8 - Tuning parameters and station window passing
• caf7dfcf - This is the best i can do
• e9d9f138 - Fixed formatting
• 6ce5e2d3 - Small fix
• 30a8d053 - Fit instead of dists
• 812d6c6c - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• cc718dda - Fixed formatting
• c1932ff1 - Fixed indexing causing segfault
• c7c1af31 - Corrected small config typo

Compare with previous version

added 2 commits

• 3c12bcbd - Fixed chi2x
• da35c022 - Changed a bit the fit

Compare with previous version

added 48 commits

• da35c022...f32f438e - 3 commits from branch master
• 6883070b - MatchVeloMuon first version
• f3e0bf8d - Refactored quite a bit the code with extreme programming.
• 5c2d0b15 - Fix bug.
• 65f09590 - Added second loop over M4, also added flagging to avoid clone tracks
• 88b14b11 - Succesful use of shared memory for flagging hits
• 14f48efa - All to shared memory, no improvement though
• 3c2fc2a5 - Removed second loop and changed seeding
• 67d5e832 - Added all possible cases
• 86d2b3d4 - First implementation of clone removal.
• 41f24286 - Add FitMuon first trial
• 61e09fa4 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 443b2d32 - First step towards checkers
• 67646e8d - Velo validation
• b97f3ab1 - Validators
• caf2932a - More thingies
• 41098b01 - Alternate fit
• d25fef8a - Added alternate fit
• 21ad0517 - Fixed formatting
• c41d81ab - Added fit result
• e02c411e - Played with parameters for best efficiency
• a2cf571e - Fixed formatting
• 11e65811 - Fixed formatting
• d2b9f674 - Missing parameter
• 56325136 - Fixed formatting
• 7f089d6f - Fixed thiny
• af231397 - Fixing validation VERY STRANGE segfault
• e8f47785 - Assorted things
• d13b9df0 - Fixed problem with segfault
• 13da3da3 - Have to put indexing in paralallel for tracks!!!!
• 6c73fdb5 - Fixed segfault. FindMuonHits to be checked, search windows?
• 8b635240 - Fixed formatting
• 99b49f90 - Tuning parameters and station window passing
• 894d54c6 - This is the best i can do
• d36118fd - Fixed formatting
• 523b895d - Small fix
• 2bc439c9 - Fit instead of dists
• ffd4adf5 - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• 17400d73 - Fixed formatting
• 97da44bc - Fixed indexing causing segfault
• 923f21bb - Corrected small config typo
• 05e4177f - Fixed chi2x
• 9312d366 - Changed a bit the fit
• 466ebbcf - Adding recovery MCTruthMatching stage to all tracks momentarily
• 82cf7f98 - Some changes to have a better id efficiency
• 4e2be00b - Working point: ~0.3 momentum resolution

Compare with previous version

added 1 commit

• 763b8775 - Added OneMuonTrack line. Also added weightedFit funcitonality to FindMuonHits....

Compare with previous version

added 1 commit

• 521b0801 - Added consolidation step for MuonTracks to allow for correctly indexing

Compare with previous version

added 1 commit

• 447ef18a - Fixed formatting

Compare with previous version

added 55 commits

• 447ef18a...9100c897 - 6 commits from branch master
• 30c6187b - MatchVeloMuon first version
• 456acfa3 - Refactored quite a bit the code with extreme programming.
• 7332fdac - Fix bug.
• a8cbec81 - Added second loop over M4, also added flagging to avoid clone tracks
• b772e5c5 - Succesful use of shared memory for flagging hits
• ce66dc75 - All to shared memory, no improvement though
• e65774b9 - Removed second loop and changed seeding
• f76f88ad - Added all possible cases
• 6df53476 - First implementation of clone removal.
• fbfd0b9c - Add FitMuon first trial
• 8f349d46 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 5c5d2e43 - First step towards checkers
• c6dbf144 - Velo validation
• 43f6c7e2 - Validators
• da258a7b - More thingies
• 4cf134d4 - Alternate fit
• 37a5b43a - Added alternate fit
• 28ca125a - Fixed formatting
• dbeb3db2 - Added fit result
• 40f13deb - Played with parameters for best efficiency
• e33ccf73 - Fixed formatting
• 375d2053 - Fixed formatting
• dd99c5d5 - Missing parameter
• 4c4a75b8 - Fixed formatting
• 9ca53ae7 - Fixed thiny
• eb4bc8df - Fixing validation VERY STRANGE segfault
• bc1826cc - Assorted things
• e4adf606 - Fixed problem with segfault
• 3e47f908 - Have to put indexing in paralallel for tracks!!!!
• 175d1f50 - Fixed segfault. FindMuonHits to be checked, search windows?
• 933fac36 - Fixed formatting
• f032c4c8 - Tuning parameters and station window passing
• 25aa305a - This is the best i can do
• 508ea0a7 - Fixed formatting
• 21ed053f - Small fix
• d7c65996 - Fit instead of dists
• 3ce9a02e - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• 801f17ab - Fixed formatting
• af94571c - Fixed indexing causing segfault
• 9962827a - Corrected small config typo
• 7dc9074c - Fixed chi2x
• e17471bb - Changed a bit the fit
• 1f177d64 - Adding recovery MCTruthMatching stage to all tracks momentarily
• 6aa1db0f - Some changes to have a better id efficiency
• 6937e17e - Working point: ~0.3 momentum resolution
• 3a85e06d - Added OneMuonTrack line. Also added weightedFit funcitonality to FindMuonHits....
• 9abb97b7 - Added consolidation step for MuonTracks to allow for correctly indexing
• 35f245c5 - Fixed formatting
• fcfae020 - Fixed HIP compilation

Compare with previous version

added 1 commit

• c9a7ba99 - Fixed formatting

Compare with previous version

added 233 commits

• c9a7ba99...d834e579 - 181 commits from branch master
• eebaaabd - MatchVeloMuon first version
• cc337d99 - Refactored quite a bit the code with extreme programming.
• 01f1becf - Fix bug.
• 99b9113e - Added second loop over M4, also added flagging to avoid clone tracks
• 739fbe5f - Succesful use of shared memory for flagging hits
• 3d805f87 - All to shared memory, no improvement though
• f520841f - Removed second loop and changed seeding
• 36c4ac31 - Added all possible cases
• 9dcc7e21 - First implementation of clone removal.
• 3ec04de9 - Add FitMuon first trial
• 87311013 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• c2e3aff4 - First step towards checkers
• bf320952 - Velo validation
• 7a7617ca - Validators
• 177c0f8f - More thingies
• 9358bd41 - Alternate fit
• 9294e23f - Added alternate fit
• 1cb82808 - Fixed formatting
• f811fc33 - Added fit result
• 4a7881ad - Played with parameters for best efficiency
• 6a6eedce - Fixed formatting
• bf2ef268 - Fixed formatting
• 5809391c - Missing parameter
• ada1cd27 - Fixed formatting
• 42eb6373 - Fixed thiny
• 7e06db1d - Fixing validation VERY STRANGE segfault
• 5515b100 - Assorted things
• f3315208 - Fixed problem with segfault
• 84dea8a5 - Have to put indexing in paralallel for tracks!!!!
• 404b83a0 - Fixed segfault. FindMuonHits to be checked, search windows?
• 1c041936 - Fixed formatting
• c08a1693 - Tuning parameters and station window passing
• facf076b - This is the best i can do
• 0c058260 - Fixed formatting
• 04b13e46 - Small fix
• ca20e847 - Fit instead of dists
• 46e9714b - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• ab71039e - Fixed formatting
• 5af9963d - Fixed indexing causing segfault
• f60d5bdd - Corrected small config typo
• 66650aaa - Fixed chi2x
• c9c45e1b - Changed a bit the fit
• 15b07f0e - Adding recovery MCTruthMatching stage to all tracks momentarily
• 20ad3724 - Some changes to have a better id efficiency
• 3fefd3a0 - Working point: ~0.3 momentum resolution
• 0e447997 - Added OneMuonTrack line. Also added weightedFit funcitonality to FindMuonHits....
• 888824c8 - Added consolidation step for MuonTracks to allow for correctly indexing
• 091a9a11 - Fixed formatting
• ea8b51b1 - Fixed HIP compilation
• 73c79dc9 - Fixed formatting
• 35e00173 - Some warnings
• a51cef25 - Conflict fix

Compare with previous version

added 1 commit

• cd489a8a - Changed optimization level

Compare with previous version

added 1 commit

• e39056fe - Fixed formatting

Compare with previous version

added 1 commit

• 56275d2f - Added Hlt1 VeloMuon decision

Compare with previous version

removed hlt1-throughput-decreased label

added 1 commit

• 9076f28c - Fixed formatting

Compare with previous version

added hlt1-throughput-decreased label

added 62 commits

• 9076f28c...68eca1ee - 4 commits from branch master
• 040a9246 - MatchVeloMuon first version
• e78c67f3 - Refactored quite a bit the code with extreme programming.
• 31c34cd8 - Fix bug.
• a3233487 - Added second loop over M4, also added flagging to avoid clone tracks
• a2db0722 - Succesful use of shared memory for flagging hits
• 11152d4f - All to shared memory, no improvement though
• a4c3db1d - Removed second loop and changed seeding
• c65559ff - Added all possible cases
• 0225645f - First implementation of clone removal.
• fedb2807 - Add FitMuon first trial
• fbbe9abb - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 1dda0b94 - First step towards checkers
• 3b03b5c5 - Velo validation
• bbc8cf20 - Validators
• 01db1c45 - More thingies
• 31bdec65 - Alternate fit
• f8ba430b - Added alternate fit
• 385818fb - Fixed formatting
• a428b4bd - Added fit result
• 393611f9 - Played with parameters for best efficiency
• 7dbe1282 - Fixed formatting
• 436be193 - Fixed formatting
• 4702b0df - Missing parameter
• de462a86 - Fixed formatting
• 2e235f01 - Fixed thiny
• 200cbfd2 - Fixing validation VERY STRANGE segfault
• e2398458 - Assorted things
• 74aff8b0 - Fixed problem with segfault
• 8d42ee93 - Have to put indexing in paralallel for tracks!!!!
• 46e5b372 - Fixed segfault. FindMuonHits to be checked, search windows?
• 8334f4ab - Fixed formatting
• ec4cb526 - Tuning parameters and station window passing
• 744b70da - This is the best i can do
• 2b8fd68a - Fixed formatting
• 7715345b - Small fix
• e463925b - Fit instead of dists
• 489738d4 - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• 0991253c - Fixed formatting
• f17e62a6 - Fixed indexing causing segfault
• 2513f690 - Corrected small config typo
• 0f53ffd7 - Fixed chi2x
• e97294f4 - Changed a bit the fit
• 12566f70 - Adding recovery MCTruthMatching stage to all tracks momentarily
• 546f9a9a - Some changes to have a better id efficiency
• c7f2bef1 - Working point: ~0.3 momentum resolution
• 09834b54 - Added OneMuonTrack line. Also added weightedFit funcitonality to FindMuonHits....
• bff0a9b7 - Added consolidation step for MuonTracks to allow for correctly indexing
• 99199c7f - Fixed formatting
• 5eb33eea - Fixed HIP compilation
• 4e680ce0 - Fixed formatting
• d304f025 - Some warnings
• ab83bbed - Conflict fix
• 18621fd2 - Changed optimization level
• 2e87f856 - Fixed formatting
• d8d0a00d - Added Hlt1 VeloMuon decision
• 0a1d1102 - Fixed formatting
• eb57e35b - Moved to MuonTrack class instead of SoA
• da8e3c6a - Adding copy constructor

Compare with previous version

added 1 commit

• fada811e - Decision based on VeloMuonTracks

Compare with previous version

added 85 commits

• fada811e...2d63abd0 - 24 commits from branch master
• 7f7ff38c - MatchVeloMuon first version
• e17bf6dd - Refactored quite a bit the code with extreme programming.
• 4c33a9e2 - Fix bug.
• 3b10031b - Added second loop over M4, also added flagging to avoid clone tracks
• b51e0ae3 - Succesful use of shared memory for flagging hits
• 3cb78d9d - All to shared memory, no improvement though
• a33f9881 - Removed second loop and changed seeding
• 518a085b - Added all possible cases
• 20dedf0d - First implementation of clone removal.
• 0f687536 - Add FitMuon first trial
• 19867459 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 517a3d7f - First step towards checkers
• 49abc40b - Velo validation
• 484049c7 - Validators
• 08ce37cc - More thingies
• 356a2d04 - Alternate fit
• 6aef7004 - Added alternate fit
• 2347d84f - Fixed formatting
• 93d54559 - Added fit result
• 5695e7cc - Played with parameters for best efficiency
• 4cb4f8c8 - Fixed formatting
• 49e79c63 - Fixed formatting
• 754b7e47 - Missing parameter
• f2a85773 - Fixed formatting
• 42ca23d6 - Fixed thiny
• 8c4045b4 - Fixing validation VERY STRANGE segfault
• 7b96e281 - Assorted things
• 0915ccea - Fixed problem with segfault
• 85c6a06e - Have to put indexing in paralallel for tracks!!!!
• b190bf62 - Fixed segfault. FindMuonHits to be checked, search windows?
• c77bd33b - Fixed formatting
• 8829d3e6 - Tuning parameters and station window passing
• 13261b94 - This is the best i can do
• 3424c04a - Fixed formatting
• 8b8ed5ef - Small fix
• dc65719f - Fit instead of dists
• 8b759c74 - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• b759f780 - Fixed formatting
• 07629eaf - Fixed indexing causing segfault
• abad3ce8 - Corrected small config typo
• 07078aaa - Fixed chi2x
• 6cc46c6e - Changed a bit the fit
• db9120a3 - Adding recovery MCTruthMatching stage to all tracks momentarily
• 5daa9a6a - Some changes to have a better id efficiency
• 8233884d - Working point: ~0.3 momentum resolution
• c488ea27 - Added OneMuonTrack line. Also added weightedFit funcitonality to FindMuonHits....
• 225b719a - Added consolidation step for MuonTracks to allow for correctly indexing
• 2d6d5ec3 - Fixed formatting
• 86bf56c0 - Fixed HIP compilation
• 17422fb2 - Fixed formatting
• 5ba396f7 - Some warnings
• 9f5e39a8 - Conflict fix
• dd1c0ff7 - Changed optimization level
• 40f28333 - Fixed formatting
• f8cabb5b - Added Hlt1 VeloMuon decision
• 34af5174 - Fixed formatting
• 955760f8 - Moved to MuonTrack class instead of SoA
• 438fb2c1 - Adding copy constructor
• 4c09425c - Decision based on VeloMuonTracks
• 1108abf0 - Added monitor function to FindMuonHits. Eliminated some faulty lines
• 1a63c966 - Added Bfield parametrisation for qop calculation

Compare with previous version

added 1 commit

• 804f3091 - Fixed formatting

Compare with previous version

added 1 commit

• 2506cf77 - Improving signal eff

Compare with previous version

added 1 commit

• 0aa7d544 - Ifdef ROOT

Compare with previous version

@dcampora @dovombru do you think you would have the time to review this, or is there someone else who could review it?

mentioned in issue Moore#444 (closed)

added 83 commits

• 0aa7d544...7d78e383 - 17 commits from branch master
• 92f5f81d - MatchVeloMuon first version
• af4249ca - Refactored quite a bit the code with extreme programming.
• 1004e313 - Fix bug.
• 441b5242 - Added second loop over M4, also added flagging to avoid clone tracks
• b715aa83 - Succesful use of shared memory for flagging hits
• cc4c10a9 - All to shared memory, no improvement though
• baad6c65 - Removed second loop and changed seeding
• 992f38a2 - Added all possible cases
• 3d596977 - First implementation of clone removal.
• 6c25b361 - Add FitMuon first trial
• cb8cb0e2 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 128b3862 - First step towards checkers
• 0213ce4b - Velo validation
• a5f48699 - Validators
• 3550b65b - More thingies
• 72702209 - Alternate fit
• 8003a73c - Added alternate fit
• 83d19329 - Fixed formatting
• 9d79ea16 - Added fit result
• 41fbc7bf - Played with parameters for best efficiency
• de71d13b - Fixed formatting
• 9188f8c2 - Fixed formatting
• d29b3c4d - Missing parameter
• 32ce4ca6 - Fixed formatting
• 0b6c1c40 - Fixed thiny
• 9b4df322 - Fixing validation VERY STRANGE segfault
• 74fcfe7d - Assorted things
• 4f0765bb - Fixed problem with segfault
• 9910fc61 - Have to put indexing in paralallel for tracks!!!!
• 6aacbfe3 - Fixed segfault. FindMuonHits to be checked, search windows?
• c2cade8c - Fixed formatting
• 6c5e7e56 - Tuning parameters and station window passing
• f88700a7 - This is the best i can do
• 559f5cfa - Fixed formatting
• 1a1c1f96 - Small fix
• 61272a83 - Fit instead of dists
• b6022ed7 - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• 107b747b - Fixed formatting
• be8553c9 - Fixed indexing causing segfault
• 9879bb54 - Corrected small config typo
• 2c4fad42 - Fixed chi2x
• f23fbeb5 - Changed a bit the fit
• 9350355a - Adding recovery MCTruthMatching stage to all tracks momentarily
• 0fba6f2b - Some changes to have a better id efficiency
• bc956fde - Working point: ~0.3 momentum resolution
• 7839e68e - Added OneMuonTrack line. Also added weightedFit funcitonality to FindMuonHits....
• 93558b11 - Added consolidation step for MuonTracks to allow for correctly indexing
• ca432aa2 - Fixed formatting
• aed37784 - Fixed HIP compilation
• 80b467b3 - Fixed formatting
• cee1f22d - Some warnings
• bfca4510 - Conflict fix
• 64884c44 - Changed optimization level
• 99218c9f - Fixed formatting
• d880eb77 - Added Hlt1 VeloMuon decision
• 2f32ff89 - Fixed formatting
• 0d518e27 - Moved to MuonTrack class instead of SoA
• 93ad1f3a - Adding copy constructor
• fb7a7125 - Decision based on VeloMuonTracks
• 39c98faa - Added monitor function to FindMuonHits. Eliminated some faulty lines
• ae3ef0b7 - Added Bfield parametrisation for qop calculation
• 8db4fade - Fixed formatting
• b17da8b8 - Improving signal eff
• 36607667 - Ifdef ROOT
• ee3809a2 - More logical search windows
• 7e8ce533 - typo in config file

Compare with previous version

added 1 commit

• 70b759f6 - Fixed formatting

Compare with previous version

removed hlt1-throughput-decreased label

mentioned in issue Moore#448 (closed)

mentioned in issue Moore#449 (closed)

mentioned in issue Moore#454 (closed)

requested review from @dcampora

assigned to @acasaisv

/ci-test

Action failed with

"lhcb/Allen!847" cannot be merged

There are merge conflicts, so can't be tested for now.

@acasaisv Could you please fix the conflicts if this is ready for another test?

I will try to fix this ASAP. Main stopper here is that I have work out the checkers from scratch since these have been refactored.

It has been rebased already

Hi @acasaisv could you please check if the Gitlab-CI test failure about the physics efficiencies are expected?

added hlt1-throughput-decreased label

mentioned in issue Moore#456 (closed)

added 285 commits

• 70b759f6...4544f7a7 - 251 commits from branch master
• 10b506ac - MatchVeloMuon first version
• 63becceb - Refactored quite a bit the code with extreme programming.
• efaf9532 - Fix bug.
• 979156b7 - Added second loop over M4, also added flagging to avoid clone tracks
• 304fec77 - Succesful use of shared memory for flagging hits
• bfb23e4c - All to shared memory, no improvement though
• f384fc24 - Removed second loop and changed seeding
• d27ee80f - Added all possible cases
• bf073012 - First implementation of clone removal.
• 91036b74 - Add FitMuon first trial
• 1356bab3 - Added first iteration of MatchVeloMuon based on MatchVeloScifi
• 34733d88 - Velo validation
• c7afe040 - Velo validation
• e9fd8a7a - Validators
• 3b198398 - Alternate fit
• 00af9464 - Added fit result
• 3fbefa42 - Fit instead of dists
• 11472cf0 - Merged FitMuon into FindMuonHits. Removed prefix sums by now
• 15513d27 - Changed a bit the fit
• 1b7c8056 - Adding recovery MCTruthMatching stage to all tracks momentarily
• 4f517e46 - Some changes to have a better id efficiency
• a2fefead - Working point: ~0.3 momentum resolution
• 4a1bc25f - Added OneMuonTrack line. Also added weightedFit funcitonality to FindMuonHits....
• c4296562 - Added consolidation step for MuonTracks to allow for correctly indexing
• f617fe8a - Added Hlt1 VeloMuon decision
• 0c079ecf - Moved to MuonTrack class instead of SoA
• 1f83fc9e - Decision based on VeloMuonTracks
• 498a24ae - Added monitor function to FindMuonHits. Eliminated some faulty lines
• bfeeeea3 - Added Bfield parametrisation for qop calculation
• d9de59dc - Improving signal eff
• fce1c122 - More logical search windows
• 6ae2c1be - First try
• 4da91749 - Fixed runtime error, now fix the checkers
• f4d20d9d - Re-added checkers

Compare with previous version

added 1 commit

• 540a477f - Re-added checkers

Compare with previous version

added 1 commit

• 2978356c - fixed complex validation

Compare with previous version

added 1 commit

• 3d2b0b07 - Fixed formatting

Compare with previous version

removed hlt1-throughput-decreased label

added hlt1-throughput-decreased label