Skip to content
Snippets Groups Projects

Add DD4HEP support for Allen converters that deal with SciFi, Velo, Calo, Magnetic field polarity and the Beamline position

Merged Nabil Garroum requested to merge allen_dd4hep_nabil_2 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Marco Clemencic

      Another problem I found is that the DumpGeometry<T> base class implicitly expects to be able to access the geometry during initialize. While this was true with DetDesc and UpdateManagerSvc (a bit by accident), it does not work with the new system (ConditionAccessorHolder and ConditionAccessor) as it requires an event to be present to be able to access the geometry.

      The (quick) fix (for non-dd4hep builds) is to drop the call updMgrSvc->update(this) in Dumpers/BinaryDumpers/src/DumpGeometry.h:215.

      The proper fix is to stop using the UpdateManagerSvc and use the new geometry/conditions callback infrastructure (i.e. conditions derivations).

  • Nabil Garroum added 1 commit

    added 1 commit

    Compare with previous version

  • Marco Clemencic mentioned in merge request Rec!2860 (merged)

    mentioned in merge request Rec!2860 (merged)

  • Nabil Garroum added 1 commit

    added 1 commit

    • 4209c34f - Delete file zmq/Serialize/ODIN.h

    Compare with previous version

  • Nabil Garroum added 1 commit

    added 1 commit

    • 96fbe67d - Correction for includes for DetDesc/

    Compare with previous version

  • Nabil Garroum added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading