Add DD4HEP support for Allen converters that deal with SciFi, Velo, Calo, Magnetic field polarity and the Beamline position
Depends on LHCb!3575 (merged)
Goes with Moore!1569 (merged) and MooreAnalysis!82 (merged)
Addresses LHCb#215 (closed)
Merge request reports
Activity
added DD4HEP label
added RTA label
Really happy to see this open @ngarroum
@ngarroum could you please fix the copyright and formatting such that we can see how the pipeline does?
added dd4hep lhcb-dd4hep labels
In the men time I'll give it a shot in lhcb-dd4hep.
- [2022-05-06 11:12] Validation started with lhcb-dd4hep#1119
- [2022-05-07 00:08] Validation started with lhcb-dd4hep#1120
- [2022-05-09 00:07] Validation started with lhcb-dd4hep#1121
- [2022-05-10 00:07] Validation started with lhcb-dd4hep#1122
- [2022-05-11 00:10] Validation started with lhcb-dd4hep#1123
- [2022-05-11 10:24] Validation started with lhcb-dd4hep#1124
- [2022-05-12 00:12] Validation started with lhcb-dd4hep#1125
- [2022-05-13 00:10] Validation started with lhcb-dd4hep#1126
Edited by Software for LHCb- Resolved by Nabil Garroum
- Resolved by Nabil Garroum
@ngarroum This MR is causing Allen to fail to build in the lhcb-dd4hep slot
https://lhcb-nightlies.web.cern.ch/nightly/lhcb-dd4hep/1124/
See the dd4hep enabled builds there. Can you take a look please.
assigned to @ngarroum
- Resolved by Nabil Garroum
- Resolved by Roel Aaij
- Resolved by Marco Clemencic
Another problem I found is that the
DumpGeometry<T>
base class implicitly expects to be able to access the geometry during initialize. While this was true with DetDesc and UpdateManagerSvc (a bit by accident), it does not work with the new system (ConditionAccessorHolder
andConditionAccessor
) as it requires an event to be present to be able to access the geometry.The (quick) fix (for non-dd4hep builds) is to drop the call
updMgrSvc->update(this)
inDumpers/BinaryDumpers/src/DumpGeometry.h:215
.The proper fix is to stop using the
UpdateManagerSvc
and use the new geometry/conditions callback infrastructure (i.e. conditions derivations).
- Resolved by Roel Aaij
mentioned in merge request Rec!2860 (merged)