Skip to content
Snippets Groups Projects

Decoding FT v7 in Allen and fixes to CPU v7

Merged Louis Henry requested to merge tmp-lohenry-ftv7-allen into master

Requires LHCb!3572 (merged) and Detector!202 (merged)

  • Implements scifi v7 decoding in Allen.
  • Changes the format of previous scifi geometries, including the geometry version. Hence, all previously dumped geometry versions of Allen become incompatible, and new binary files are required.
  • Implements fixes in LHCb where the bank reordering between A side and C side was not properly implemented and led to a crash in Boole. This is now corrected.
  • Implements several safeguards to reduce seg faults in case the link map is wrong (this is still not 100% done)
    • Related: hardcoded station-1 statements spell difficult-to-debug disaster when an invalid channel is encountered. In general the station = [1,2,3] and station = [0,1,2] conventions need to be spelled out much better.
    • This will be for @jheuel MR on expliciting our conventions
Edited by Daniel Hugo Campora Perez

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @lohenry can you please fix the formatting so that we can test the Allen CI pipeline?

  • Louis Henry added 1 commit

    added 1 commit

    Compare with previous version

  • Louis Henry added 1 commit

    added 1 commit

    • 7dc584c6 - Fixed v7 decoding with a hack to test it on v6 samples

    Compare with previous version

  • Louis Henry mentioned in merge request Moore!1568 (closed)

    mentioned in merge request Moore!1568 (closed)

  • Louis Henry changed the description

    changed the description

  • Louis Henry added 9 commits

    added 9 commits

    Compare with previous version

  • Louis Henry added 1 commit

    added 1 commit

    Compare with previous version

  • Louis Henry added 88 commits

    added 88 commits

    Compare with previous version

  • Louis Henry added 1 commit

    added 1 commit

    • a103c2a0 - Started to make the code more error-resilient

    Compare with previous version

  • Louis Henry added 8 commits

    added 8 commits

    Compare with previous version

  • Louis Henry changed the description

    changed the description

  • Louis Henry added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading