Restore standalone dumping functionality

The dumping of binary files for standalone running of Allen was broken by !855 (merged) and is fixed here.

This allow allowed standardisation of the test for the dumping of the binary file and MDF file containing simulated information for MC validation with standalone Allen.

The converters for the muon detector have been updated to follow recent changes in the muon geometry code.

This MR is the basis for furhter preparations of DD4HEP compatibility, in particular of the UT converters.

Goes with Moore!1592 (merged)

FYI: @ngarroum @samarian

added bug dd4hep labels

requested review from @dovombru

changed the description

added 1 commit

• db91ea48 - Fixed formatting

Compare with previous version

added RTA label

/ci-test --merge Moore!1592 (merged)

Started integration test build. Once done, check the results or the comparison to a reference build.

Throughput Test Moore_hlt2_fastest_reco: 505.6 Events/s -- change of 0.01% vs. reference

Throughput Test Moore_hlt2_pp_thor: 300.1 Events/s -- change of 0.11% vs. reference

Throughput Test Moore_hlt1_pp_default: 28412.0 Events/s -- change of -0.07% vs. reference

@raaij do you understand the differences that caused the broken tests?

Moore: dump_for_standalone_allen fails with a counter mismatch, which I would not expect from only changing the way the information is fetched

(DumpUTGeometry ref) BytesWritten_UTBoards | 59536
    (DumpUTGeometry new) BytesWritten_UTBoards | 29768

Allen: mdf_inpput needs a new reference, since the output of the updater changed

MooreOnline: mep_passthrough needs a new reference, since the output of the updater changed

The counter difference is actually a bug fix. I think previously the file was being written twice. The new value is half of the old value and corresponds to the file size that we have for the tags used in the test.

I think a reference update is needed to fix things.

Hi @raaij, can you please rebase?

Done

added ci-test-triggered label

• [2022-06-04 14:13] Validation started with lhcb-master-mr#4639

added hlt1-throughput-decreased label

It is not clear to me why the physics efficiency test fails for the full Allen CI pipeline. Even the number of reconstructible (MC) particles changes. But there does not seem to be any modification as to which samples are used for the test. Any ideas @raaij ?

added 42 commits

• db91ea48...2d63abd0 - 26 commits from branch master
• 497ac6ee - WIP
• f5127ba5 - Simplify DumpGeometry
• 918d1f87 - Update DumpMuonGeometry to follow changes in muon classes
• ac492830 - Allow dumping binary files from AllenTESProducer and output bytes written as a counter
• f94fe83a - Remove obsolete files
• a69aeee2 - Update config.py and some cleanup
• bfa64042 - Remove obsolete files
• 04e0cdc2 - Cleanup and config update
• 94586670 - Fix reference
• 2514e9a1 - Fix dumping for UT and beamline converters
• 94087b96 - Allow an empty std::any in case a valid ODIN cannot be found
• 31a16516 - Use proper location
• 94330816 - Add old UT dumpers back in
• 2d9ecda3 - Update UT converters and config
• 7273c3fe - Add missing file
• ca508871 - Fixed formatting

Compare with previous version

removed hlt1-throughput-decreased label

After rebasing the full pipeline passes.

added needs ref update label

assigned to @fsouzade

added 9 commits

• 420a1b84 - Converting Muon to algorithms
• 4ae776cd - Make Dumpers compile
• cea54932 - Fix config file
• 3573b508 - Cleaning
• a527ca1e - Re-enable GaudiException
• 6c1d3b85 - Fix compilation crashes
• 9f9042ac - Fixed formatting
• 92fafd3a - Fix dates
• 6d552d5a - Merge branch 'samarian_muonDumper_based_on_v0' into 'improve_dd4hep_compat_v0'

Compare with previous version

added 1 commit

• a77df0d1 - Create AllenUpdater if needed

Compare with previous version

mentioned in merge request !861 (merged)

added 30 commits

• a77df0d1...fbd45d14 - 5 commits from branch master
• 38e819e4 - WIP
• 3e57f9c3 - Simplify DumpGeometry
• 62c832a2 - Update DumpMuonGeometry to follow changes in muon classes
• f39129ad - Allow dumping binary files from AllenTESProducer and output bytes written as a counter
• 5e0d557e - Remove obsolete files
• 56cd70e1 - Update config.py and some cleanup
• c7aac465 - Remove obsolete files
• 12f3bbe1 - Cleanup and config update
• 3d850726 - Fix reference
• 648c43fc - Fix dumping for UT and beamline converters
• 0f18a874 - Allow an empty std::any in case a valid ODIN cannot be found
• 5fdb0274 - Use proper location
• fdc7584f - Add old UT dumpers back in
• 92f7cbf3 - Update UT converters and config
• 04c5f0b2 - Add missing file
• ab9f6ad4 - Fixed formatting
• 9cc50346 - Converting Muon to algorithms
• 2c61c49b - Make Dumpers compile
• c1b71709 - Fix config file
• 9ce5213d - Cleaning
• 6ed59fed - Re-enable GaudiException
• 1d5088e1 - Fix compilation crashes
• d9285c00 - Fixed formatting
• a503a5a6 - Fix dates
• f2971c72 - Create AllenUpdater if needed

Compare with previous version

mentioned in issue Moore#444 (closed)

added 1 commit

• 00d2f9e8 - Fix DD4HEP build of DumpFTGeometry

Compare with previous version

added 1 commit

• ba5a742a - Fix DD4HEP build of DumpFTGeometry

Compare with previous version

added 1 commit

• 1dbee03e - Fix DD4HEP build of DumpFTGeometry

Compare with previous version

added 1 commit

• 859fc7a7 - Fix DD4HEP build of DumpFTGeometry

Compare with previous version

added 1 commit

• 8ff0dba4 - Fix for weird station numbering in DetDesc

Compare with previous version

added 1 commit

• 053d9934 - Fix for weird station numbering in DetDesc

Compare with previous version

added 33 commits

• 053d9934...03ab1abe - 6 commits from branch master
• ab31aeb7 - WIP
• 3d7fed1d - Simplify DumpGeometry
• 380fede6 - Update DumpMuonGeometry to follow changes in muon classes
• 676195ab - Allow dumping binary files from AllenTESProducer and output bytes written as a counter
• 7eab701e - Remove obsolete files
• 8ef57df2 - Update config.py and some cleanup
• 26668d27 - Remove obsolete files
• ecbc6547 - Cleanup and config update
• 8aec1c4e - Fix reference
• 0a14a882 - Fix dumping for UT and beamline converters
• cf995156 - Allow an empty std::any in case a valid ODIN cannot be found
• e4066d57 - Use proper location
• 1c014e66 - Add old UT dumpers back in
• 5b119b7c - Update UT converters and config
• ea318bc6 - Add missing file
• 9670c5d3 - Fixed formatting
• ba96e844 - Converting Muon to algorithms
• 2dcc8629 - Make Dumpers compile
• a291788b - Fix config file
• e06d82ef - Cleaning
• 2c969df0 - Re-enable GaudiException
• 32c3dca3 - Fix compilation crashes
• 6a8d52ac - Fixed formatting
• 98eef706 - Fix dates
• b0677559 - Create AllenUpdater if needed
• d0337c39 - Fix DD4HEP build of DumpFTGeometry
• a79be005 - Fix for weird station numbering in DetDesc

Compare with previous version

All of the changes are also part of !879 (merged)

closed