Add reference bot for Allen
This MR finally adds a reference bot for Allen
FYI @rmatev
Merge request reports
Activity
added RTA label
The refbot only understand the default nightly system. It starts by looking at the results from an
lhcb-master-mr
slot to determine which builds/tests etc. failed.
Based on that information, it knows how to get the updated reference files from the tests that ran in the ci-test slot.This will of course also work for Allen, but Allen only has 6 tests in the default nightly system out of which only 1 uses a reference and that ref is pretty minimal.
All the real tests for the Allen project use their own system and are run from the GitLab-ci.
So one might hit the update button, and everything will look green and this might be misleading because in reality one still needs to do the reference update by hand for Allen.
mmm. Still, this feels better than nothing.
Why couldn't the ref-bot learn how to interact with the GitLab-ci? I feel like we should not give up on such a beautiful concept as "Allen can have automatic reference updates" so easily now someone actually showed a willingness to prioritise work on it...
to be clear, this MR is solving the case of !751 (merged), namely, a change in Allen causes a need for a ref update in a downstream project.
The ref updates for Allen's gitlab CI are probably best done slightly differently (perhaps like the lhcb formatting (you get a "curl ..." to run locally)). I discussed briefly with @dcampora who'll make sure it's followed up.
My hope would be that in the new nightly system, Allen tests could be migrated to the common framework and then the refbot will just work.
That sounds more maintainable to me than having to continue to have two different testing strategies.Edited by Christoph Hasseok I am getting a strong "let's discuss this another time" hint so I'll leave it there
but for what it is worth I am in full agreement with @chasse that one testing strategy is the best path
mentioned in merge request !891 (closed)
mentioned in merge request lhcb-rta/reference-update-bot!32 (merged)
assigned to @rmatev
added Build cleanup only GitLab CI labels
mentioned in commit fbd45d14
mentioned in issue Moore#444 (closed)
mentioned in issue Moore#448 (closed)
mentioned in issue Moore#449 (closed)
mentioned in issue Moore#454 (closed)